Re: [edk2] [PATCH v1 00/10] UDF: Bugfixes
Paulo and Star, Thanks a lot for the review. Series pushed at 4df8f5bfa2.. 68099b52b0. Best Regards, Hao Wu > -Original Message- > From: edk2-devel [mailto:edk2-devel-boun...@lists.01.org] On Behalf Of Wu, > Hao A > Sent: Tuesday, October 23, 2018 2:10 PM > To: Zeng, Star; Paulo Alcantara; edk2-devel@lists.01.org > Cc: Ni, Ruiyu; Yao, Jiewen > Subject: Re: [edk2] [PATCH v1 00/10] UDF: Bugfixes > > > -Original Message- > > From: Zeng, Star > > Sent: Tuesday, October 23, 2018 1:46 PM > > To: Paulo Alcantara; Wu, Hao A; edk2-devel@lists.01.org > > Cc: Ni, Ruiyu; Yao, Jiewen; Zeng, Star > > Subject: Re: [edk2] [PATCH v1 00/10] UDF: Bugfixes > > > > On 2018/10/22 22:39, Paulo Alcantara wrote: > > > Hao Wu writes: > > > > > >> The series will address a couple of bugs within the UDF related codes. > > >> > > >> Please refer to the log message of each commit for more details. > > >> > > >> Cc: Paulo Alcantara > > >> Cc: Ruiyu Ni > > >> Cc: Jiewen Yao > > >> Cc: Star Zeng > > >> > > >> Hao Wu (10): > > >>MdeModulePkg/PartitionDxe: Add check for underlying device block > size > > >>MdeModulePkg/UdfDxe: Refine boundary checks for file/path name > > string > > >>MdeModulePkg/UdfDxe: Add boundary check the read of FE/EFE > > >>MdeModulePkg/UdfDxe: Add boundary check for ComponentIdentifier > > decode > > >>MdeModulePkg/UdfDxe: Add boundary check for getting volume (free) > > size > > >>MdeModulePkg/UdfDxe: Correct behavior for UdfSetPosition() > > >>MdeModulePkg/UdfDxe: Fix a typo within SetFileInfo() > > >>MdeModulePkg/UdfDxe: Update GetInfo() for FS VolumeLabel info > > request > > >>MdeModulePkg/UdfDxe: Add more check when getting PD from LongAd > > >>MdeModulePkg/UdfDxe: Avoid possible use of already-freed data > > >> > > >> MdeModulePkg/Universal/Disk/PartitionDxe/Udf.c| 28 +++ > > >> MdeModulePkg/Universal/Disk/UdfDxe/File.c | 96 > > >> > > >> MdeModulePkg/Universal/Disk/UdfDxe/FileSystemOperations.c | 253 > > ++-- > > >> MdeModulePkg/Universal/Disk/UdfDxe/Udf.h | 63 - > > >> MdeModulePkg/Universal/Disk/UdfDxe/UdfDxe.inf | 1 + > > >> 5 files changed, 362 insertions(+), 79 deletions(-) > > > > > > For the series: > > > > > > Reviewed-by: Paulo Alcantara > > > > I could not review the in detail. > > Thanks Paulo's Reviewed-by. > > > > I have two minor feedback. > > 1. I saw some place using 'basic validations' and some place using > > 'basic validation', should they be aligned? > > 2. I think you can add "Copyright (c) 2018, Intel Corporation. All > > rights reserved." for every file you changed. > > > > Acked-by: Star Zeng > > Thanks. I will address the above 2 points before push. > > Best Regards, > Hao Wu > > > > > Thanks, > > Star > > > > > > > > Thanks! > > > Paulo > > > > > ___ > edk2-devel mailing list > edk2-devel@lists.01.org > https://lists.01.org/mailman/listinfo/edk2-devel ___ edk2-devel mailing list edk2-devel@lists.01.org https://lists.01.org/mailman/listinfo/edk2-devel
Re: [edk2] [PATCH v1 00/10] UDF: Bugfixes
> -Original Message- > From: Zeng, Star > Sent: Tuesday, October 23, 2018 1:46 PM > To: Paulo Alcantara; Wu, Hao A; edk2-devel@lists.01.org > Cc: Ni, Ruiyu; Yao, Jiewen; Zeng, Star > Subject: Re: [edk2] [PATCH v1 00/10] UDF: Bugfixes > > On 2018/10/22 22:39, Paulo Alcantara wrote: > > Hao Wu writes: > > > >> The series will address a couple of bugs within the UDF related codes. > >> > >> Please refer to the log message of each commit for more details. > >> > >> Cc: Paulo Alcantara > >> Cc: Ruiyu Ni > >> Cc: Jiewen Yao > >> Cc: Star Zeng > >> > >> Hao Wu (10): > >>MdeModulePkg/PartitionDxe: Add check for underlying device block size > >>MdeModulePkg/UdfDxe: Refine boundary checks for file/path name > string > >>MdeModulePkg/UdfDxe: Add boundary check the read of FE/EFE > >>MdeModulePkg/UdfDxe: Add boundary check for ComponentIdentifier > decode > >>MdeModulePkg/UdfDxe: Add boundary check for getting volume (free) > size > >>MdeModulePkg/UdfDxe: Correct behavior for UdfSetPosition() > >>MdeModulePkg/UdfDxe: Fix a typo within SetFileInfo() > >>MdeModulePkg/UdfDxe: Update GetInfo() for FS VolumeLabel info > request > >>MdeModulePkg/UdfDxe: Add more check when getting PD from LongAd > >>MdeModulePkg/UdfDxe: Avoid possible use of already-freed data > >> > >> MdeModulePkg/Universal/Disk/PartitionDxe/Udf.c| 28 +++ > >> MdeModulePkg/Universal/Disk/UdfDxe/File.c | 96 > >> MdeModulePkg/Universal/Disk/UdfDxe/FileSystemOperations.c | 253 > ++-- > >> MdeModulePkg/Universal/Disk/UdfDxe/Udf.h | 63 - > >> MdeModulePkg/Universal/Disk/UdfDxe/UdfDxe.inf | 1 + > >> 5 files changed, 362 insertions(+), 79 deletions(-) > > > > For the series: > > > > Reviewed-by: Paulo Alcantara > > I could not review the in detail. > Thanks Paulo's Reviewed-by. > > I have two minor feedback. > 1. I saw some place using 'basic validations' and some place using > 'basic validation', should they be aligned? > 2. I think you can add "Copyright (c) 2018, Intel Corporation. All > rights reserved." for every file you changed. > > Acked-by: Star Zeng Thanks. I will address the above 2 points before push. Best Regards, Hao Wu > > Thanks, > Star > > > > > Thanks! > > Paulo > > ___ edk2-devel mailing list edk2-devel@lists.01.org https://lists.01.org/mailman/listinfo/edk2-devel
Re: [edk2] [PATCH v1 00/10] UDF: Bugfixes
On 2018/10/22 22:39, Paulo Alcantara wrote: Hao Wu writes: The series will address a couple of bugs within the UDF related codes. Please refer to the log message of each commit for more details. Cc: Paulo Alcantara Cc: Ruiyu Ni Cc: Jiewen Yao Cc: Star Zeng Hao Wu (10): MdeModulePkg/PartitionDxe: Add check for underlying device block size MdeModulePkg/UdfDxe: Refine boundary checks for file/path name string MdeModulePkg/UdfDxe: Add boundary check the read of FE/EFE MdeModulePkg/UdfDxe: Add boundary check for ComponentIdentifier decode MdeModulePkg/UdfDxe: Add boundary check for getting volume (free) size MdeModulePkg/UdfDxe: Correct behavior for UdfSetPosition() MdeModulePkg/UdfDxe: Fix a typo within SetFileInfo() MdeModulePkg/UdfDxe: Update GetInfo() for FS VolumeLabel info request MdeModulePkg/UdfDxe: Add more check when getting PD from LongAd MdeModulePkg/UdfDxe: Avoid possible use of already-freed data MdeModulePkg/Universal/Disk/PartitionDxe/Udf.c| 28 +++ MdeModulePkg/Universal/Disk/UdfDxe/File.c | 96 MdeModulePkg/Universal/Disk/UdfDxe/FileSystemOperations.c | 253 ++-- MdeModulePkg/Universal/Disk/UdfDxe/Udf.h | 63 - MdeModulePkg/Universal/Disk/UdfDxe/UdfDxe.inf | 1 + 5 files changed, 362 insertions(+), 79 deletions(-) For the series: Reviewed-by: Paulo Alcantara I could not review the in detail. Thanks Paulo's Reviewed-by. I have two minor feedback. 1. I saw some place using 'basic validations' and some place using 'basic validation', should they be aligned? 2. I think you can add "Copyright (c) 2018, Intel Corporation. All rights reserved." for every file you changed. Acked-by: Star Zeng Thanks, Star Thanks! Paulo ___ edk2-devel mailing list edk2-devel@lists.01.org https://lists.01.org/mailman/listinfo/edk2-devel
Re: [edk2] [PATCH v1 00/10] UDF: Bugfixes
Hao Wu writes: > The series will address a couple of bugs within the UDF related codes. > > Please refer to the log message of each commit for more details. > > Cc: Paulo Alcantara > Cc: Ruiyu Ni > Cc: Jiewen Yao > Cc: Star Zeng > > Hao Wu (10): > MdeModulePkg/PartitionDxe: Add check for underlying device block size > MdeModulePkg/UdfDxe: Refine boundary checks for file/path name string > MdeModulePkg/UdfDxe: Add boundary check the read of FE/EFE > MdeModulePkg/UdfDxe: Add boundary check for ComponentIdentifier decode > MdeModulePkg/UdfDxe: Add boundary check for getting volume (free) size > MdeModulePkg/UdfDxe: Correct behavior for UdfSetPosition() > MdeModulePkg/UdfDxe: Fix a typo within SetFileInfo() > MdeModulePkg/UdfDxe: Update GetInfo() for FS VolumeLabel info request > MdeModulePkg/UdfDxe: Add more check when getting PD from LongAd > MdeModulePkg/UdfDxe: Avoid possible use of already-freed data > > MdeModulePkg/Universal/Disk/PartitionDxe/Udf.c| 28 +++ > MdeModulePkg/Universal/Disk/UdfDxe/File.c | 96 > MdeModulePkg/Universal/Disk/UdfDxe/FileSystemOperations.c | 253 > ++-- > MdeModulePkg/Universal/Disk/UdfDxe/Udf.h | 63 - > MdeModulePkg/Universal/Disk/UdfDxe/UdfDxe.inf | 1 + > 5 files changed, 362 insertions(+), 79 deletions(-) For the series: Reviewed-by: Paulo Alcantara Thanks! Paulo ___ edk2-devel mailing list edk2-devel@lists.01.org https://lists.01.org/mailman/listinfo/edk2-devel
[edk2] [PATCH v1 00/10] UDF: Bugfixes
The series will address a couple of bugs within the UDF related codes. Please refer to the log message of each commit for more details. Cc: Paulo Alcantara Cc: Ruiyu Ni Cc: Jiewen Yao Cc: Star Zeng Hao Wu (10): MdeModulePkg/PartitionDxe: Add check for underlying device block size MdeModulePkg/UdfDxe: Refine boundary checks for file/path name string MdeModulePkg/UdfDxe: Add boundary check the read of FE/EFE MdeModulePkg/UdfDxe: Add boundary check for ComponentIdentifier decode MdeModulePkg/UdfDxe: Add boundary check for getting volume (free) size MdeModulePkg/UdfDxe: Correct behavior for UdfSetPosition() MdeModulePkg/UdfDxe: Fix a typo within SetFileInfo() MdeModulePkg/UdfDxe: Update GetInfo() for FS VolumeLabel info request MdeModulePkg/UdfDxe: Add more check when getting PD from LongAd MdeModulePkg/UdfDxe: Avoid possible use of already-freed data MdeModulePkg/Universal/Disk/PartitionDxe/Udf.c| 28 +++ MdeModulePkg/Universal/Disk/UdfDxe/File.c | 96 MdeModulePkg/Universal/Disk/UdfDxe/FileSystemOperations.c | 253 ++-- MdeModulePkg/Universal/Disk/UdfDxe/Udf.h | 63 - MdeModulePkg/Universal/Disk/UdfDxe/UdfDxe.inf | 1 + 5 files changed, 362 insertions(+), 79 deletions(-) -- 2.12.0.windows.1 ___ edk2-devel mailing list edk2-devel@lists.01.org https://lists.01.org/mailman/listinfo/edk2-devel
