Re: [edk2] [PATCH v2] MdeModulePkg: Add DEBUG statement when reaching max perf log entries
On 2015/11/2 10:24, El-Haj-Mahmoud, Samer wrote: Yes please fix the typo and commit it thank you for your help. Committed at R18714. Thanks, Star -Original Message- From: Zeng, Star [star.z...@intel.com] Received: Sunday, 01 Nov 2015, 7:57PM To: El-Haj-Mahmoud, Samer [samer.el-haj-mahm...@hpe.com]; edk2-devel@lists.01.org [edk2-devel@lists.01.org] CC: feng.t...@intel.com [feng.t...@intel.com] Subject: Re: [edk2] [PATCH v2] MdeModulePkg: Add DEBUG statement when reaching max perf log entries On 2015/11/2 9:28, Zeng, Star wrote: On 2015/10/31 7:12, Samer El-Haj-Mahmoud wrote: Add a DEBUG statement when the number of PEI perf log entries exceeds PcdMaxPeiPerformanceLogEntries Contributed-under: TianoCore Contribution Agreement 1.0 Signed-off-by: Samer El-Haj-Mahmoud <samer.el-haj-mahm...@hpe.com> --- MdeModulePkg/Library/PeiPerformanceLib/PeiPerformanceLib.c | 2 ++ 1 file changed, 2 insertions(+) Reviewed-by: Star Zeng <star.z...@intel.com> Oh, add one minor comment below. diff --git a/MdeModulePkg/Library/PeiPerformanceLib/PeiPerformanceLib.c b/MdeModulePkg/Library/PeiPerformanceLib/PeiPerformanceLib.c index 0b5a717..fdc0ae0 100644 --- a/MdeModulePkg/Library/PeiPerformanceLib/PeiPerformanceLib.c +++ b/MdeModulePkg/Library/PeiPerformanceLib/PeiPerformanceLib.c @@ -7,6 +7,7 @@ number of performance logging entry is specified by PcdMaxPeiPerformanceLogEntries. Copyright (c) 2006 - 2015, Intel Corporation. All rights reserved. +(C) Copyright 2015 Hewlett Packard Enterprise Development LP This program and the accompanying materials are licensed and made available under the terms and conditions of the BSD License which accompanies this distribution. The full text of the license may be found at @@ -183,6 +184,7 @@ StartPerformanceMeasurementEx ( InternalGetPerformanceHobLog (, ); if (PeiPerformanceLog->NumberOfEntries >= PcdGet8 (PcdMaxPeiPerformanceLogEntries)) { +DEBUG ((DEBUG_ERROR, "PEI performance log arrray out of resources\n")); The "arrray" should be "array", right? If you are ok, I will help commit this patch with the correct "array". Thanks, Star return RETURN_OUT_OF_RESOURCES; } Index = PeiPerformanceLog->NumberOfEntries++; ___ edk2-devel mailing list edk2-devel@lists.01.org https://lists.01.org/mailman/listinfo/edk2-devel
Re: [edk2] [PATCH v2] MdeModulePkg: Add DEBUG statement when reaching max perf log entries
Yes please fix the typo and commit it thank you for your help. -Original Message- From: Zeng, Star [star.z...@intel.com] Received: Sunday, 01 Nov 2015, 7:57PM To: El-Haj-Mahmoud, Samer [samer.el-haj-mahm...@hpe.com]; edk2-devel@lists.01.org [edk2-devel@lists.01.org] CC: feng.t...@intel.com [feng.t...@intel.com] Subject: Re: [edk2] [PATCH v2] MdeModulePkg: Add DEBUG statement when reaching max perf log entries On 2015/11/2 9:28, Zeng, Star wrote: > On 2015/10/31 7:12, Samer El-Haj-Mahmoud wrote: >> Add a DEBUG statement when the number of PEI perf log entries >> exceeds PcdMaxPeiPerformanceLogEntries >> >> Contributed-under: TianoCore Contribution Agreement 1.0 >> Signed-off-by: Samer El-Haj-Mahmoud <samer.el-haj-mahm...@hpe.com> >> --- >> MdeModulePkg/Library/PeiPerformanceLib/PeiPerformanceLib.c | 2 ++ >> 1 file changed, 2 insertions(+) > > Reviewed-by: Star Zeng <star.z...@intel.com> Oh, add one minor comment below. > >> >> diff --git >> a/MdeModulePkg/Library/PeiPerformanceLib/PeiPerformanceLib.c >> b/MdeModulePkg/Library/PeiPerformanceLib/PeiPerformanceLib.c >> index 0b5a717..fdc0ae0 100644 >> --- a/MdeModulePkg/Library/PeiPerformanceLib/PeiPerformanceLib.c >> +++ b/MdeModulePkg/Library/PeiPerformanceLib/PeiPerformanceLib.c >> @@ -7,6 +7,7 @@ >> number of performance logging entry is specified by >> PcdMaxPeiPerformanceLogEntries. >> >> Copyright (c) 2006 - 2015, Intel Corporation. All rights reserved. >> +(C) Copyright 2015 Hewlett Packard Enterprise Development LP >> This program and the accompanying materials >> are licensed and made available under the terms and conditions of >> the BSD License >> which accompanies this distribution. The full text of the license >> may be found at >> @@ -183,6 +184,7 @@ StartPerformanceMeasurementEx ( >> InternalGetPerformanceHobLog (, >> ); >> >> if (PeiPerformanceLog->NumberOfEntries >= PcdGet8 >> (PcdMaxPeiPerformanceLogEntries)) { >> +DEBUG ((DEBUG_ERROR, "PEI performance log arrray out of >> resources\n")); The "arrray" should be "array", right? If you are ok, I will help commit this patch with the correct "array". Thanks, Star >> return RETURN_OUT_OF_RESOURCES; >> } >> Index = PeiPerformanceLog->NumberOfEntries++; >> ___ edk2-devel mailing list edk2-devel@lists.01.org https://lists.01.org/mailman/listinfo/edk2-devel
Re: [edk2] [PATCH v2] MdeModulePkg: Add DEBUG statement when reaching max perf log entries
On 2015/10/31 7:12, Samer El-Haj-Mahmoud wrote: Add a DEBUG statement when the number of PEI perf log entries exceeds PcdMaxPeiPerformanceLogEntries Contributed-under: TianoCore Contribution Agreement 1.0 Signed-off-by: Samer El-Haj-Mahmoud--- MdeModulePkg/Library/PeiPerformanceLib/PeiPerformanceLib.c | 2 ++ 1 file changed, 2 insertions(+) Reviewed-by: Star Zeng diff --git a/MdeModulePkg/Library/PeiPerformanceLib/PeiPerformanceLib.c b/MdeModulePkg/Library/PeiPerformanceLib/PeiPerformanceLib.c index 0b5a717..fdc0ae0 100644 --- a/MdeModulePkg/Library/PeiPerformanceLib/PeiPerformanceLib.c +++ b/MdeModulePkg/Library/PeiPerformanceLib/PeiPerformanceLib.c @@ -7,6 +7,7 @@ number of performance logging entry is specified by PcdMaxPeiPerformanceLogEntries. Copyright (c) 2006 - 2015, Intel Corporation. All rights reserved. +(C) Copyright 2015 Hewlett Packard Enterprise Development LP This program and the accompanying materials are licensed and made available under the terms and conditions of the BSD License which accompanies this distribution. The full text of the license may be found at @@ -183,6 +184,7 @@ StartPerformanceMeasurementEx ( InternalGetPerformanceHobLog (, ); if (PeiPerformanceLog->NumberOfEntries >= PcdGet8 (PcdMaxPeiPerformanceLogEntries)) { +DEBUG ((DEBUG_ERROR, "PEI performance log arrray out of resources\n")); return RETURN_OUT_OF_RESOURCES; } Index = PeiPerformanceLog->NumberOfEntries++; ___ edk2-devel mailing list edk2-devel@lists.01.org https://lists.01.org/mailman/listinfo/edk2-devel
Re: [edk2] [PATCH v2] MdeModulePkg: Add DEBUG statement when reaching max perf log entries
On 2015/11/2 9:28, Zeng, Star wrote: On 2015/10/31 7:12, Samer El-Haj-Mahmoud wrote: Add a DEBUG statement when the number of PEI perf log entries exceeds PcdMaxPeiPerformanceLogEntries Contributed-under: TianoCore Contribution Agreement 1.0 Signed-off-by: Samer El-Haj-Mahmoud--- MdeModulePkg/Library/PeiPerformanceLib/PeiPerformanceLib.c | 2 ++ 1 file changed, 2 insertions(+) Reviewed-by: Star Zeng Oh, add one minor comment below. diff --git a/MdeModulePkg/Library/PeiPerformanceLib/PeiPerformanceLib.c b/MdeModulePkg/Library/PeiPerformanceLib/PeiPerformanceLib.c index 0b5a717..fdc0ae0 100644 --- a/MdeModulePkg/Library/PeiPerformanceLib/PeiPerformanceLib.c +++ b/MdeModulePkg/Library/PeiPerformanceLib/PeiPerformanceLib.c @@ -7,6 +7,7 @@ number of performance logging entry is specified by PcdMaxPeiPerformanceLogEntries. Copyright (c) 2006 - 2015, Intel Corporation. All rights reserved. +(C) Copyright 2015 Hewlett Packard Enterprise Development LP This program and the accompanying materials are licensed and made available under the terms and conditions of the BSD License which accompanies this distribution. The full text of the license may be found at @@ -183,6 +184,7 @@ StartPerformanceMeasurementEx ( InternalGetPerformanceHobLog (, ); if (PeiPerformanceLog->NumberOfEntries >= PcdGet8 (PcdMaxPeiPerformanceLogEntries)) { +DEBUG ((DEBUG_ERROR, "PEI performance log arrray out of resources\n")); The "arrray" should be "array", right? If you are ok, I will help commit this patch with the correct "array". Thanks, Star return RETURN_OUT_OF_RESOURCES; } Index = PeiPerformanceLog->NumberOfEntries++; ___ edk2-devel mailing list edk2-devel@lists.01.org https://lists.01.org/mailman/listinfo/edk2-devel
[edk2] [PATCH v2] MdeModulePkg: Add DEBUG statement when reaching max perf log entries
Add a DEBUG statement when the number of PEI perf log entries exceeds PcdMaxPeiPerformanceLogEntries Contributed-under: TianoCore Contribution Agreement 1.0 Signed-off-by: Samer El-Haj-Mahmoud--- MdeModulePkg/Library/PeiPerformanceLib/PeiPerformanceLib.c | 2 ++ 1 file changed, 2 insertions(+) diff --git a/MdeModulePkg/Library/PeiPerformanceLib/PeiPerformanceLib.c b/MdeModulePkg/Library/PeiPerformanceLib/PeiPerformanceLib.c index 0b5a717..fdc0ae0 100644 --- a/MdeModulePkg/Library/PeiPerformanceLib/PeiPerformanceLib.c +++ b/MdeModulePkg/Library/PeiPerformanceLib/PeiPerformanceLib.c @@ -7,6 +7,7 @@ number of performance logging entry is specified by PcdMaxPeiPerformanceLogEntries. Copyright (c) 2006 - 2015, Intel Corporation. All rights reserved. +(C) Copyright 2015 Hewlett Packard Enterprise Development LP This program and the accompanying materials are licensed and made available under the terms and conditions of the BSD License which accompanies this distribution. The full text of the license may be found at @@ -183,6 +184,7 @@ StartPerformanceMeasurementEx ( InternalGetPerformanceHobLog (, ); if (PeiPerformanceLog->NumberOfEntries >= PcdGet8 (PcdMaxPeiPerformanceLogEntries)) { +DEBUG ((DEBUG_ERROR, "PEI performance log arrray out of resources\n")); return RETURN_OUT_OF_RESOURCES; } Index = PeiPerformanceLog->NumberOfEntries++; -- 1.9.5.msysgit.1 ___ edk2-devel mailing list edk2-devel@lists.01.org https://lists.01.org/mailman/listinfo/edk2-devel