Re: [edk2] [PATCH v3 0/3] ArmPlatformPkg: FVP spring cleaning -- EDK2 edition

2017-04-11 Thread Ryan Harkin 
On 10 April 2017 at 17:33, Leif Lindholm  wrote:
> On Mon, Apr 10, 2017 at 05:21:49PM +0100, Ard Biesheuvel wrote:
>> This v3 of the ArmPlatformPkg now only contains FVP changes. TC2 and Juno
>> will receive a similar treatment once we have sorted out how the loading of
>> the DTB image from the NOR flash will be implemented.
>>
>> So what remains here is two somewhat unrelated cleanup patches, and the
>> meat in #3 which removes the functionality that interoperates with the
>> FdtPlatformDxe that we are trying to get rid of.
>>
>
> For the series:
> Reviewed-by: Leif Lindholm 
>

This deletes some seriously nasty code!

Tested on FVP Foundation & AEMv8, TC2 and Juno R0/1/2.

Tested-by: Ryan Harkin 


>> Ard Biesheuvel (3):
>>   ArmPlatformPkg/ArmVExpressDxe: remove ARM support
>>   ArmPlatformPkg/ArmVExpressDxe: remove unused cruft from ArmHwDxe
>>   ArmPlatformPkg/ArmVExpressDxe: remove FDT handling from ArmFvpDxe
>>
>>  ArmPlatformPkg/ArmVExpressPkg/ArmVExpressDxe/AArch64/ArmFvpDxeAArch64.c | 
>> 113 
>>  ArmPlatformPkg/ArmVExpressPkg/ArmVExpressDxe/Arm/ArmFvpDxeArm.c |  
>> 84 
>>  ArmPlatformPkg/ArmVExpressPkg/ArmVExpressDxe/ArmFvpDxe.c| 
>> 137 +---
>>  ArmPlatformPkg/ArmVExpressPkg/ArmVExpressDxe/ArmFvpDxe.inf  |  
>> 42 --
>>  ArmPlatformPkg/ArmVExpressPkg/ArmVExpressDxe/ArmHwDxe.c |  
>> 43 +-
>>  ArmPlatformPkg/ArmVExpressPkg/ArmVExpressDxe/ArmHwDxe.inf   |   
>> 3 -
>>  ArmPlatformPkg/ArmVExpressPkg/ArmVExpressDxe/ArmVExpressCommon.c|  
>> 48 ---
>>  ArmPlatformPkg/ArmVExpressPkg/ArmVExpressDxe/ArmVExpressInternal.h  |  
>> 99 --
>>  ArmPlatformPkg/ArmVExpressPkg/ArmVExpressPkg.dec|  
>> 28 
>>  9 files changed, 6 insertions(+), 591 deletions(-)
>>  delete mode 100644 
>> ArmPlatformPkg/ArmVExpressPkg/ArmVExpressDxe/AArch64/ArmFvpDxeAArch64.c
>>  delete mode 100644 
>> ArmPlatformPkg/ArmVExpressPkg/ArmVExpressDxe/Arm/ArmFvpDxeArm.c
>>  delete mode 100644 
>> ArmPlatformPkg/ArmVExpressPkg/ArmVExpressDxe/ArmVExpressCommon.c
>>  delete mode 100644 
>> ArmPlatformPkg/ArmVExpressPkg/ArmVExpressDxe/ArmVExpressInternal.h
>>
>> --
>> 2.9.3
>>
___
edk2-devel mailing list
edk2-devel@lists.01.org
https://lists.01.org/mailman/listinfo/edk2-devel

Re: [edk2] [PATCH v3 0/3] ArmPlatformPkg: FVP spring cleaning -- EDK2 edition

2017-04-10 Thread Leif Lindholm 
On Mon, Apr 10, 2017 at 05:21:49PM +0100, Ard Biesheuvel wrote:
> This v3 of the ArmPlatformPkg now only contains FVP changes. TC2 and Juno
> will receive a similar treatment once we have sorted out how the loading of
> the DTB image from the NOR flash will be implemented.
> 
> So what remains here is two somewhat unrelated cleanup patches, and the
> meat in #3 which removes the functionality that interoperates with the
> FdtPlatformDxe that we are trying to get rid of.
> 

For the series:
Reviewed-by: Leif Lindholm 

> Ard Biesheuvel (3):
>   ArmPlatformPkg/ArmVExpressDxe: remove ARM support
>   ArmPlatformPkg/ArmVExpressDxe: remove unused cruft from ArmHwDxe
>   ArmPlatformPkg/ArmVExpressDxe: remove FDT handling from ArmFvpDxe
> 
>  ArmPlatformPkg/ArmVExpressPkg/ArmVExpressDxe/AArch64/ArmFvpDxeAArch64.c | 
> 113 
>  ArmPlatformPkg/ArmVExpressPkg/ArmVExpressDxe/Arm/ArmFvpDxeArm.c |  
> 84 
>  ArmPlatformPkg/ArmVExpressPkg/ArmVExpressDxe/ArmFvpDxe.c| 
> 137 +---
>  ArmPlatformPkg/ArmVExpressPkg/ArmVExpressDxe/ArmFvpDxe.inf  |  
> 42 --
>  ArmPlatformPkg/ArmVExpressPkg/ArmVExpressDxe/ArmHwDxe.c |  
> 43 +-
>  ArmPlatformPkg/ArmVExpressPkg/ArmVExpressDxe/ArmHwDxe.inf   |   
> 3 -
>  ArmPlatformPkg/ArmVExpressPkg/ArmVExpressDxe/ArmVExpressCommon.c|  
> 48 ---
>  ArmPlatformPkg/ArmVExpressPkg/ArmVExpressDxe/ArmVExpressInternal.h  |  
> 99 --
>  ArmPlatformPkg/ArmVExpressPkg/ArmVExpressPkg.dec|  
> 28 
>  9 files changed, 6 insertions(+), 591 deletions(-)
>  delete mode 100644 
> ArmPlatformPkg/ArmVExpressPkg/ArmVExpressDxe/AArch64/ArmFvpDxeAArch64.c
>  delete mode 100644 
> ArmPlatformPkg/ArmVExpressPkg/ArmVExpressDxe/Arm/ArmFvpDxeArm.c
>  delete mode 100644 
> ArmPlatformPkg/ArmVExpressPkg/ArmVExpressDxe/ArmVExpressCommon.c
>  delete mode 100644 
> ArmPlatformPkg/ArmVExpressPkg/ArmVExpressDxe/ArmVExpressInternal.h
> 
> -- 
> 2.9.3
> 
___
edk2-devel mailing list
edk2-devel@lists.01.org
https://lists.01.org/mailman/listinfo/edk2-devel

[edk2] [PATCH v3 0/3] ArmPlatformPkg: FVP spring cleaning -- EDK2 edition

2017-04-10 Thread Ard Biesheuvel 
This v3 of the ArmPlatformPkg now only contains FVP changes. TC2 and Juno
will receive a similar treatment once we have sorted out how the loading of
the DTB image from the NOR flash will be implemented.

So what remains here is two somewhat unrelated cleanup patches, and the
meat in #3 which removes the functionality that interoperates with the
FdtPlatformDxe that we are trying to get rid of.

Ard Biesheuvel (3):
  ArmPlatformPkg/ArmVExpressDxe: remove ARM support
  ArmPlatformPkg/ArmVExpressDxe: remove unused cruft from ArmHwDxe
  ArmPlatformPkg/ArmVExpressDxe: remove FDT handling from ArmFvpDxe

 ArmPlatformPkg/ArmVExpressPkg/ArmVExpressDxe/AArch64/ArmFvpDxeAArch64.c | 113 

 ArmPlatformPkg/ArmVExpressPkg/ArmVExpressDxe/Arm/ArmFvpDxeArm.c |  84 

 ArmPlatformPkg/ArmVExpressPkg/ArmVExpressDxe/ArmFvpDxe.c| 137 
+---
 ArmPlatformPkg/ArmVExpressPkg/ArmVExpressDxe/ArmFvpDxe.inf  |  42 
--
 ArmPlatformPkg/ArmVExpressPkg/ArmVExpressDxe/ArmHwDxe.c |  43 
+-
 ArmPlatformPkg/ArmVExpressPkg/ArmVExpressDxe/ArmHwDxe.inf   |   3 -
 ArmPlatformPkg/ArmVExpressPkg/ArmVExpressDxe/ArmVExpressCommon.c|  48 
---
 ArmPlatformPkg/ArmVExpressPkg/ArmVExpressDxe/ArmVExpressInternal.h  |  99 
--
 ArmPlatformPkg/ArmVExpressPkg/ArmVExpressPkg.dec|  28 

 9 files changed, 6 insertions(+), 591 deletions(-)
 delete mode 100644 
ArmPlatformPkg/ArmVExpressPkg/ArmVExpressDxe/AArch64/ArmFvpDxeAArch64.c
 delete mode 100644 
ArmPlatformPkg/ArmVExpressPkg/ArmVExpressDxe/Arm/ArmFvpDxeArm.c
 delete mode 100644 
ArmPlatformPkg/ArmVExpressPkg/ArmVExpressDxe/ArmVExpressCommon.c
 delete mode 100644 
ArmPlatformPkg/ArmVExpressPkg/ArmVExpressDxe/ArmVExpressInternal.h

-- 
2.9.3

___
edk2-devel mailing list
edk2-devel@lists.01.org
https://lists.01.org/mailman/listinfo/edk2-devel