Re: [edk2] [Patch] MdeModulePkg: Refine the code for DxeHttpLib

[Gao, Liming]

Reviewed-by: Liming Gao <liming@intel.com>

> -Original Message-
> From: edk2-devel [mailto:edk2-devel-boun...@lists.01.org] On Behalf Of
> Jiaxin Wu
> Sent: Monday, May 16, 2016 11:47 AM
> To: edk2-devel@lists.01.org
> Cc: Ye, Ting <ting...@intel.com>; Fu, Siyuan <siyuan...@intel.com>
> Subject: [edk2] [Patch] MdeModulePkg: Refine the code for DxeHttpLib
> 
> Cc: Ye Ting <ting...@intel.com>
> Cc: Fu Siyuan <siyuan...@intel.com>
> Contributed-under: TianoCore Contribution Agreement 1.0
> Signed-off-by: Jiaxin Wu <jiaxin...@intel.com>
> ---
>  MdeModulePkg/Library/DxeHttpLib/DxeHttpLib.c | 12 +++-
>  1 file changed, 7 insertions(+), 5 deletions(-)
> 
> diff --git a/MdeModulePkg/Library/DxeHttpLib/DxeHttpLib.c
> b/MdeModulePkg/Library/DxeHttpLib/DxeHttpLib.c
> index 46f035a..727cc42 100644
> --- a/MdeModulePkg/Library/DxeHttpLib/DxeHttpLib.c
> +++ b/MdeModulePkg/Library/DxeHttpLib/DxeHttpLib.c
> @@ -1671,15 +1671,17 @@ HttpGenRequestMessage (
>EFI_HTTP_UTILITIES_PROTOCOL  *HttpUtilitiesProtocol;
> 
> 
>ASSERT (Message != NULL);
> 
> -  *RequestMsg = NULL;
> -  MsgSize = 0;
> -  Success = FALSE;
> -  HttpHdr = NULL;
> -  AppendList = NULL;
> +  *RequestMsg   = NULL;
> +  Status= EFI_SUCCESS;
> +  HttpHdrSize   = 0;
> +  MsgSize   = 0;
> +  Success   = FALSE;
> +  HttpHdr   = NULL;
> +  AppendList= NULL;
>HttpUtilitiesProtocol = NULL;
> 
>//
>// 1. If we have a Request, we cannot have a NULL Url
>// 2. If we have a Request, HeaderCount can not be non-zero
> --
> 1.9.5.msysgit.1
> 
> ___
> edk2-devel mailing list
> edk2-devel@lists.01.org
> https://lists.01.org/mailman/listinfo/edk2-devel
___
edk2-devel mailing list
edk2-devel@lists.01.org
https://lists.01.org/mailman/listinfo/edk2-devel

[edk2] [Patch] MdeModulePkg: Refine the code for DxeHttpLib

[Jiaxin Wu]

Cc: Ye Ting 
Cc: Fu Siyuan 
Contributed-under: TianoCore Contribution Agreement 1.0
Signed-off-by: Jiaxin Wu 
---
 MdeModulePkg/Library/DxeHttpLib/DxeHttpLib.c | 12 +++-
 1 file changed, 7 insertions(+), 5 deletions(-)

diff --git a/MdeModulePkg/Library/DxeHttpLib/DxeHttpLib.c 
b/MdeModulePkg/Library/DxeHttpLib/DxeHttpLib.c
index 46f035a..727cc42 100644
--- a/MdeModulePkg/Library/DxeHttpLib/DxeHttpLib.c
+++ b/MdeModulePkg/Library/DxeHttpLib/DxeHttpLib.c
@@ -1671,15 +1671,17 @@ HttpGenRequestMessage (
   EFI_HTTP_UTILITIES_PROTOCOL  *HttpUtilitiesProtocol;
 
 
   ASSERT (Message != NULL);
 
-  *RequestMsg = NULL;
-  MsgSize = 0;
-  Success = FALSE;
-  HttpHdr = NULL;
-  AppendList = NULL;
+  *RequestMsg   = NULL;
+  Status= EFI_SUCCESS;
+  HttpHdrSize   = 0;
+  MsgSize   = 0;
+  Success   = FALSE;
+  HttpHdr   = NULL;
+  AppendList= NULL;
   HttpUtilitiesProtocol = NULL;
 
   //
   // 1. If we have a Request, we cannot have a NULL Url
   // 2. If we have a Request, HeaderCount can not be non-zero
-- 
1.9.5.msysgit.1

___
edk2-devel mailing list
edk2-devel@lists.01.org
https://lists.01.org/mailman/listinfo/edk2-devel