Re: [edk2] [Patch] MdePkg BaseLib: Add the missing nasm source file InternalSwitchStack.nasm

2016-07-19 Thread Fan, Jeff 
Reviewed-by: Jeff Fan <jeff@intel.com>

-Original Message-
From: edk2-devel [mailto:edk2-devel-boun...@lists.01.org] On Behalf Of Liming 
Gao
Sent: Thursday, July 14, 2016 2:03 PM
To: edk2-devel@lists.01.org
Subject: [edk2] [Patch] MdePkg BaseLib: Add the missing nasm source file 
InternalSwitchStack.nasm

BaseLib Ia32 InternalSwitchStack.S has no matched InternalSwitchStack.nasm.
Use ObjDump to verify the output object files be same.

Contributed-under: TianoCore Contribution Agreement 1.0
Signed-off-by: Liming Gao <liming@intel.com>
---
 MdePkg/Library/BaseLib/BaseLib.inf |  3 +-
 .../Library/BaseLib/Ia32/InternalSwitchStack.nasm  | 47 ++
 2 files changed, 49 insertions(+), 1 deletion(-)  create mode 100644 
MdePkg/Library/BaseLib/Ia32/InternalSwitchStack.nasm

diff --git a/MdePkg/Library/BaseLib/BaseLib.inf 
b/MdePkg/Library/BaseLib/BaseLib.inf
index 46a8c86..1ffe870 100644
--- a/MdePkg/Library/BaseLib/BaseLib.inf
+++ b/MdePkg/Library/BaseLib/BaseLib.inf
@@ -1,7 +1,7 @@
 ## @file
 #  Base Library implementation.
 #
-#  Copyright (c) 2007 - 2015, Intel Corporation. All rights reserved.
+#  Copyright (c) 2007 - 2016, Intel Corporation. All rights 
+reserved.
 #  Portions copyright (c) 2008 - 2009, Apple Inc. All rights reserved.  #  
Portions copyright (c) 2011 - 2013, ARM Ltd. All rights reserved.  # @@ 
-410,6 +410,7 @@
   Ia32/InternalSwitchStack.c | MSFT
   Ia32/InternalSwitchStack.c | INTEL
   Ia32/InternalSwitchStack.S | GCC
+  Ia32/InternalSwitchStack.nasm | GCC
   Ia32/Non-existing.c
   Unaligned.c
   X86WriteIdtr.c
diff --git a/MdePkg/Library/BaseLib/Ia32/InternalSwitchStack.nasm 
b/MdePkg/Library/BaseLib/Ia32/InternalSwitchStack.nasm
new file mode 100644
index 000..3da341c
--- /dev/null
+++ b/MdePkg/Library/BaseLib/Ia32/InternalSwitchStack.nasm
@@ -0,0 +1,47 @@
+;--
+
+;
+; Copyright (c) 2016, Intel Corporation. All rights reserved. ; 
+Portions copyright (c) 2011, Apple Inc. All rights reserved. ; This 
+program and the accompanying materials ; are licensed and made 
+available under the terms and conditions of the BSD License ; which 
+accompanies this distribution.  The full text of the license may be 
+found at ; http://opensource.org/licenses/bsd-license.php.
+;
+; THE PROGRAM IS DISTRIBUTED UNDER THE BSD LICENSE ON AN "AS IS" BASIS, 
+; WITHOUT WARRANTIES OR REPRESENTATIONS OF ANY KIND, EITHER EXPRESS OR IMPLIED.
+;
+; Module Name:
+;
+;   InternalSwitchStack.nasm
+;
+; Abstract:
+;
+;   Implementation of a stack switch on IA-32.
+;
+;--
+
+
+SECTION .text
+
+;--
+
+; VOID
+; EFIAPI
+; InternalSwitchStack (
+;   IN  SWITCH_STACK_ENTRY_POINT  EntryPoint,
+;   IN  VOID  *Context1,   OPTIONAL
+;   IN  VOID  *Context2,   OPTIONAL
+;   IN  VOID  *NewStack
+;   );
+;--
+
+global ASM_PFX(InternalSwitchStack)
+ASM_PFX(InternalSwitchStack):
+  push  ebp
+  mov   ebp, esp
+
+  mov   esp, [ebp + 20]; switch stack
+  sub   esp, 8
+  mov   eax, [ebp + 16]
+  mov   [esp + 4], eax
+  mov   eax, [ebp + 12]
+  mov   [esp], eax
+  push  0  ; keeps gdb from unwinding stack
+  jmp   dword [ebp + 8]; call and never return
--
2.8.0.windows.1

___
edk2-devel mailing list
edk2-devel@lists.01.org
https://lists.01.org/mailman/listinfo/edk2-devel
___
edk2-devel mailing list
edk2-devel@lists.01.org
https://lists.01.org/mailman/listinfo/edk2-devel

[edk2] [Patch] MdePkg BaseLib: Add the missing nasm source file InternalSwitchStack.nasm

2016-07-14 Thread Liming Gao 
BaseLib Ia32 InternalSwitchStack.S has no matched InternalSwitchStack.nasm.
Use ObjDump to verify the output object files be same.

Contributed-under: TianoCore Contribution Agreement 1.0
Signed-off-by: Liming Gao 
---
 MdePkg/Library/BaseLib/BaseLib.inf |  3 +-
 .../Library/BaseLib/Ia32/InternalSwitchStack.nasm  | 47 ++
 2 files changed, 49 insertions(+), 1 deletion(-)
 create mode 100644 MdePkg/Library/BaseLib/Ia32/InternalSwitchStack.nasm

diff --git a/MdePkg/Library/BaseLib/BaseLib.inf 
b/MdePkg/Library/BaseLib/BaseLib.inf
index 46a8c86..1ffe870 100644
--- a/MdePkg/Library/BaseLib/BaseLib.inf
+++ b/MdePkg/Library/BaseLib/BaseLib.inf
@@ -1,7 +1,7 @@
 ## @file
 #  Base Library implementation.
 #
-#  Copyright (c) 2007 - 2015, Intel Corporation. All rights reserved.
+#  Copyright (c) 2007 - 2016, Intel Corporation. All rights reserved.
 #  Portions copyright (c) 2008 - 2009, Apple Inc. All rights reserved.
 #  Portions copyright (c) 2011 - 2013, ARM Ltd. All rights reserved.
 #
@@ -410,6 +410,7 @@
   Ia32/InternalSwitchStack.c | MSFT
   Ia32/InternalSwitchStack.c | INTEL
   Ia32/InternalSwitchStack.S | GCC
+  Ia32/InternalSwitchStack.nasm | GCC
   Ia32/Non-existing.c
   Unaligned.c
   X86WriteIdtr.c
diff --git a/MdePkg/Library/BaseLib/Ia32/InternalSwitchStack.nasm 
b/MdePkg/Library/BaseLib/Ia32/InternalSwitchStack.nasm
new file mode 100644
index 000..3da341c
--- /dev/null
+++ b/MdePkg/Library/BaseLib/Ia32/InternalSwitchStack.nasm
@@ -0,0 +1,47 @@
+;--
+;
+; Copyright (c) 2016, Intel Corporation. All rights reserved.
+; Portions copyright (c) 2011, Apple Inc. All rights reserved.
+; This program and the accompanying materials
+; are licensed and made available under the terms and conditions of the BSD 
License
+; which accompanies this distribution.  The full text of the license may be 
found at
+; http://opensource.org/licenses/bsd-license.php.
+;
+; THE PROGRAM IS DISTRIBUTED UNDER THE BSD LICENSE ON AN "AS IS" BASIS,
+; WITHOUT WARRANTIES OR REPRESENTATIONS OF ANY KIND, EITHER EXPRESS OR IMPLIED.
+;
+; Module Name:
+;
+;   InternalSwitchStack.nasm
+;
+; Abstract:
+;
+;   Implementation of a stack switch on IA-32.
+;
+;--
+
+SECTION .text
+
+;--
+; VOID
+; EFIAPI
+; InternalSwitchStack (
+;   IN  SWITCH_STACK_ENTRY_POINT  EntryPoint,
+;   IN  VOID  *Context1,   OPTIONAL
+;   IN  VOID  *Context2,   OPTIONAL
+;   IN  VOID  *NewStack
+;   );
+;--
+global ASM_PFX(InternalSwitchStack)
+ASM_PFX(InternalSwitchStack):
+  push  ebp
+  mov   ebp, esp
+
+  mov   esp, [ebp + 20]; switch stack
+  sub   esp, 8
+  mov   eax, [ebp + 16]
+  mov   [esp + 4], eax
+  mov   eax, [ebp + 12]
+  mov   [esp], eax
+  push  0  ; keeps gdb from unwinding stack
+  jmp   dword [ebp + 8]; call and never return
-- 
2.8.0.windows.1

___
edk2-devel mailing list
edk2-devel@lists.01.org
https://lists.01.org/mailman/listinfo/edk2-devel