Re: [edk2] [Patch] NetworkPkg/IScsiDxe: Clear the old IFR TargetIp to avoid sharing it with other attempts.
Reviewed-by: Fu Siyuan > -Original Message- > From: Wu, Jiaxin > Sent: Thursday, October 26, 2017 4:27 PM > To: edk2-devel@lists.01.org > Cc: Karunakar P ; Ye, Ting ; > Fu, Siyuan ; Wu, Jiaxin > Subject: [Patch] NetworkPkg/IScsiDxe: Clear the old IFR TargetIp to avoid > sharing it with other attempts. > > Cc: Karunakar P > Cc: Ye Ting > Cc: Fu Siyuan > Contributed-under: TianoCore Contribution Agreement 1.0 > Signed-off-by: Wu Jiaxin > --- > NetworkPkg/IScsiDxe/IScsiConfig.c | 1 + > 1 file changed, 1 insertion(+) > > diff --git a/NetworkPkg/IScsiDxe/IScsiConfig.c > b/NetworkPkg/IScsiDxe/IScsiConfig.c > index 3ce37c5..3382982 100644 > --- a/NetworkPkg/IScsiDxe/IScsiConfig.c > +++ b/NetworkPkg/IScsiDxe/IScsiConfig.c > @@ -539,10 +539,11 @@ IScsiConvertAttemptConfigDataToIfrNvData ( > IScsiIpToStr (&Ip, FALSE, IfrNvData->LocalIp); > CopyMem (&Ip.v4, &SessionConfigData->SubnetMask, sizeof > (EFI_IPv4_ADDRESS)); > IScsiIpToStr (&Ip, FALSE, IfrNvData->SubnetMask); > CopyMem (&Ip.v4, &SessionConfigData->Gateway, sizeof > (EFI_IPv4_ADDRESS)); > IScsiIpToStr (&Ip, FALSE, IfrNvData->Gateway); > +ZeroMem (IfrNvData->TargetIp, sizeof (IfrNvData->TargetIp)); > if (SessionConfigData->TargetIp.v4.Addr[0] != '\0') { >CopyMem (&Ip.v4, &SessionConfigData->TargetIp, sizeof > (EFI_IPv4_ADDRESS)); >IScsiIpToStr (&Ip, FALSE, IfrNvData->TargetIp); > } > > -- > 1.9.5.msysgit.1 ___ edk2-devel mailing list edk2-devel@lists.01.org https://lists.01.org/mailman/listinfo/edk2-devel
Re: [edk2] [Patch] NetworkPkg/IScsiDxe: Clear the old IFR TargetIp to avoid sharing it with other attempts.
Hi Jiaxin, It can resolve the issue. Thanks, Karunakar -Original Message- From: Jiaxin Wu [mailto:jiaxin...@intel.com] Sent: Thursday, October 26, 2017 1:57 PM To: edk2-devel@lists.01.org Cc: Karunakar P; Ye Ting; Fu Siyuan; Wu Jiaxin Subject: [Patch] NetworkPkg/IScsiDxe: Clear the old IFR TargetIp to avoid sharing it with other attempts. Cc: Karunakar P Cc: Ye Ting Cc: Fu Siyuan Contributed-under: TianoCore Contribution Agreement 1.0 Signed-off-by: Wu Jiaxin --- NetworkPkg/IScsiDxe/IScsiConfig.c | 1 + 1 file changed, 1 insertion(+) diff --git a/NetworkPkg/IScsiDxe/IScsiConfig.c b/NetworkPkg/IScsiDxe/IScsiConfig.c index 3ce37c5..3382982 100644 --- a/NetworkPkg/IScsiDxe/IScsiConfig.c +++ b/NetworkPkg/IScsiDxe/IScsiConfig.c @@ -539,10 +539,11 @@ IScsiConvertAttemptConfigDataToIfrNvData ( IScsiIpToStr (&Ip, FALSE, IfrNvData->LocalIp); CopyMem (&Ip.v4, &SessionConfigData->SubnetMask, sizeof (EFI_IPv4_ADDRESS)); IScsiIpToStr (&Ip, FALSE, IfrNvData->SubnetMask); CopyMem (&Ip.v4, &SessionConfigData->Gateway, sizeof (EFI_IPv4_ADDRESS)); IScsiIpToStr (&Ip, FALSE, IfrNvData->Gateway); +ZeroMem (IfrNvData->TargetIp, sizeof (IfrNvData->TargetIp)); if (SessionConfigData->TargetIp.v4.Addr[0] != '\0') { CopyMem (&Ip.v4, &SessionConfigData->TargetIp, sizeof (EFI_IPv4_ADDRESS)); IScsiIpToStr (&Ip, FALSE, IfrNvData->TargetIp); } -- 1.9.5.msysgit.1 ___ edk2-devel mailing list edk2-devel@lists.01.org https://lists.01.org/mailman/listinfo/edk2-devel
[edk2] [Patch] NetworkPkg/IScsiDxe: Clear the old IFR TargetIp to avoid sharing it with other attempts.
Cc: Karunakar P Cc: Ye Ting Cc: Fu Siyuan Contributed-under: TianoCore Contribution Agreement 1.0 Signed-off-by: Wu Jiaxin --- NetworkPkg/IScsiDxe/IScsiConfig.c | 1 + 1 file changed, 1 insertion(+) diff --git a/NetworkPkg/IScsiDxe/IScsiConfig.c b/NetworkPkg/IScsiDxe/IScsiConfig.c index 3ce37c5..3382982 100644 --- a/NetworkPkg/IScsiDxe/IScsiConfig.c +++ b/NetworkPkg/IScsiDxe/IScsiConfig.c @@ -539,10 +539,11 @@ IScsiConvertAttemptConfigDataToIfrNvData ( IScsiIpToStr (&Ip, FALSE, IfrNvData->LocalIp); CopyMem (&Ip.v4, &SessionConfigData->SubnetMask, sizeof (EFI_IPv4_ADDRESS)); IScsiIpToStr (&Ip, FALSE, IfrNvData->SubnetMask); CopyMem (&Ip.v4, &SessionConfigData->Gateway, sizeof (EFI_IPv4_ADDRESS)); IScsiIpToStr (&Ip, FALSE, IfrNvData->Gateway); +ZeroMem (IfrNvData->TargetIp, sizeof (IfrNvData->TargetIp)); if (SessionConfigData->TargetIp.v4.Addr[0] != '\0') { CopyMem (&Ip.v4, &SessionConfigData->TargetIp, sizeof (EFI_IPv4_ADDRESS)); IScsiIpToStr (&Ip, FALSE, IfrNvData->TargetIp); } -- 1.9.5.msysgit.1 ___ edk2-devel mailing list edk2-devel@lists.01.org https://lists.01.org/mailman/listinfo/edk2-devel