Re: [edk2] [Patch] NetworkPkg: fix function comments in HttpBootDxe.

[Bruce Cran]

On 3/10/16 7:49 PM, Zhang, Lubo wrote:

Reviewed-by: Zhang, Lubo 

-Original Message-
From: Fu, Siyuan
Sent: Thursday, March 10, 2016 10:10 AM
To: edk2-devel@lists.01.org
Cc: Wu, Jiaxin ; Zhang, Lubo 
Subject: [Patch] NetworkPkg: fix function comments in HttpBootDxe.

Contributed-under: TianoCore Contribution Agreement 1.0
Signed-off-by: Fu Siyuan 
Cc: Wu Jiaxin 
Cc: Zhang Lubo 


It looks like your git configuration might be wrong: instead of your 
email address you seem to have some Exchange information in the changeset.


Authored:
Zhang, Lubo 
Tue, Mar 8, 11:20 PM
Committed:
Jiaxin Wu    Thu, Mar 10, 8:55 PM

--
Bruce
___
edk2-devel mailing list
edk2-devel@lists.01.org
https://lists.01.org/mailman/listinfo/edk2-devel

Re: [edk2] [Patch] NetworkPkg: fix function comments in HttpBootDxe.

[Wu, Jiaxin]

Reviewed-by: Jiaxin Wu 


> -Original Message-
> From: Fu, Siyuan
> Sent: Thursday, March 10, 2016 10:10 AM
> To: edk2-devel@lists.01.org
> Cc: Wu, Jiaxin ; Zhang, Lubo 
> Subject: [Patch] NetworkPkg: fix function comments in HttpBootDxe.
> 
> Contributed-under: TianoCore Contribution Agreement 1.0
> Signed-off-by: Fu Siyuan 
> Cc: Wu Jiaxin 
> Cc: Zhang Lubo 
> ---
>  NetworkPkg/HttpBootDxe/HttpBootDxe.inf   | 2 ++
>  NetworkPkg/HttpBootDxe/HttpBootSupport.c | 2 +-
> NetworkPkg/HttpBootDxe/HttpBootSupport.h | 2 +-
>  3 files changed, 4 insertions(+), 2 deletions(-)
> 
> diff --git a/NetworkPkg/HttpBootDxe/HttpBootDxe.inf
> b/NetworkPkg/HttpBootDxe/HttpBootDxe.inf
> index 8b4219c..7393ecd 100644
> --- a/NetworkPkg/HttpBootDxe/HttpBootDxe.inf
> +++ b/NetworkPkg/HttpBootDxe/HttpBootDxe.inf
> @@ -28,8 +28,10 @@
>NetworkPkg/NetworkPkg.dec
> 
>  [Sources]
> +  HttpBootConfigNVDataStruc.h
>HttpBootDxe.h
>HttpBootDxe.c
> +  HttpBootConfig.h
>HttpBootConfig.c
>HttpBootComponentName.h
>HttpBootComponentName.c
> diff --git a/NetworkPkg/HttpBootDxe/HttpBootSupport.c
> b/NetworkPkg/HttpBootDxe/HttpBootSupport.c
> index e678379..758c49b 100644
> --- a/NetworkPkg/HttpBootDxe/HttpBootSupport.c
> +++ b/NetworkPkg/HttpBootDxe/HttpBootSupport.c
> @@ -951,7 +951,7 @@ HttpIoRecvResponse (
>Caller need to free the buffer in the UriAddress pointer.
> 
>@param[in]   FilePath Pointer to the device path which contains a 
> URI
> device path node.
> -  @param[in]   UriAddress   The URI address string extract from the 
> device
> path.
> +  @param[out]  UriAddress   The URI address string extract from the
> device path.
> 
>@retval EFI_SUCCESSThe URI string is returned.
>@retval EFI_OUT_OF_RESOURCES   Failed to allocate memory.
> diff --git a/NetworkPkg/HttpBootDxe/HttpBootSupport.h
> b/NetworkPkg/HttpBootDxe/HttpBootSupport.h
> index 3edea61..f382d63 100644
> --- a/NetworkPkg/HttpBootDxe/HttpBootSupport.h
> +++ b/NetworkPkg/HttpBootDxe/HttpBootSupport.h
> @@ -335,7 +335,7 @@ HttpIoRecvResponse (
>Caller need to free the buffer in the UriAddress pointer.
> 
>@param[in]   FilePath Pointer to the device path which contains a 
> URI
> device path node.
> -  @param[in]   UriAddress   The URI address string extract from the 
> device
> path.
> +  @param[out]  UriAddress   The URI address string extract from the
> device path.
> 
>@retval EFI_SUCCESSThe URI string is returned.
>@retval EFI_OUT_OF_RESOURCES   Failed to allocate memory.
> --
> 2.7.0.windows.2

___
edk2-devel mailing list
edk2-devel@lists.01.org
https://lists.01.org/mailman/listinfo/edk2-devel

Re: [edk2] [Patch] NetworkPkg: fix function comments in HttpBootDxe.

[Zhang, Lubo]

Reviewed-by: Zhang, Lubo 

-Original Message-
From: Fu, Siyuan 
Sent: Thursday, March 10, 2016 10:10 AM
To: edk2-devel@lists.01.org
Cc: Wu, Jiaxin ; Zhang, Lubo 
Subject: [Patch] NetworkPkg: fix function comments in HttpBootDxe.

Contributed-under: TianoCore Contribution Agreement 1.0
Signed-off-by: Fu Siyuan 
Cc: Wu Jiaxin 
Cc: Zhang Lubo 
---
 NetworkPkg/HttpBootDxe/HttpBootDxe.inf   | 2 ++
 NetworkPkg/HttpBootDxe/HttpBootSupport.c | 2 +-  
NetworkPkg/HttpBootDxe/HttpBootSupport.h | 2 +-
 3 files changed, 4 insertions(+), 2 deletions(-)

diff --git a/NetworkPkg/HttpBootDxe/HttpBootDxe.inf 
b/NetworkPkg/HttpBootDxe/HttpBootDxe.inf
index 8b4219c..7393ecd 100644
--- a/NetworkPkg/HttpBootDxe/HttpBootDxe.inf
+++ b/NetworkPkg/HttpBootDxe/HttpBootDxe.inf
@@ -28,8 +28,10 @@
   NetworkPkg/NetworkPkg.dec
 
 [Sources]
+  HttpBootConfigNVDataStruc.h
   HttpBootDxe.h
   HttpBootDxe.c
+  HttpBootConfig.h
   HttpBootConfig.c
   HttpBootComponentName.h
   HttpBootComponentName.c
diff --git a/NetworkPkg/HttpBootDxe/HttpBootSupport.c 
b/NetworkPkg/HttpBootDxe/HttpBootSupport.c
index e678379..758c49b 100644
--- a/NetworkPkg/HttpBootDxe/HttpBootSupport.c
+++ b/NetworkPkg/HttpBootDxe/HttpBootSupport.c
@@ -951,7 +951,7 @@ HttpIoRecvResponse (
   Caller need to free the buffer in the UriAddress pointer.
   
   @param[in]   FilePath Pointer to the device path which contains a 
URI device path node.
-  @param[in]   UriAddress   The URI address string extract from the device 
path.
+  @param[out]  UriAddress   The URI address string extract from the device 
path.
   
   @retval EFI_SUCCESSThe URI string is returned.
   @retval EFI_OUT_OF_RESOURCES   Failed to allocate memory.
diff --git a/NetworkPkg/HttpBootDxe/HttpBootSupport.h 
b/NetworkPkg/HttpBootDxe/HttpBootSupport.h
index 3edea61..f382d63 100644
--- a/NetworkPkg/HttpBootDxe/HttpBootSupport.h
+++ b/NetworkPkg/HttpBootDxe/HttpBootSupport.h
@@ -335,7 +335,7 @@ HttpIoRecvResponse (
   Caller need to free the buffer in the UriAddress pointer.
   
   @param[in]   FilePath Pointer to the device path which contains a 
URI device path node.
-  @param[in]   UriAddress   The URI address string extract from the device 
path.
+  @param[out]  UriAddress   The URI address string extract from the device 
path.
   
   @retval EFI_SUCCESSThe URI string is returned.
   @retval EFI_OUT_OF_RESOURCES   Failed to allocate memory.
--
2.7.0.windows.2

___
edk2-devel mailing list
edk2-devel@lists.01.org
https://lists.01.org/mailman/listinfo/edk2-devel