Re: [edk2] [Patch] SecurityPkg: Cleanup unused structure definition

[Fu, Siyuan]

Reviewed-by: Fu Siyuan 


> -Original Message-
> From: Wu, Jiaxin
> Sent: Friday, May 6, 2016 2:20 PM
> To: edk2-devel@lists.01.org
> Cc: Zhang, Chao B ; Ye, Ting ;
> Fu, Siyuan 
> Subject: [Patch] SecurityPkg: Cleanup unused structure definition
> 
> This patch is used to cleanup unused structure definition.
> 
> Cc: Zhang Chao B 
> Cc: Ye Ting 
> Cc: Fu Siyuan 
> Contributed-under: TianoCore Contribution Agreement 1.0
> Signed-off-by: Jiaxin Wu 
> ---
>  .../SecureBootConfigDxe/SecureBootConfigImpl.h | 37 
> --
>  1 file changed, 37 deletions(-)
> 
> diff --git
> a/SecurityPkg/VariableAuthenticated/SecureBootConfigDxe/SecureBootConfi
> gImpl.h
> b/SecurityPkg/VariableAuthenticated/SecureBootConfigDxe/SecureBootConf
> igImpl.h
> index 1ee9580..0a09ab4 100644
> ---
> a/SecurityPkg/VariableAuthenticated/SecureBootConfigDxe/SecureBootConfi
> gImpl.h
> +++
> b/SecurityPkg/VariableAuthenticated/SecureBootConfigDxe/SecureBootConf
> igImpl.h
> @@ -100,47 +100,10 @@ extern  EFI_IFR_GUID_LABEL *mEndLabel;
>  #define HASHALG_SHA512 0x0004
>  #define HASHALG_RAW0x0005
>  #define HASHALG_MAX0x0005
> 
> 
> -#define SECUREBOOT_MENU_OPTION_SIGNATURE   SIGNATURE_32 ('S', 'b',
> 'M', 'u')
> -#define SECUREBOOT_MENU_ENTRY_SIGNATURESIGNATURE_32 ('S', 'b',
> 'M', 'r')
> -
> -typedef struct {
> -  EFI_DEVICE_PATH_PROTOCOL  Header;
> -  EFI_GUID  Guid;
> -  UINT8 VendorDefinedData[1];
> -} VENDOR_DEVICE_PATH_WITH_DATA;
> -
> -typedef struct {
> -  EFI_DEVICE_PATH_PROTOCOL  Header;
> -  UINT16NetworkProtocol;
> -  UINT16LoginOption;
> -  UINT64Lun;
> -  UINT16TargetPortalGroupTag;
> -  CHAR16TargetName[1];
> -} ISCSI_DEVICE_PATH_WITH_NAME;
> -
> -typedef struct {
> -  CHAR16  *Str;
> -  UINTN   Len;
> -  UINTN   Maxlen;
> -} POOL_PRINT;
> -
> -typedef
> -VOID
> -(*DEV_PATH_FUNCTION) (
> -  IN OUT POOL_PRINT   *Str,
> -  IN VOID *DevPath
> -  );
> -
> -typedef struct {
> -  UINT8 Type;
> -  UINT8 SubType;
> -  DEV_PATH_FUNCTION Function;
> -} DEVICE_PATH_STRING_TABLE;
> -
>  typedef struct {
>UINTN Signature;
>LIST_ENTRYHead;
>UINTN MenuNumber;
>  } SECUREBOOT_MENU_OPTION;
> --
> 1.9.5.msysgit.1

___
edk2-devel mailing list
edk2-devel@lists.01.org
https://lists.01.org/mailman/listinfo/edk2-devel

Re: [edk2] [Patch] SecurityPkg: Cleanup unused structure definition

[Zhang, Chao B]

Reviewed-by: Chao Zhang 





Thanks & Best regards
Chao Zhang


-Original Message-
From: Wu, Jiaxin 
Sent: Friday, May 06, 2016 2:20 PM
To: edk2-devel@lists.01.org
Cc: Zhang, Chao B; Ye, Ting; Fu, Siyuan
Subject: [Patch] SecurityPkg: Cleanup unused structure definition

This patch is used to cleanup unused structure definition.

Cc: Zhang Chao B 
Cc: Ye Ting 
Cc: Fu Siyuan 
Contributed-under: TianoCore Contribution Agreement 1.0
Signed-off-by: Jiaxin Wu 
---
 .../SecureBootConfigDxe/SecureBootConfigImpl.h | 37 --
 1 file changed, 37 deletions(-)

diff --git 
a/SecurityPkg/VariableAuthenticated/SecureBootConfigDxe/SecureBootConfigImpl.h 
b/SecurityPkg/VariableAuthenticated/SecureBootConfigDxe/SecureBootConfigImpl.h
index 1ee9580..0a09ab4 100644
--- 
a/SecurityPkg/VariableAuthenticated/SecureBootConfigDxe/SecureBootConfigImpl.h
+++ 
b/SecurityPkg/VariableAuthenticated/SecureBootConfigDxe/SecureBootConfigImpl.h
@@ -100,47 +100,10 @@ extern  EFI_IFR_GUID_LABEL *mEndLabel;
 #define HASHALG_SHA512 0x0004
 #define HASHALG_RAW0x0005
 #define HASHALG_MAX0x0005
 
 
-#define SECUREBOOT_MENU_OPTION_SIGNATURE   SIGNATURE_32 ('S', 'b', 'M', 'u')
-#define SECUREBOOT_MENU_ENTRY_SIGNATURESIGNATURE_32 ('S', 'b', 'M', 'r')
-
-typedef struct {
-  EFI_DEVICE_PATH_PROTOCOL  Header;
-  EFI_GUID  Guid;
-  UINT8 VendorDefinedData[1];
-} VENDOR_DEVICE_PATH_WITH_DATA;
-
-typedef struct {
-  EFI_DEVICE_PATH_PROTOCOL  Header;
-  UINT16NetworkProtocol;
-  UINT16LoginOption;
-  UINT64Lun;
-  UINT16TargetPortalGroupTag;
-  CHAR16TargetName[1];
-} ISCSI_DEVICE_PATH_WITH_NAME;
-
-typedef struct {
-  CHAR16  *Str;
-  UINTN   Len;
-  UINTN   Maxlen;
-} POOL_PRINT;
-
-typedef
-VOID
-(*DEV_PATH_FUNCTION) (
-  IN OUT POOL_PRINT   *Str,
-  IN VOID *DevPath
-  );
-
-typedef struct {
-  UINT8 Type;
-  UINT8 SubType;
-  DEV_PATH_FUNCTION Function;
-} DEVICE_PATH_STRING_TABLE;
-
 typedef struct {
   UINTN Signature;
   LIST_ENTRYHead;
   UINTN MenuNumber;
 } SECUREBOOT_MENU_OPTION;
-- 
1.9.5.msysgit.1

___
edk2-devel mailing list
edk2-devel@lists.01.org
https://lists.01.org/mailman/listinfo/edk2-devel

[edk2] [Patch] SecurityPkg: Cleanup unused structure definition

[Jiaxin Wu]

This patch is used to cleanup unused structure definition.

Cc: Zhang Chao B 
Cc: Ye Ting 
Cc: Fu Siyuan 
Contributed-under: TianoCore Contribution Agreement 1.0
Signed-off-by: Jiaxin Wu 
---
 .../SecureBootConfigDxe/SecureBootConfigImpl.h | 37 --
 1 file changed, 37 deletions(-)

diff --git 
a/SecurityPkg/VariableAuthenticated/SecureBootConfigDxe/SecureBootConfigImpl.h 
b/SecurityPkg/VariableAuthenticated/SecureBootConfigDxe/SecureBootConfigImpl.h
index 1ee9580..0a09ab4 100644
--- 
a/SecurityPkg/VariableAuthenticated/SecureBootConfigDxe/SecureBootConfigImpl.h
+++ 
b/SecurityPkg/VariableAuthenticated/SecureBootConfigDxe/SecureBootConfigImpl.h
@@ -100,47 +100,10 @@ extern  EFI_IFR_GUID_LABEL *mEndLabel;
 #define HASHALG_SHA512 0x0004
 #define HASHALG_RAW0x0005
 #define HASHALG_MAX0x0005
 
 
-#define SECUREBOOT_MENU_OPTION_SIGNATURE   SIGNATURE_32 ('S', 'b', 'M', 'u')
-#define SECUREBOOT_MENU_ENTRY_SIGNATURESIGNATURE_32 ('S', 'b', 'M', 'r')
-
-typedef struct {
-  EFI_DEVICE_PATH_PROTOCOL  Header;
-  EFI_GUID  Guid;
-  UINT8 VendorDefinedData[1];
-} VENDOR_DEVICE_PATH_WITH_DATA;
-
-typedef struct {
-  EFI_DEVICE_PATH_PROTOCOL  Header;
-  UINT16NetworkProtocol;
-  UINT16LoginOption;
-  UINT64Lun;
-  UINT16TargetPortalGroupTag;
-  CHAR16TargetName[1];
-} ISCSI_DEVICE_PATH_WITH_NAME;
-
-typedef struct {
-  CHAR16  *Str;
-  UINTN   Len;
-  UINTN   Maxlen;
-} POOL_PRINT;
-
-typedef
-VOID
-(*DEV_PATH_FUNCTION) (
-  IN OUT POOL_PRINT   *Str,
-  IN VOID *DevPath
-  );
-
-typedef struct {
-  UINT8 Type;
-  UINT8 SubType;
-  DEV_PATH_FUNCTION Function;
-} DEVICE_PATH_STRING_TABLE;
-
 typedef struct {
   UINTN Signature;
   LIST_ENTRYHead;
   UINTN MenuNumber;
 } SECUREBOOT_MENU_OPTION;
-- 
1.9.5.msysgit.1

___
edk2-devel mailing list
edk2-devel@lists.01.org
https://lists.01.org/mailman/listinfo/edk2-devel