Re: [edk2] [Patch 0/3] BaseTools: Implement splitquoted function
On 02/15/19 15:35, Gao, Liming wrote: > Laszlo: > I have updated wiki page to mention python3-distutils. Thanks! > I suggest to update BaseTools\ReadMe.txt for it. Ah, haha, there's such a file as "BaseTools/ReadMe.txt"? :) I don't think I've ever noticed it. :) But, now I agree that "BaseTools/ReadMe.txt" is a better place for exposing this dependency. Thanks! Laszlo > > Thanks > Liming >> -Original Message- >> From: Laszlo Ersek [mailto:ler...@redhat.com] >> Sent: Thursday, February 14, 2019 11:35 PM >> To: Gao, Liming ; Feng, Bob C ; >> Bi, Dandan ; Carsey, Jaben >> >> Cc: edk2-devel@lists.01.org >> Subject: Re: [edk2] [Patch 0/3] BaseTools: Implement splitquoted function >> >> On 02/14/19 04:23, Gao, Liming wrote: >>> Bob: >>> So, this is OS issue. I prefer to update wiki page to describe how to >>> resolve it. >> >> Great idea. I think this is probably the affected section: >> >> https://github.com/tianocore/tianocore.github.io/wiki/Using-EDK-II-with-Native-GCC#Install_required_software_from_apt >> >> We should simply add "python3-distutils" to the list. >> >> Possibly, also mention "python3-distutils" in >> "BaseTools/Conf/tools_def.template". >> >> Thanks >> Laszlo ___ edk2-devel mailing list edk2-devel@lists.01.org https://lists.01.org/mailman/listinfo/edk2-devel
Re: [edk2] [Patch 0/3] BaseTools: Implement splitquoted function
Laszlo: I have updated wiki page to mention python3-distutils. I suggest to update BaseTools\ReadMe.txt for it. Thanks Liming > -Original Message- > From: Laszlo Ersek [mailto:ler...@redhat.com] > Sent: Thursday, February 14, 2019 11:35 PM > To: Gao, Liming ; Feng, Bob C ; > Bi, Dandan ; Carsey, Jaben > > Cc: edk2-devel@lists.01.org > Subject: Re: [edk2] [Patch 0/3] BaseTools: Implement splitquoted function > > On 02/14/19 04:23, Gao, Liming wrote: > > Bob: > > So, this is OS issue. I prefer to update wiki page to describe how to > > resolve it. > > Great idea. I think this is probably the affected section: > > https://github.com/tianocore/tianocore.github.io/wiki/Using-EDK-II-with-Native-GCC#Install_required_software_from_apt > > We should simply add "python3-distutils" to the list. > > Possibly, also mention "python3-distutils" in > "BaseTools/Conf/tools_def.template". > > Thanks > Laszlo ___ edk2-devel mailing list edk2-devel@lists.01.org https://lists.01.org/mailman/listinfo/edk2-devel
Re: [edk2] [Patch 0/3] BaseTools: Implement splitquoted function
Hi Laszlo, Thanks for you detailed clarification. This patch will not be pushed to edk2 master and Ubuntu user need to install python3-distutils package via "sudo apt-get install python3-distutils" to resolve this issue. Thanks, Bob -Original Message- From: Laszlo Ersek [mailto:ler...@redhat.com] Sent: Thursday, February 14, 2019 11:32 PM To: Feng, Bob C Cc: Gao, Liming ; Bi, Dandan ; Carsey, Jaben ; edk2-devel@lists.01.org Subject: Re: [edk2] [Patch 0/3] BaseTools: Implement splitquoted function Hi Bob, On 02/14/19 03:51, Feng, Bob C wrote: > Hi Laszlo, Liming, Jaben and Dandan, > > I found this is a Ubuntu18 bug. Refer to > https://bugs.launchpad.net/ubuntu/+source/fdroidserver/+bug/1762183 That Ubuntu bug is *related*, but it's not a bug that matters for us. The bug above is about another package; it is called "fdroidserver". The "fdroidserver" package has a hard runtime dependency on the python "distutils.util" module. Package management systems on Linux distributions track inter-package dependencies. That is, if the meta-data on the "fdroidserver" package explicitly lists the "python3-distutils" package as a dependency, then the package management system will automatically install in "python3-distutils" when the user requests "fdroidserver". However, if the meta-data on the "fdroidserver" package are incorrect (buggy), then the package management system will have no clue. And, if the "python3-distutils" package is not already installed for some other reason, then the user will get an installation or runtime error, when they try to install or run "fdroidserver". So, to be clear, the bug report you reference describes a *similar* situation to ours (a missing dependency), but it's not the same case. The bug you refer to is in the "fdroidserver" package, and they fixed it in Ubuntu by updating / correcting the meta-data on the "fdroidserver" package. The "python3-distutils" package, or other parts of the OS, were not touched. > And Ubuntu fixed this bug via a Ubuntu18.04.1 update package which was > published on 2018-08-09. Refer to > https://launchpad.net/ubuntu/+source/fdroidserver/1.0.9-1~18.04.1 The link you provide confirms what I wrote above. It is a changelog for the "fdroidserver" package, and the relevant entry says "fix missing Python distutils dependency". > While the latest Ubuntu 18.04 release > (ubuntu-18.04.1-desktop-amd64.iso) on > http://releases.ubuntu.com/18.04/ was published on 2018-07-25. So > there is no distutils.util library on Ubuntu18.04 default > installation. No, this statement can't be correct. I'm pretty sure that the "python3-distutils" package *was* available when Ubuntu 18.04 -- not 18.04.1 -- was originally released. I've just downloaded http://old-releases.ubuntu.com/releases/bionic/ubuntu-18.04-desktop-amd64.iso While the package is not on the ISO, a whole lot of *other* packages are also not there -- for example I can't see any python at all. So I'm thinking that python3-distutils was only available from the network. But, I'm pretty sure python3-distutils *was* available from the network, when 18.04 was originally released. What was indeed broken in the original Ubuntu 18.04 release was the meta-data on the "fdroidserver" package. > But I think it's clear that distutils.util is not *3rd party* python > library. I agree; and that is what matters. > I have tried that the command "sudo apt upgrade" can't fix this bug This "apt" command would only be relevant if you had the *old* fdroidserver package installed (with the missing dependency in its meta-data). Then, "apt" would install the *new* fdroidserver package for you, and it would also act on the now-visible "python3-distutils" dependency. Thus, "apt" would automatically install in python3-distutils, as a dependency. For installing "python3-distutils" *in itself*, the above "apt" command is totally useless. > while the command "sudo apt-get install python3-distutils" works. Yes, it does, because here you are specifically requesting the python3-distutils package. And that's what matters. Ubuntu users simply need to install python3-distutils manually, from their official package repositories, if they want to use BaseTools (as part of the upstream edk2 git repo). So I think this edk2 patch set is not necessary, after all. Thanks, Laszlo ___ edk2-devel mailing list edk2-devel@lists.01.org https://lists.01.org/mailman/listinfo/edk2-devel
Re: [edk2] [Patch 0/3] BaseTools: Implement splitquoted function
On 02/14/19 04:23, Gao, Liming wrote: > Bob: > So, this is OS issue. I prefer to update wiki page to describe how to > resolve it. Great idea. I think this is probably the affected section: https://github.com/tianocore/tianocore.github.io/wiki/Using-EDK-II-with-Native-GCC#Install_required_software_from_apt We should simply add "python3-distutils" to the list. Possibly, also mention "python3-distutils" in "BaseTools/Conf/tools_def.template". Thanks Laszlo ___ edk2-devel mailing list edk2-devel@lists.01.org https://lists.01.org/mailman/listinfo/edk2-devel
Re: [edk2] [Patch 0/3] BaseTools: Implement splitquoted function
Hi Bob, On 02/14/19 03:51, Feng, Bob C wrote: > Hi Laszlo, Liming, Jaben and Dandan, > > I found this is a Ubuntu18 bug. Refer to > https://bugs.launchpad.net/ubuntu/+source/fdroidserver/+bug/1762183 That Ubuntu bug is *related*, but it's not a bug that matters for us. The bug above is about another package; it is called "fdroidserver". The "fdroidserver" package has a hard runtime dependency on the python "distutils.util" module. Package management systems on Linux distributions track inter-package dependencies. That is, if the meta-data on the "fdroidserver" package explicitly lists the "python3-distutils" package as a dependency, then the package management system will automatically install in "python3-distutils" when the user requests "fdroidserver". However, if the meta-data on the "fdroidserver" package are incorrect (buggy), then the package management system will have no clue. And, if the "python3-distutils" package is not already installed for some other reason, then the user will get an installation or runtime error, when they try to install or run "fdroidserver". So, to be clear, the bug report you reference describes a *similar* situation to ours (a missing dependency), but it's not the same case. The bug you refer to is in the "fdroidserver" package, and they fixed it in Ubuntu by updating / correcting the meta-data on the "fdroidserver" package. The "python3-distutils" package, or other parts of the OS, were not touched. > And Ubuntu fixed this bug via a Ubuntu18.04.1 update package which was > published on 2018-08-09. Refer to > https://launchpad.net/ubuntu/+source/fdroidserver/1.0.9-1~18.04.1 The link you provide confirms what I wrote above. It is a changelog for the "fdroidserver" package, and the relevant entry says "fix missing Python distutils dependency". > While the latest Ubuntu 18.04 release > (ubuntu-18.04.1-desktop-amd64.iso) on > http://releases.ubuntu.com/18.04/ was published on 2018-07-25. So > there is no distutils.util library on Ubuntu18.04 default > installation. No, this statement can't be correct. I'm pretty sure that the "python3-distutils" package *was* available when Ubuntu 18.04 -- not 18.04.1 -- was originally released. I've just downloaded http://old-releases.ubuntu.com/releases/bionic/ubuntu-18.04-desktop-amd64.iso While the package is not on the ISO, a whole lot of *other* packages are also not there -- for example I can't see any python at all. So I'm thinking that python3-distutils was only available from the network. But, I'm pretty sure python3-distutils *was* available from the network, when 18.04 was originally released. What was indeed broken in the original Ubuntu 18.04 release was the meta-data on the "fdroidserver" package. > But I think it's clear that distutils.util is not *3rd party* python > library. I agree; and that is what matters. > I have tried that the command "sudo apt upgrade" can't fix this bug This "apt" command would only be relevant if you had the *old* fdroidserver package installed (with the missing dependency in its meta-data). Then, "apt" would install the *new* fdroidserver package for you, and it would also act on the now-visible "python3-distutils" dependency. Thus, "apt" would automatically install in python3-distutils, as a dependency. For installing "python3-distutils" *in itself*, the above "apt" command is totally useless. > while the command "sudo apt-get install python3-distutils" works. Yes, it does, because here you are specifically requesting the python3-distutils package. And that's what matters. Ubuntu users simply need to install python3-distutils manually, from their official package repositories, if they want to use BaseTools (as part of the upstream edk2 git repo). So I think this edk2 patch set is not necessary, after all. Thanks, Laszlo ___ edk2-devel mailing list edk2-devel@lists.01.org https://lists.01.org/mailman/listinfo/edk2-devel
Re: [edk2] [Patch 0/3] BaseTools: Implement splitquoted function
Bob: So, this is OS issue. I prefer to update wiki page to describe how to resolve it. Thanks Liming >-Original Message- >From: Feng, Bob C >Sent: Thursday, February 14, 2019 10:51 AM >To: Laszlo Ersek ; Gao, Liming ; >Bi, Dandan ; Carsey, Jaben >Cc: edk2-devel@lists.01.org >Subject: RE: [edk2] [Patch 0/3] BaseTools: Implement splitquoted function > >Hi Laszlo, Liming, Jaben and Dandan, > >I found this is a Ubuntu18 bug. Refer to >https://bugs.launchpad.net/ubuntu/+source/fdroidserver/+bug/1762183 > >And Ubuntu fixed this bug via a Ubuntu18.04.1 update package which was >published on 2018-08-09. Refer to >https://launchpad.net/ubuntu/+source/fdroidserver/1.0.9-1~18.04.1 > >While the latest Ubuntu 18.04 release (ubuntu-18.04.1-desktop-amd64.iso) >on http://releases.ubuntu.com/18.04/ was published on 2018-07-25. So there >is no distutils.util library on Ubuntu18.04 default installation. But I think >it's >clear that distutils.util is not *3rd party* python library. > >I have tried that the command "sudo apt upgrade" can't fix this bug while the >command "sudo apt-get install python3-distutils" works. > >Thanks, >Bob > >-Original Message- >From: Laszlo Ersek [mailto:ler...@redhat.com] >Sent: Tuesday, February 12, 2019 10:02 PM >To: Gao, Liming ; Feng, Bob C >; Bi, Dandan >Cc: edk2-devel@lists.01.org >Subject: Re: [edk2] [Patch 0/3] BaseTools: Implement splitquoted function > >On 02/12/19 14:33, Gao, Liming wrote: >> Laszlo: >> To install python3-distutils should resolve this issue. I expect BaseTools >build functionality doesn't depend on the third party python lib. > >I completely agree with your expectation, regarding *3rd party* python >packages. We shouldn't expect developers to install packages from >repositories that fall outside of their normal distro repos. > >However, my understanding was that python3-distutils should be available as >a normal (not 3rd party) component on Ubuntu 18. I think we can expect >developers to install additional packages if those packages are readily >available >in their normal (distro-provided) repos. > >> So, I suggest to check whether python3-distutils is the native python >> library. >If it is native python library, why Ubuntu18 doesn't include it. I will work >with >Dandan to collect more information. > >Right, that's exactly what I'm asking for. Thank you very much! >Laszlo > >>> -Original Message- >>> From: Laszlo Ersek [mailto:ler...@redhat.com] >>> Sent: Tuesday, February 12, 2019 8:24 PM >>> To: Feng, Bob C ; Bi, Dandan >>> >>> Cc: edk2-devel@lists.01.org; Gao, Liming >>> Subject: Re: [edk2] [Patch 0/3] BaseTools: Implement splitquoted >>> function >>> >>> On 02/04/19 20:12, Laszlo Ersek wrote: >>>> On 02/03/19 06:55, Feng, Bob C wrote: >>>>> BZ: https://bugzilla.tianocore.org/show_bug.cgi?id=1509 >>>>> On some Linux environment, there may be no distutils.util library >>>>> for python3 that will cause build tool crash. >>>>> This patch implement distutils.util.split_quoted in BaseTools so >>>>> that the Basetools will be independent with distutils.util library. >>>>> >>>>> Feng, Bob C (3): >>>>> BaseTools: Implement splitquoted function in Build tool >>>>> BaseTools: Implement splitquoted function in UPT >>>>> BaseTools: unit test for splitquoted function >>>>> >>>>> BaseTools/Source/Python/AutoGen/UniClassObject.py | 50 >++ >>>>> BaseTools/Source/Python/UPT/Library/UniClassObject.py | 47 >--- >>>>> BaseTools/Tests/TestStringSplit.py| 38 >++ >>>>> 3 files changed, 128 insertions(+), 7 deletions(-) create mode >>>>> 100644 BaseTools/Tests/TestStringSplit.py >>>>> >>>> >>>> Is this really necessary? BZ#1509 references Ubuntu18; however it >>>> looks like the issue can be resolved by a simple package >>>> installation on Ubuntu 18: >>>> >>>> https://superuser.com/questions/1319047/cant-install-virtual-interpr >>>> eter-in-pycharm-in-linux >>>> >>>> """ >>>> sudo apt-get install python3-distutils """ >>>> >>>> I'm not a Ubuntu user myself; so all I can do here (without >>>> installing a >>>> Ubuntu18 VM) is check the Ubuntu package directory: >>>> >>>> https://packages.ubuntu.com/search?keywords=python3- >distutils >>>> on=names=all=all >>>> >>>> python3-distutils appears available for both "bionic (18.04LTS)" and >>>> "cosmic (18.10)". >>>> >>>> Dandan, if you install python3-distutils, does that solve the issue for >>>> you? >>> >>> I'd still like to get an answer to my question, before the series is pushed. >>> >>> Thanks, >>> Laszlo ___ edk2-devel mailing list edk2-devel@lists.01.org https://lists.01.org/mailman/listinfo/edk2-devel
Re: [edk2] [Patch 0/3] BaseTools: Implement splitquoted function
Hi Laszlo, Liming, Jaben and Dandan, I found this is a Ubuntu18 bug. Refer to https://bugs.launchpad.net/ubuntu/+source/fdroidserver/+bug/1762183 And Ubuntu fixed this bug via a Ubuntu18.04.1 update package which was published on 2018-08-09. Refer to https://launchpad.net/ubuntu/+source/fdroidserver/1.0.9-1~18.04.1 While the latest Ubuntu 18.04 release (ubuntu-18.04.1-desktop-amd64.iso) on http://releases.ubuntu.com/18.04/ was published on 2018-07-25. So there is no distutils.util library on Ubuntu18.04 default installation. But I think it's clear that distutils.util is not *3rd party* python library. I have tried that the command "sudo apt upgrade" can't fix this bug while the command "sudo apt-get install python3-distutils" works. Thanks, Bob -Original Message- From: Laszlo Ersek [mailto:ler...@redhat.com] Sent: Tuesday, February 12, 2019 10:02 PM To: Gao, Liming ; Feng, Bob C ; Bi, Dandan Cc: edk2-devel@lists.01.org Subject: Re: [edk2] [Patch 0/3] BaseTools: Implement splitquoted function On 02/12/19 14:33, Gao, Liming wrote: > Laszlo: > To install python3-distutils should resolve this issue. I expect BaseTools > build functionality doesn't depend on the third party python lib. I completely agree with your expectation, regarding *3rd party* python packages. We shouldn't expect developers to install packages from repositories that fall outside of their normal distro repos. However, my understanding was that python3-distutils should be available as a normal (not 3rd party) component on Ubuntu 18. I think we can expect developers to install additional packages if those packages are readily available in their normal (distro-provided) repos. > So, I suggest to check whether python3-distutils is the native python > library. If it is native python library, why Ubuntu18 doesn't include it. I > will work with Dandan to collect more information. Right, that's exactly what I'm asking for. Thank you very much! Laszlo >> -Original Message- >> From: Laszlo Ersek [mailto:ler...@redhat.com] >> Sent: Tuesday, February 12, 2019 8:24 PM >> To: Feng, Bob C ; Bi, Dandan >> >> Cc: edk2-devel@lists.01.org; Gao, Liming >> Subject: Re: [edk2] [Patch 0/3] BaseTools: Implement splitquoted >> function >> >> On 02/04/19 20:12, Laszlo Ersek wrote: >>> On 02/03/19 06:55, Feng, Bob C wrote: >>>> BZ: https://bugzilla.tianocore.org/show_bug.cgi?id=1509 >>>> On some Linux environment, there may be no distutils.util library >>>> for python3 that will cause build tool crash. >>>> This patch implement distutils.util.split_quoted in BaseTools so >>>> that the Basetools will be independent with distutils.util library. >>>> >>>> Feng, Bob C (3): >>>> BaseTools: Implement splitquoted function in Build tool >>>> BaseTools: Implement splitquoted function in UPT >>>> BaseTools: unit test for splitquoted function >>>> >>>> BaseTools/Source/Python/AutoGen/UniClassObject.py | 50 >>>> ++ >>>> BaseTools/Source/Python/UPT/Library/UniClassObject.py | 47 >>>> --- >>>> BaseTools/Tests/TestStringSplit.py| 38 >>>> ++ >>>> 3 files changed, 128 insertions(+), 7 deletions(-) create mode >>>> 100644 BaseTools/Tests/TestStringSplit.py >>>> >>> >>> Is this really necessary? BZ#1509 references Ubuntu18; however it >>> looks like the issue can be resolved by a simple package >>> installation on Ubuntu 18: >>> >>> https://superuser.com/questions/1319047/cant-install-virtual-interpr >>> eter-in-pycharm-in-linux >>> >>> """ >>> sudo apt-get install python3-distutils """ >>> >>> I'm not a Ubuntu user myself; so all I can do here (without >>> installing a >>> Ubuntu18 VM) is check the Ubuntu package directory: >>> >>> https://packages.ubuntu.com/search?keywords=python3-distutils >>> on=names=all=all >>> >>> python3-distutils appears available for both "bionic (18.04LTS)" and >>> "cosmic (18.10)". >>> >>> Dandan, if you install python3-distutils, does that solve the issue for you? >> >> I'd still like to get an answer to my question, before the series is pushed. >> >> Thanks, >> Laszlo ___ edk2-devel mailing list edk2-devel@lists.01.org https://lists.01.org/mailman/listinfo/edk2-devel
Re: [edk2] [Patch 0/3] BaseTools: Implement splitquoted function
On 02/12/19 18:16, Philippe Mathieu-Daudé wrote: > On 2/12/19 3:02 PM, Laszlo Ersek wrote: >> On 02/12/19 14:33, Gao, Liming wrote: >>> Laszlo: >>> To install python3-distutils should resolve this issue. I expect BaseTools >>> build functionality doesn't depend on the third party python lib. >> >> I completely agree with your expectation, regarding *3rd party* python >> packages. We shouldn't expect developers to install packages from >> repositories that fall outside of their normal distro repos. >> >> However, my understanding was that python3-distutils should be available >> as a normal (not 3rd party) component on Ubuntu 18. I think we can >> expect developers to install additional packages if those packages are >> readily available in their normal (distro-provided) repos. > > The documentation is not precise about the python package to install, it > simply states "Install Python 2.7.10": > > https://github.com/tianocore/tianocore.github.io/wiki/Getting-Started-with-EDK-II > > -- > > Except python, there is a precise list of packages to install for this > distro: "sudo apt-get install build-essential uuid-dev iasl git gcc-5 > nasm", per: > > https://github.com/tianocore/tianocore.github.io/wiki/Using-EDK-II-with-Native-GCC#Install_required_software_from_apt > > Maybe we simply need to update the doc to ask python3 and add > python3-distutils in the list? I didn't realize we had Ubuntu-specific instructions for setting up the environment :) So yes, if Liming & Hao confirm python3-distutils is available as part of Ubuntu 18, then the docs should likely be updated as you say. Thanks Laszlo > >> >>> So, I suggest to check whether python3-distutils is the native python >>> library. If it is native python library, why Ubuntu18 doesn't include it. I >>> will work with Dandan to collect more information. >> >> Right, that's exactly what I'm asking for. Thank you very much! >> Laszlo >> >>>> -----Original Message- >>>> From: Laszlo Ersek [mailto:ler...@redhat.com] >>>> Sent: Tuesday, February 12, 2019 8:24 PM >>>> To: Feng, Bob C ; Bi, Dandan >>>> Cc: edk2-devel@lists.01.org; Gao, Liming >>>> Subject: Re: [edk2] [Patch 0/3] BaseTools: Implement splitquoted function >>>> >>>> On 02/04/19 20:12, Laszlo Ersek wrote: >>>>> On 02/03/19 06:55, Feng, Bob C wrote: >>>>>> BZ: https://bugzilla.tianocore.org/show_bug.cgi?id=1509 >>>>>> On some Linux environment, there may be no distutils.util >>>>>> library for python3 that will cause build tool crash. >>>>>> This patch implement distutils.util.split_quoted >>>>>> in BaseTools so that the Basetools will be independent with >>>>>> distutils.util library. >>>>>> >>>>>> Feng, Bob C (3): >>>>>> BaseTools: Implement splitquoted function in Build tool >>>>>> BaseTools: Implement splitquoted function in UPT >>>>>> BaseTools: unit test for splitquoted function >>>>>> >>>>>> BaseTools/Source/Python/AutoGen/UniClassObject.py | 50 >>>>>> ++ >>>>>> BaseTools/Source/Python/UPT/Library/UniClassObject.py | 47 >>>>>> --- >>>>>> BaseTools/Tests/TestStringSplit.py| 38 >>>>>> ++ >>>>>> 3 files changed, 128 insertions(+), 7 deletions(-) >>>>>> create mode 100644 BaseTools/Tests/TestStringSplit.py >>>>>> >>>>> >>>>> Is this really necessary? BZ#1509 references Ubuntu18; however it looks >>>>> like the issue can be resolved by a simple package installation on >>>>> Ubuntu 18: >>>>> >>>>> https://superuser.com/questions/1319047/cant-install-virtual-interpreter-in-pycharm-in-linux >>>>> >>>>> """ >>>>> sudo apt-get install python3-distutils >>>>> """ >>>>> >>>>> I'm not a Ubuntu user myself; so all I can do here (without installing a >>>>> Ubuntu18 VM) is check the Ubuntu package directory: >>>>> >>>>> https://packages.ubuntu.com/search?keywords=python3-distutils=names=all=all >>>>> >>>>> python3-distutils appears available for both "bionic (18.04LTS)" and >>>>> "cosmic (18.10)". >>>>> >>>>> Dandan, if you install python3-distutils, does that solve the issue for >>>>> you? >>>> >>>> I'd still like to get an answer to my question, before the series is >>>> pushed. >>>> >>>> Thanks, >>>> Laszlo >> >> ___ >> edk2-devel mailing list >> edk2-devel@lists.01.org >> https://lists.01.org/mailman/listinfo/edk2-devel >> ___ edk2-devel mailing list edk2-devel@lists.01.org https://lists.01.org/mailman/listinfo/edk2-devel
Re: [edk2] [Patch 0/3] BaseTools: Implement splitquoted function
On 2/12/19 3:02 PM, Laszlo Ersek wrote: > On 02/12/19 14:33, Gao, Liming wrote: >> Laszlo: >> To install python3-distutils should resolve this issue. I expect BaseTools >> build functionality doesn't depend on the third party python lib. > > I completely agree with your expectation, regarding *3rd party* python > packages. We shouldn't expect developers to install packages from > repositories that fall outside of their normal distro repos. > > However, my understanding was that python3-distutils should be available > as a normal (not 3rd party) component on Ubuntu 18. I think we can > expect developers to install additional packages if those packages are > readily available in their normal (distro-provided) repos. The documentation is not precise about the python package to install, it simply states "Install Python 2.7.10": https://github.com/tianocore/tianocore.github.io/wiki/Getting-Started-with-EDK-II -- Except python, there is a precise list of packages to install for this distro: "sudo apt-get install build-essential uuid-dev iasl git gcc-5 nasm", per: https://github.com/tianocore/tianocore.github.io/wiki/Using-EDK-II-with-Native-GCC#Install_required_software_from_apt Maybe we simply need to update the doc to ask python3 and add python3-distutils in the list? > >> So, I suggest to check whether python3-distutils is the native python >> library. If it is native python library, why Ubuntu18 doesn't include it. I >> will work with Dandan to collect more information. > > Right, that's exactly what I'm asking for. Thank you very much! > Laszlo > >>> -Original Message- >>> From: Laszlo Ersek [mailto:ler...@redhat.com] >>> Sent: Tuesday, February 12, 2019 8:24 PM >>> To: Feng, Bob C ; Bi, Dandan >>> Cc: edk2-devel@lists.01.org; Gao, Liming >>> Subject: Re: [edk2] [Patch 0/3] BaseTools: Implement splitquoted function >>> >>> On 02/04/19 20:12, Laszlo Ersek wrote: >>>> On 02/03/19 06:55, Feng, Bob C wrote: >>>>> BZ: https://bugzilla.tianocore.org/show_bug.cgi?id=1509 >>>>> On some Linux environment, there may be no distutils.util >>>>> library for python3 that will cause build tool crash. >>>>> This patch implement distutils.util.split_quoted >>>>> in BaseTools so that the Basetools will be independent with >>>>> distutils.util library. >>>>> >>>>> Feng, Bob C (3): >>>>> BaseTools: Implement splitquoted function in Build tool >>>>> BaseTools: Implement splitquoted function in UPT >>>>> BaseTools: unit test for splitquoted function >>>>> >>>>> BaseTools/Source/Python/AutoGen/UniClassObject.py | 50 >>>>> ++ >>>>> BaseTools/Source/Python/UPT/Library/UniClassObject.py | 47 >>>>> --- >>>>> BaseTools/Tests/TestStringSplit.py| 38 >>>>> ++ >>>>> 3 files changed, 128 insertions(+), 7 deletions(-) >>>>> create mode 100644 BaseTools/Tests/TestStringSplit.py >>>>> >>>> >>>> Is this really necessary? BZ#1509 references Ubuntu18; however it looks >>>> like the issue can be resolved by a simple package installation on >>>> Ubuntu 18: >>>> >>>> https://superuser.com/questions/1319047/cant-install-virtual-interpreter-in-pycharm-in-linux >>>> >>>> """ >>>> sudo apt-get install python3-distutils >>>> """ >>>> >>>> I'm not a Ubuntu user myself; so all I can do here (without installing a >>>> Ubuntu18 VM) is check the Ubuntu package directory: >>>> >>>> https://packages.ubuntu.com/search?keywords=python3-distutils=names=all=all >>>> >>>> python3-distutils appears available for both "bionic (18.04LTS)" and >>>> "cosmic (18.10)". >>>> >>>> Dandan, if you install python3-distutils, does that solve the issue for >>>> you? >>> >>> I'd still like to get an answer to my question, before the series is pushed. >>> >>> Thanks, >>> Laszlo > > ___ > edk2-devel mailing list > edk2-devel@lists.01.org > https://lists.01.org/mailman/listinfo/edk2-devel > ___ edk2-devel mailing list edk2-devel@lists.01.org https://lists.01.org/mailman/listinfo/edk2-devel
Re: [edk2] [Patch 0/3] BaseTools: Implement splitquoted function
On 02/12/19 14:33, Gao, Liming wrote: > Laszlo: > To install python3-distutils should resolve this issue. I expect BaseTools > build functionality doesn't depend on the third party python lib. I completely agree with your expectation, regarding *3rd party* python packages. We shouldn't expect developers to install packages from repositories that fall outside of their normal distro repos. However, my understanding was that python3-distutils should be available as a normal (not 3rd party) component on Ubuntu 18. I think we can expect developers to install additional packages if those packages are readily available in their normal (distro-provided) repos. > So, I suggest to check whether python3-distutils is the native python > library. If it is native python library, why Ubuntu18 doesn't include it. I > will work with Dandan to collect more information. Right, that's exactly what I'm asking for. Thank you very much! Laszlo >> -Original Message- >> From: Laszlo Ersek [mailto:ler...@redhat.com] >> Sent: Tuesday, February 12, 2019 8:24 PM >> To: Feng, Bob C ; Bi, Dandan >> Cc: edk2-devel@lists.01.org; Gao, Liming >> Subject: Re: [edk2] [Patch 0/3] BaseTools: Implement splitquoted function >> >> On 02/04/19 20:12, Laszlo Ersek wrote: >>> On 02/03/19 06:55, Feng, Bob C wrote: >>>> BZ: https://bugzilla.tianocore.org/show_bug.cgi?id=1509 >>>> On some Linux environment, there may be no distutils.util >>>> library for python3 that will cause build tool crash. >>>> This patch implement distutils.util.split_quoted >>>> in BaseTools so that the Basetools will be independent with >>>> distutils.util library. >>>> >>>> Feng, Bob C (3): >>>> BaseTools: Implement splitquoted function in Build tool >>>> BaseTools: Implement splitquoted function in UPT >>>> BaseTools: unit test for splitquoted function >>>> >>>> BaseTools/Source/Python/AutoGen/UniClassObject.py | 50 >>>> ++ >>>> BaseTools/Source/Python/UPT/Library/UniClassObject.py | 47 >>>> --- >>>> BaseTools/Tests/TestStringSplit.py| 38 >>>> ++ >>>> 3 files changed, 128 insertions(+), 7 deletions(-) >>>> create mode 100644 BaseTools/Tests/TestStringSplit.py >>>> >>> >>> Is this really necessary? BZ#1509 references Ubuntu18; however it looks >>> like the issue can be resolved by a simple package installation on >>> Ubuntu 18: >>> >>> https://superuser.com/questions/1319047/cant-install-virtual-interpreter-in-pycharm-in-linux >>> >>> """ >>> sudo apt-get install python3-distutils >>> """ >>> >>> I'm not a Ubuntu user myself; so all I can do here (without installing a >>> Ubuntu18 VM) is check the Ubuntu package directory: >>> >>> https://packages.ubuntu.com/search?keywords=python3-distutils=names=all=all >>> >>> python3-distutils appears available for both "bionic (18.04LTS)" and >>> "cosmic (18.10)". >>> >>> Dandan, if you install python3-distutils, does that solve the issue for you? >> >> I'd still like to get an answer to my question, before the series is pushed. >> >> Thanks, >> Laszlo ___ edk2-devel mailing list edk2-devel@lists.01.org https://lists.01.org/mailman/listinfo/edk2-devel
Re: [edk2] [Patch 0/3] BaseTools: Implement splitquoted function
Laszlo: To install python3-distutils should resolve this issue. I expect BaseTools build functionality doesn't depend on the third party python lib. So, I suggest to check whether python3-distutils is the native python library. If it is native python library, why Ubuntu18 doesn't include it. I will work with Dandan to collect more information. Thanks Liming > -Original Message- > From: Laszlo Ersek [mailto:ler...@redhat.com] > Sent: Tuesday, February 12, 2019 8:24 PM > To: Feng, Bob C ; Bi, Dandan > Cc: edk2-devel@lists.01.org; Gao, Liming > Subject: Re: [edk2] [Patch 0/3] BaseTools: Implement splitquoted function > > On 02/04/19 20:12, Laszlo Ersek wrote: > > On 02/03/19 06:55, Feng, Bob C wrote: > >> BZ: https://bugzilla.tianocore.org/show_bug.cgi?id=1509 > >> On some Linux environment, there may be no distutils.util > >> library for python3 that will cause build tool crash. > >> This patch implement distutils.util.split_quoted > >> in BaseTools so that the Basetools will be independent with > >> distutils.util library. > >> > >> Feng, Bob C (3): > >> BaseTools: Implement splitquoted function in Build tool > >> BaseTools: Implement splitquoted function in UPT > >> BaseTools: unit test for splitquoted function > >> > >> BaseTools/Source/Python/AutoGen/UniClassObject.py | 50 > >> ++ > >> BaseTools/Source/Python/UPT/Library/UniClassObject.py | 47 > >> --- > >> BaseTools/Tests/TestStringSplit.py| 38 > >> ++ > >> 3 files changed, 128 insertions(+), 7 deletions(-) > >> create mode 100644 BaseTools/Tests/TestStringSplit.py > >> > > > > Is this really necessary? BZ#1509 references Ubuntu18; however it looks > > like the issue can be resolved by a simple package installation on > > Ubuntu 18: > > > > https://superuser.com/questions/1319047/cant-install-virtual-interpreter-in-pycharm-in-linux > > > > """ > > sudo apt-get install python3-distutils > > """ > > > > I'm not a Ubuntu user myself; so all I can do here (without installing a > > Ubuntu18 VM) is check the Ubuntu package directory: > > > > https://packages.ubuntu.com/search?keywords=python3-distutils=names=all=all > > > > python3-distutils appears available for both "bionic (18.04LTS)" and > > "cosmic (18.10)". > > > > Dandan, if you install python3-distutils, does that solve the issue for you? > > I'd still like to get an answer to my question, before the series is pushed. > > Thanks, > Laszlo ___ edk2-devel mailing list edk2-devel@lists.01.org https://lists.01.org/mailman/listinfo/edk2-devel
Re: [edk2] [Patch 0/3] BaseTools: Implement splitquoted function
On 02/04/19 20:12, Laszlo Ersek wrote: > On 02/03/19 06:55, Feng, Bob C wrote: >> BZ: https://bugzilla.tianocore.org/show_bug.cgi?id=1509 >> On some Linux environment, there may be no distutils.util >> library for python3 that will cause build tool crash. >> This patch implement distutils.util.split_quoted >> in BaseTools so that the Basetools will be independent with >> distutils.util library. >> >> Feng, Bob C (3): >> BaseTools: Implement splitquoted function in Build tool >> BaseTools: Implement splitquoted function in UPT >> BaseTools: unit test for splitquoted function >> >> BaseTools/Source/Python/AutoGen/UniClassObject.py | 50 >> ++ >> BaseTools/Source/Python/UPT/Library/UniClassObject.py | 47 >> --- >> BaseTools/Tests/TestStringSplit.py| 38 >> ++ >> 3 files changed, 128 insertions(+), 7 deletions(-) >> create mode 100644 BaseTools/Tests/TestStringSplit.py >> > > Is this really necessary? BZ#1509 references Ubuntu18; however it looks > like the issue can be resolved by a simple package installation on > Ubuntu 18: > > https://superuser.com/questions/1319047/cant-install-virtual-interpreter-in-pycharm-in-linux > > """ > sudo apt-get install python3-distutils > """ > > I'm not a Ubuntu user myself; so all I can do here (without installing a > Ubuntu18 VM) is check the Ubuntu package directory: > > https://packages.ubuntu.com/search?keywords=python3-distutils=names=all=all > > python3-distutils appears available for both "bionic (18.04LTS)" and > "cosmic (18.10)". > > Dandan, if you install python3-distutils, does that solve the issue for you? I'd still like to get an answer to my question, before the series is pushed. Thanks, Laszlo ___ edk2-devel mailing list edk2-devel@lists.01.org https://lists.01.org/mailman/listinfo/edk2-devel
Re: [edk2] [Patch 0/3] BaseTools: Implement splitquoted function
Reviewed-by: Liming Gao > -Original Message- > From: edk2-devel [mailto:edk2-devel-boun...@lists.01.org] On Behalf Of Feng, > Bob C > Sent: Sunday, February 3, 2019 1:55 PM > To: edk2-devel@lists.01.org > Subject: [edk2] [Patch 0/3] BaseTools: Implement splitquoted function > > BZ: https://bugzilla.tianocore.org/show_bug.cgi?id=1509 > On some Linux environment, there may be no distutils.util > library for python3 that will cause build tool crash. > This patch implement distutils.util.split_quoted > in BaseTools so that the Basetools will be independent with > distutils.util library. > > Feng, Bob C (3): > BaseTools: Implement splitquoted function in Build tool > BaseTools: Implement splitquoted function in UPT > BaseTools: unit test for splitquoted function > > BaseTools/Source/Python/AutoGen/UniClassObject.py | 50 > ++ > BaseTools/Source/Python/UPT/Library/UniClassObject.py | 47 > --- > BaseTools/Tests/TestStringSplit.py| 38 > ++ > 3 files changed, 128 insertions(+), 7 deletions(-) > create mode 100644 BaseTools/Tests/TestStringSplit.py > > -- > 2.20.1.windows.1 > > ___ > edk2-devel mailing list > edk2-devel@lists.01.org > https://lists.01.org/mailman/listinfo/edk2-devel ___ edk2-devel mailing list edk2-devel@lists.01.org https://lists.01.org/mailman/listinfo/edk2-devel
Re: [edk2] [Patch 0/3] BaseTools: Implement splitquoted function
On 02/03/19 06:55, Feng, Bob C wrote: > BZ: https://bugzilla.tianocore.org/show_bug.cgi?id=1509 > On some Linux environment, there may be no distutils.util > library for python3 that will cause build tool crash. > This patch implement distutils.util.split_quoted > in BaseTools so that the Basetools will be independent with > distutils.util library. > > Feng, Bob C (3): > BaseTools: Implement splitquoted function in Build tool > BaseTools: Implement splitquoted function in UPT > BaseTools: unit test for splitquoted function > > BaseTools/Source/Python/AutoGen/UniClassObject.py | 50 > ++ > BaseTools/Source/Python/UPT/Library/UniClassObject.py | 47 > --- > BaseTools/Tests/TestStringSplit.py| 38 > ++ > 3 files changed, 128 insertions(+), 7 deletions(-) > create mode 100644 BaseTools/Tests/TestStringSplit.py > Is this really necessary? BZ#1509 references Ubuntu18; however it looks like the issue can be resolved by a simple package installation on Ubuntu 18: https://superuser.com/questions/1319047/cant-install-virtual-interpreter-in-pycharm-in-linux """ sudo apt-get install python3-distutils """ I'm not a Ubuntu user myself; so all I can do here (without installing a Ubuntu18 VM) is check the Ubuntu package directory: https://packages.ubuntu.com/search?keywords=python3-distutils=names=all=all python3-distutils appears available for both "bionic (18.04LTS)" and "cosmic (18.10)". Dandan, if you install python3-distutils, does that solve the issue for you? Thanks Laszlo ___ edk2-devel mailing list edk2-devel@lists.01.org https://lists.01.org/mailman/listinfo/edk2-devel
[edk2] [Patch 0/3] BaseTools: Implement splitquoted function
BZ: https://bugzilla.tianocore.org/show_bug.cgi?id=1509 On some Linux environment, there may be no distutils.util library for python3 that will cause build tool crash. This patch implement distutils.util.split_quoted in BaseTools so that the Basetools will be independent with distutils.util library. Feng, Bob C (3): BaseTools: Implement splitquoted function in Build tool BaseTools: Implement splitquoted function in UPT BaseTools: unit test for splitquoted function BaseTools/Source/Python/AutoGen/UniClassObject.py | 50 ++ BaseTools/Source/Python/UPT/Library/UniClassObject.py | 47 --- BaseTools/Tests/TestStringSplit.py| 38 ++ 3 files changed, 128 insertions(+), 7 deletions(-) create mode 100644 BaseTools/Tests/TestStringSplit.py -- 2.20.1.windows.1 ___ edk2-devel mailing list edk2-devel@lists.01.org https://lists.01.org/mailman/listinfo/edk2-devel
