Re: [edk2] [Patch 3/5] IntelFsp2Pkg BaseFspDebugLibSerialPort: Remove MASM/GAS files

2016-07-12 Thread Yao, Jiewen
Reviewed by: jiewen@intel.com

> -Original Message-
> From: Gao, Liming
> Sent: Friday, July 8, 2016 10:49 PM
> To: edk2-devel@lists.01.org
> Cc: Yao, Jiewen ; Mudusuru, Giri P
> 
> Subject: [Patch 3/5] IntelFsp2Pkg BaseFspDebugLibSerialPort: Remove
> MASM/GAS files
> 
> Keep NASM file only for new added modules.
> 
> Cc: Jiewen Yao 
> Cc: Giri Mudusuru 
> Contributed-under: TianoCore Contribution Agreement 1.0
> Signed-off-by: Liming Gao 
> ---
>  .../BaseFspDebugLibSerialPort.inf  |  2 --
>  .../BaseFspDebugLibSerialPort/Ia32/FspDebug.asm| 34
> --
>  .../BaseFspDebugLibSerialPort/Ia32/FspDebug.s  | 30 ---
>  3 files changed, 66 deletions(-)
>  delete mode 100644
> IntelFsp2Pkg/Library/BaseFspDebugLibSerialPort/Ia32/FspDebug.asm
>  delete mode 100644
> IntelFsp2Pkg/Library/BaseFspDebugLibSerialPort/Ia32/FspDebug.s
> 
> diff --git
> a/IntelFsp2Pkg/Library/BaseFspDebugLibSerialPort/BaseFspDebugLibSerialP
> ort.inf
> b/IntelFsp2Pkg/Library/BaseFspDebugLibSerialPort/BaseFspDebugLibSerialP
> ort.inf
> index 33e72a6..49adfd8 100644
> ---
> a/IntelFsp2Pkg/Library/BaseFspDebugLibSerialPort/BaseFspDebugLibSerialP
> ort.inf
> +++
> b/IntelFsp2Pkg/Library/BaseFspDebugLibSerialPort/BaseFspDebugLibSerialP
> ort.inf
> @@ -27,12 +27,10 @@
>  [Sources]
>DebugLib.c
> 
>  [Sources.Ia32]
>Ia32/FspDebug.nasm
> -  Ia32/FspDebug.asm
> -  Ia32/FspDebug.s
> 
>  [Packages]
>MdePkg/MdePkg.dec
>IntelFsp2Pkg/IntelFsp2Pkg.dec
> 
> diff --git
> a/IntelFsp2Pkg/Library/BaseFspDebugLibSerialPort/Ia32/FspDebug.asm
> b/IntelFsp2Pkg/Library/BaseFspDebugLibSerialPort/Ia32/FspDebug.asm
> deleted file mode 100644
> index 8ac18ec..000
> --- a/IntelFsp2Pkg/Library/BaseFspDebugLibSerialPort/Ia32/FspDebug.asm
> +++ /dev/null
> @@ -1,34 +0,0 @@
> -;--
> -;
> -; Copyright (c) 2014, Intel Corporation. All rights reserved.
> -; This program and the accompanying materials
> -; are licensed and made available under the terms and conditions of the BSD
> License
> -; which accompanies this distribution.  The full text of the license may be
> found at
> -; http://opensource.org/licenses/bsd-license.php.
> -;
> -; THE PROGRAM IS DISTRIBUTED UNDER THE BSD LICENSE ON AN "AS IS"
> BASIS,
> -; WITHOUT WARRANTIES OR REPRESENTATIONS OF ANY KIND, EITHER
> EXPRESS OR IMPLIED.
> -;
> -; Abstract:
> -;
> -;   FSP Debug functions
> -;
> -;--
> -
> -.386
> -.model  flat,C
> -.code
> -
> -;--
> -; UINT32 *
> -; EFIAPI
> -; GetStackFramePointer (
> -;   VOID
> -;   );
> -;--
> -GetStackFramePointer  PROC  PUBLIC
> -mov eax, ebp
> -ret
> -GetStackFramePointer  ENDP
> -
> -END
> diff --git
> a/IntelFsp2Pkg/Library/BaseFspDebugLibSerialPort/Ia32/FspDebug.s
> b/IntelFsp2Pkg/Library/BaseFspDebugLibSerialPort/Ia32/FspDebug.s
> deleted file mode 100644
> index 0f8475f..000
> --- a/IntelFsp2Pkg/Library/BaseFspDebugLibSerialPort/Ia32/FspDebug.s
> +++ /dev/null
> @@ -1,30 +0,0 @@
> -#--
> -#
> -# Copyright (c) 2014, Intel Corporation. All rights reserved.
> -# This program and the accompanying materials
> -# are licensed and made available under the terms and conditions of the
> BSD License
> -# which accompanies this distribution.  The full text of the license may be
> found at
> -# http://opensource.org/licenses/bsd-license.php.
> -#
> -# THE PROGRAM IS DISTRIBUTED UNDER THE BSD LICENSE ON AN "AS IS"
> BASIS,
> -# WITHOUT WARRANTIES OR REPRESENTATIONS OF ANY KIND, EITHER
> EXPRESS OR IMPLIED.
> -#
> -# Abstract:
> -#
> -#   FSP Debug functions
> -#
> -#--
> -
> -#--
> -# UINT32 *
> -# EFIAPI
> -# GetStackFramePointer (
> -#   VOID
> -#   )
> -#--
> -ASM_GLOBAL ASM_PFX(GetStackFramePointer)
> -ASM_PFX(GetStackFramePointer):
> -mov%ebp, %eax
> -ret
> -
> -
> --
> 1.9.5.msysgit.0

___
edk2-devel mailing list
edk2-devel@lists.01.org
https://lists.01.org/mailman/listinfo/edk2-devel


Re: [edk2] [Patch 3/5] IntelFsp2Pkg BaseFspDebugLibSerialPort: Remove MASM/GAS files

2016-07-08 Thread Mudusuru, Giri P
Reviewed-by: Giri P Mudusuru  

> -Original Message-
> From: Gao, Liming
> Sent: Friday, July 8, 2016 7:49 AM
> To: edk2-devel@lists.01.org
> Cc: Yao, Jiewen ; Mudusuru, Giri P
> 
> Subject: [Patch 3/5] IntelFsp2Pkg BaseFspDebugLibSerialPort: Remove
> MASM/GAS files
> 
> Keep NASM file only for new added modules.
> 
> Cc: Jiewen Yao 
> Cc: Giri Mudusuru 
> Contributed-under: TianoCore Contribution Agreement 1.0
> Signed-off-by: Liming Gao 
> ---
>  .../BaseFspDebugLibSerialPort.inf  |  2 --
>  .../BaseFspDebugLibSerialPort/Ia32/FspDebug.asm| 34 
> --
>  .../BaseFspDebugLibSerialPort/Ia32/FspDebug.s  | 30 ---
>  3 files changed, 66 deletions(-)
>  delete mode 100644
> IntelFsp2Pkg/Library/BaseFspDebugLibSerialPort/Ia32/FspDebug.asm
>  delete mode 100644
> IntelFsp2Pkg/Library/BaseFspDebugLibSerialPort/Ia32/FspDebug.s
> 
> diff --git
> a/IntelFsp2Pkg/Library/BaseFspDebugLibSerialPort/BaseFspDebugLibSerialPort.i
> nf
> b/IntelFsp2Pkg/Library/BaseFspDebugLibSerialPort/BaseFspDebugLibSerialPort.i
> nf
> index 33e72a6..49adfd8 100644
> ---
> a/IntelFsp2Pkg/Library/BaseFspDebugLibSerialPort/BaseFspDebugLibSerialPort.i
> nf
> +++
> b/IntelFsp2Pkg/Library/BaseFspDebugLibSerialPort/BaseFspDebugLibSerialPort.i
> nf
> @@ -27,12 +27,10 @@
>  [Sources]
>DebugLib.c
> 
>  [Sources.Ia32]
>Ia32/FspDebug.nasm
> -  Ia32/FspDebug.asm
> -  Ia32/FspDebug.s
> 
>  [Packages]
>MdePkg/MdePkg.dec
>IntelFsp2Pkg/IntelFsp2Pkg.dec
> 
> diff --git a/IntelFsp2Pkg/Library/BaseFspDebugLibSerialPort/Ia32/FspDebug.asm
> b/IntelFsp2Pkg/Library/BaseFspDebugLibSerialPort/Ia32/FspDebug.asm
> deleted file mode 100644
> index 8ac18ec..000
> --- a/IntelFsp2Pkg/Library/BaseFspDebugLibSerialPort/Ia32/FspDebug.asm
> +++ /dev/null
> @@ -1,34 +0,0 @@
> -;--
> -;
> -; Copyright (c) 2014, Intel Corporation. All rights reserved.
> -; This program and the accompanying materials
> -; are licensed and made available under the terms and conditions of the BSD
> License
> -; which accompanies this distribution.  The full text of the license may be 
> found
> at
> -; http://opensource.org/licenses/bsd-license.php.
> -;
> -; THE PROGRAM IS DISTRIBUTED UNDER THE BSD LICENSE ON AN "AS IS"
> BASIS,
> -; WITHOUT WARRANTIES OR REPRESENTATIONS OF ANY KIND, EITHER
> EXPRESS OR IMPLIED.
> -;
> -; Abstract:
> -;
> -;   FSP Debug functions
> -;
> -;--
> -
> -.386
> -.model  flat,C
> -.code
> -
> -;--
> -; UINT32 *
> -; EFIAPI
> -; GetStackFramePointer (
> -;   VOID
> -;   );
> -;--
> -GetStackFramePointer  PROC  PUBLIC
> -mov eax, ebp
> -ret
> -GetStackFramePointer  ENDP
> -
> -END
> diff --git a/IntelFsp2Pkg/Library/BaseFspDebugLibSerialPort/Ia32/FspDebug.s
> b/IntelFsp2Pkg/Library/BaseFspDebugLibSerialPort/Ia32/FspDebug.s
> deleted file mode 100644
> index 0f8475f..000
> --- a/IntelFsp2Pkg/Library/BaseFspDebugLibSerialPort/Ia32/FspDebug.s
> +++ /dev/null
> @@ -1,30 +0,0 @@
> -#--
> -#
> -# Copyright (c) 2014, Intel Corporation. All rights reserved.
> -# This program and the accompanying materials
> -# are licensed and made available under the terms and conditions of the BSD
> License
> -# which accompanies this distribution.  The full text of the license may be 
> found
> at
> -# http://opensource.org/licenses/bsd-license.php.
> -#
> -# THE PROGRAM IS DISTRIBUTED UNDER THE BSD LICENSE ON AN "AS IS"
> BASIS,
> -# WITHOUT WARRANTIES OR REPRESENTATIONS OF ANY KIND, EITHER
> EXPRESS OR IMPLIED.
> -#
> -# Abstract:
> -#
> -#   FSP Debug functions
> -#
> -#--
> -
> -#--
> -# UINT32 *
> -# EFIAPI
> -# GetStackFramePointer (
> -#   VOID
> -#   )
> -#--
> -ASM_GLOBAL ASM_PFX(GetStackFramePointer)
> -ASM_PFX(GetStackFramePointer):
> -mov%ebp, %eax
> -ret
> -
> -
> --
> 1.9.5.msysgit.0

___
edk2-devel mailing list
edk2-devel@lists.01.org
https://lists.01.org/mailman/listinfo/edk2-devel


[edk2] [Patch 3/5] IntelFsp2Pkg BaseFspDebugLibSerialPort: Remove MASM/GAS files

2016-07-08 Thread Liming Gao
Keep NASM file only for new added modules.

Cc: Jiewen Yao 
Cc: Giri Mudusuru 
Contributed-under: TianoCore Contribution Agreement 1.0
Signed-off-by: Liming Gao 
---
 .../BaseFspDebugLibSerialPort.inf  |  2 --
 .../BaseFspDebugLibSerialPort/Ia32/FspDebug.asm| 34 --
 .../BaseFspDebugLibSerialPort/Ia32/FspDebug.s  | 30 ---
 3 files changed, 66 deletions(-)
 delete mode 100644 
IntelFsp2Pkg/Library/BaseFspDebugLibSerialPort/Ia32/FspDebug.asm
 delete mode 100644 
IntelFsp2Pkg/Library/BaseFspDebugLibSerialPort/Ia32/FspDebug.s

diff --git 
a/IntelFsp2Pkg/Library/BaseFspDebugLibSerialPort/BaseFspDebugLibSerialPort.inf 
b/IntelFsp2Pkg/Library/BaseFspDebugLibSerialPort/BaseFspDebugLibSerialPort.inf
index 33e72a6..49adfd8 100644
--- 
a/IntelFsp2Pkg/Library/BaseFspDebugLibSerialPort/BaseFspDebugLibSerialPort.inf
+++ 
b/IntelFsp2Pkg/Library/BaseFspDebugLibSerialPort/BaseFspDebugLibSerialPort.inf
@@ -27,12 +27,10 @@
 [Sources]
   DebugLib.c
 
 [Sources.Ia32]
   Ia32/FspDebug.nasm
-  Ia32/FspDebug.asm
-  Ia32/FspDebug.s
 
 [Packages]
   MdePkg/MdePkg.dec
   IntelFsp2Pkg/IntelFsp2Pkg.dec
 
diff --git a/IntelFsp2Pkg/Library/BaseFspDebugLibSerialPort/Ia32/FspDebug.asm 
b/IntelFsp2Pkg/Library/BaseFspDebugLibSerialPort/Ia32/FspDebug.asm
deleted file mode 100644
index 8ac18ec..000
--- a/IntelFsp2Pkg/Library/BaseFspDebugLibSerialPort/Ia32/FspDebug.asm
+++ /dev/null
@@ -1,34 +0,0 @@
-;--
-;
-; Copyright (c) 2014, Intel Corporation. All rights reserved.
-; This program and the accompanying materials
-; are licensed and made available under the terms and conditions of the BSD 
License
-; which accompanies this distribution.  The full text of the license may be 
found at
-; http://opensource.org/licenses/bsd-license.php.
-;
-; THE PROGRAM IS DISTRIBUTED UNDER THE BSD LICENSE ON AN "AS IS" BASIS,
-; WITHOUT WARRANTIES OR REPRESENTATIONS OF ANY KIND, EITHER EXPRESS OR IMPLIED.
-;
-; Abstract:
-;
-;   FSP Debug functions
-;
-;--
-
-.386
-.model  flat,C
-.code
-
-;--
-; UINT32 *
-; EFIAPI
-; GetStackFramePointer (
-;   VOID
-;   );
-;--
-GetStackFramePointer  PROC  PUBLIC
-mov eax, ebp
-ret
-GetStackFramePointer  ENDP
-
-END
diff --git a/IntelFsp2Pkg/Library/BaseFspDebugLibSerialPort/Ia32/FspDebug.s 
b/IntelFsp2Pkg/Library/BaseFspDebugLibSerialPort/Ia32/FspDebug.s
deleted file mode 100644
index 0f8475f..000
--- a/IntelFsp2Pkg/Library/BaseFspDebugLibSerialPort/Ia32/FspDebug.s
+++ /dev/null
@@ -1,30 +0,0 @@
-#--
-#
-# Copyright (c) 2014, Intel Corporation. All rights reserved.
-# This program and the accompanying materials
-# are licensed and made available under the terms and conditions of the BSD 
License
-# which accompanies this distribution.  The full text of the license may be 
found at
-# http://opensource.org/licenses/bsd-license.php.
-#
-# THE PROGRAM IS DISTRIBUTED UNDER THE BSD LICENSE ON AN "AS IS" BASIS,
-# WITHOUT WARRANTIES OR REPRESENTATIONS OF ANY KIND, EITHER EXPRESS OR IMPLIED.
-#
-# Abstract:
-#
-#   FSP Debug functions
-#
-#--
-
-#--
-# UINT32 *
-# EFIAPI
-# GetStackFramePointer (
-#   VOID
-#   )
-#--
-ASM_GLOBAL ASM_PFX(GetStackFramePointer)
-ASM_PFX(GetStackFramePointer):
-mov%ebp, %eax
-ret
-
-
-- 
1.9.5.msysgit.0

___
edk2-devel mailing list
edk2-devel@lists.01.org
https://lists.01.org/mailman/listinfo/edk2-devel