Re: [edk2] [Patch v3 17/23] OvmfPkg/PlatformBds: Remove PlatformBdsGetDriverOption()

2016-04-28 Thread Laszlo Ersek 
On 04/21/16 08:58, Ruiyu Ni wrote:
> Contributed-under: TianoCore Contribution Agreement 1.0
> Signed-off-by: Ruiyu Ni 
> Cc: Jordan Justen 
> Cc: Laszlo Ersek 
> ---
>  .../Library/PlatformBootManagerLib/BdsPlatform.c   | 30 
> --
>  .../Library/PlatformBootManagerLib/BdsPlatform.h   |  6 -
>  2 files changed, 36 deletions(-)

Reviewed-by: Laszlo Ersek 

> diff --git a/OvmfPkg/Library/PlatformBootManagerLib/BdsPlatform.c 
> b/OvmfPkg/Library/PlatformBootManagerLib/BdsPlatform.c
> index 0284a9a..59ff097 100644
> --- a/OvmfPkg/Library/PlatformBootManagerLib/BdsPlatform.c
> +++ b/OvmfPkg/Library/PlatformBootManagerLib/BdsPlatform.c
> @@ -1129,31 +1129,6 @@ Returns:
>  }
>  
>  VOID
> -PlatformBdsGetDriverOption (
> -  IN OUT LIST_ENTRY  *BdsDriverLists
> -  )
> -/*++
> -
> -Routine Description:
> -
> -  Load the predefined driver option, OEM/IBV can customize this
> -  to load their own drivers
> -
> -Arguments:
> -
> -  BdsDriverLists  - The header of the driver option link list.
> -
> -Returns:
> -
> -  None.
> -
> ---*/
> -{
> -  DEBUG ((EFI_D_INFO, "PlatformBdsGetDriverOption\n"));
> -  return;
> -}
> -
> -VOID
>  PlatformBdsDiagnostics (
>IN EXTENDMEM_COVERAGE_LEVELMemoryTestLevel,
>IN BOOLEAN QuietBoot,
> @@ -1307,11 +1282,6 @@ Routine Description:
>}
>  
>//
> -  // Load the driver option as the driver option list
> -  //
> -  PlatformBdsGetDriverOption (DriverOptionList);
> -
> -  //
>// Get current Boot Mode
>//
>Status = BdsLibGetBootMode (&BootMode);
> diff --git a/OvmfPkg/Library/PlatformBootManagerLib/BdsPlatform.h 
> b/OvmfPkg/Library/PlatformBootManagerLib/BdsPlatform.h
> index ae3c268..6e5ca34 100644
> --- a/OvmfPkg/Library/PlatformBootManagerLib/BdsPlatform.h
> +++ b/OvmfPkg/Library/PlatformBootManagerLib/BdsPlatform.h
> @@ -210,12 +210,6 @@ extern PLATFORM_CONSOLE_CONNECT_ENTRY  
> gPlatformConsole[];
>  //
>  // Platform BDS Functions
>  //
> -
> -VOID
> -PlatformBdsGetDriverOption (
> -  IN LIST_ENTRY   *BdsDriverLists
> -  );
> -
>  EFI_STATUS
>  BdsMemoryTest (
>EXTENDMEM_COVERAGE_LEVEL Level
> 

___
edk2-devel mailing list
edk2-devel@lists.01.org
https://lists.01.org/mailman/listinfo/edk2-devel

[edk2] [Patch v3 17/23] OvmfPkg/PlatformBds: Remove PlatformBdsGetDriverOption()

2016-04-21 Thread Ruiyu Ni 
Contributed-under: TianoCore Contribution Agreement 1.0
Signed-off-by: Ruiyu Ni 
Cc: Jordan Justen 
Cc: Laszlo Ersek 
---
 .../Library/PlatformBootManagerLib/BdsPlatform.c   | 30 --
 .../Library/PlatformBootManagerLib/BdsPlatform.h   |  6 -
 2 files changed, 36 deletions(-)

diff --git a/OvmfPkg/Library/PlatformBootManagerLib/BdsPlatform.c 
b/OvmfPkg/Library/PlatformBootManagerLib/BdsPlatform.c
index 0284a9a..59ff097 100644
--- a/OvmfPkg/Library/PlatformBootManagerLib/BdsPlatform.c
+++ b/OvmfPkg/Library/PlatformBootManagerLib/BdsPlatform.c
@@ -1129,31 +1129,6 @@ Returns:
 }
 
 VOID
-PlatformBdsGetDriverOption (
-  IN OUT LIST_ENTRY  *BdsDriverLists
-  )
-/*++
-
-Routine Description:
-
-  Load the predefined driver option, OEM/IBV can customize this
-  to load their own drivers
-
-Arguments:
-
-  BdsDriverLists  - The header of the driver option link list.
-
-Returns:
-
-  None.
-
---*/
-{
-  DEBUG ((EFI_D_INFO, "PlatformBdsGetDriverOption\n"));
-  return;
-}
-
-VOID
 PlatformBdsDiagnostics (
   IN EXTENDMEM_COVERAGE_LEVELMemoryTestLevel,
   IN BOOLEAN QuietBoot,
@@ -1307,11 +1282,6 @@ Routine Description:
   }
 
   //
-  // Load the driver option as the driver option list
-  //
-  PlatformBdsGetDriverOption (DriverOptionList);
-
-  //
   // Get current Boot Mode
   //
   Status = BdsLibGetBootMode (&BootMode);
diff --git a/OvmfPkg/Library/PlatformBootManagerLib/BdsPlatform.h 
b/OvmfPkg/Library/PlatformBootManagerLib/BdsPlatform.h
index ae3c268..6e5ca34 100644
--- a/OvmfPkg/Library/PlatformBootManagerLib/BdsPlatform.h
+++ b/OvmfPkg/Library/PlatformBootManagerLib/BdsPlatform.h
@@ -210,12 +210,6 @@ extern PLATFORM_CONSOLE_CONNECT_ENTRY  gPlatformConsole[];
 //
 // Platform BDS Functions
 //
-
-VOID
-PlatformBdsGetDriverOption (
-  IN LIST_ENTRY   *BdsDriverLists
-  );
-
 EFI_STATUS
 BdsMemoryTest (
   EXTENDMEM_COVERAGE_LEVEL Level
-- 
2.7.0.windows.1

___
edk2-devel mailing list
edk2-devel@lists.01.org
https://lists.01.org/mailman/listinfo/edk2-devel