[edk2] ArmPlatformPkg: Non-compliant PeiServicesTablePointerLib implementation

[Cohen, Eugene]

In ArmPlatformPkg there is an implementation of the PeiServicesTablePointer 
library that uses the "global variable" creation.  (I don't know what the 
purpose is of these "global variables" but they seem to be incompatible with 
the philosophy of PI/edk2 which is all about decentralizing stuff - hence the 
reason GUIDed HOBs exist in PEI.)

This usage is not compatible with the PI specification (vol 1, section 5.4.4) 
and as such I recommend that we delete this library and ensure all ARM 
platforms use the library from ArmPkg.

Thanks,

Eugene



___
edk2-devel mailing list
edk2-devel@lists.01.org
https://lists.01.org/mailman/listinfo/edk2-devel

Re: [edk2] ArmPlatformPkg: Non-compliant PeiServicesTablePointerLib implementation

[Ard Biesheuvel]

On 24 November 2015 at 18:16, Cohen, Eugene  wrote:
> In ArmPlatformPkg there is an implementation of the PeiServicesTablePointer
> library that uses the "global variable" creation.  (I don't know what the
> purpose is of these "global variables" but they seem to be incompatible with
> the philosophy of PI/edk2 which is all about decentralizing stuff - hence
> the reason GUIDed HOBs exist in PEI.)
>
>
>
> This usage is not compatible with the PI specification (vol 1, section
> 5.4.4) and as such I recommend that we delete this library and ensure all
> ARM platforms use the library from ArmPkg.
>

Yes, I would gladly do that. This is the only use of these 'global
variables', as far as I can see, so we can remove them completely.

-- 
Ard.
___
edk2-devel mailing list
edk2-devel@lists.01.org
https://lists.01.org/mailman/listinfo/edk2-devel