On Wed, Jan 29, 2014 at 02:45:55PM -0800, Jordan Justen wrote: > This is a subset of the current ovmf-s3 branch at: > https://github.com/jljusten/edk2.git > > The goal is to bring the Xen boot path back together with > the QEMU boot path as much as possible. This will allow > the rest of S3 support to not break Xen normal boots, and > hopefully will allow Xen to support S3 as well. >
The only nit I can see is that you have DEBUG ((EFI_D_INFO, "Using memory map provided by Xen\n")); in both patch 3 and patch 8. It leads to print out that line twice. Other than that everything looks good. Reviewed-by: Wei Liu <wei.l...@citrix.com> Thanks! Wei. > Jordan Justen (7): > OvmfPkg/PlatformPei: Add mXen boolean to indicate Xen is running > OvmfPkg/PlatformPei: Hide Xen Leaf details > OvmfPkg/PlatformPei: Add XenPublishRamRegions > OvmfPkg/PlatformPei: Set PcdPciDisableBusEnumeration in InitializeXen > OvmfPkg/PlatformPei: Merge Xen support into MemMapInitialization > OvmfPkg/PlatformPei: Add InitializeRamRegions function > OvmfPkg/PlatformPei: Add RAM for Xen in InitializeRamRegions > > OvmfPkg/PlatformPei/MemDetect.c | 34 ++++++++--- > OvmfPkg/PlatformPei/Platform.c | 131 > ++++++++-------------------------------- > OvmfPkg/PlatformPei/Platform.h | 22 ++++--- > OvmfPkg/PlatformPei/Xen.c | 91 ++++++++++++++++++++++++---- > 4 files changed, 144 insertions(+), 134 deletions(-) > > -- > 1.8.5.3 ------------------------------------------------------------------------------ WatchGuard Dimension instantly turns raw network data into actionable security intelligence. It gives you real-time visual feedback on key security issues and trends. Skip the complicated setup - simply import a virtual appliance and go from zero to informed in seconds. http://pubads.g.doubleclick.net/gampad/clk?id=123612991&iu=/4140/ostg.clktrk _______________________________________________ edk2-devel mailing list edk2-devel@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/edk2-devel
