Re: [edk2] ShellPkg: Fix changing to file system with 2 colons like "fs0::"

2014-02-11 Thread Carsey, Jaben 
Ah.  Yes.  I think that implementation would be better to use the 
pre-initialized variable from the library.  I didn't notice that wasn't done in 
the patch that was submitted to me.

-Jaben

From: Tim Lewis [mailto:tim.le...@insyde.com]
Sent: Tuesday, February 11, 2014 4:02 PM
To: edk2-devel@lists.sourceforge.net; Bjorge, Erik C
Subject: Re: [edk2] ShellPkg: Fix changing to file system with 2 colons like 
"fs0::"

Sorry, I think it is 15220. It also looks like gUnicodeCollation is already 
initialized at this point (from UefiShellCommandLib)

Tim

From: Carsey, Jaben [mailto:jaben.car...@intel.com]
Sent: Tuesday, February 11, 2014 3:59 PM
To: edk2-devel@lists.sourceforge.net<mailto:edk2-devel@lists.sourceforge.net>; 
Bjorge, Erik C
Subject: Re: [edk2] ShellPkg: Fix changing to file system with 2 colons like 
"fs0::"

Tim,

I don't see anything like that.  It changes the "if" block to require that the 
last character in the string be a colon, and that the first colon in the string 
must be the last character in the string.  No Unicode collation at all...

-Jaben

From: Tim Lewis [mailto:tim.le...@insyde.com]
Sent: Tuesday, February 11, 2014 3:55 PM
To: edk2-devel@lists.sourceforge.net<mailto:edk2-devel@lists.sourceforge.net>; 
Bjorge, Erik C
Subject: Re: [edk2] ShellPkg: Fix changing to file system with 2 colons like 
"fs0::"

It looks like this tries to use UnicodeCollation instead of UnicodeCollation2. 
Did I read this wrong?

Tim

From: Carsey, Jaben [mailto:jaben.car...@intel.com]
Sent: Tuesday, February 11, 2014 3:38 PM
To: Bjorge, Erik C
Cc: edk2-devel@lists.sourceforge.net<mailto:edk2-devel@lists.sourceforge.net>
Subject: [edk2] ShellPkg: Fix changing to file system with 2 colons like "fs0::"

Erik,

Can you review this patch?

ShellPkg: Fix changing to file system with 2 colons like "fs0::"

Contributed-under: TianoCore Contribution Agreement 1.0
Signed-off-by: Jaben Carsey 
mailto:jaben.car...@intel.com>>
--
Android apps run on BlackBerry 10
Introducing the new BlackBerry 10.2.1 Runtime for Android apps.
Now with support for Jelly Bean, Bluetooth, Mapview and more.
Get your Android app in front of a whole new audience.  Start now.
http://pubads.g.doubleclick.net/gampad/clk?id=124407151&iu=/4140/ostg.clktrk___
edk2-devel mailing list
edk2-devel@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/edk2-devel

Re: [edk2] ShellPkg: Fix changing to file system with 2 colons like "fs0::"

2014-02-11 Thread Tim Lewis 
Sorry, I think it is 15220. It also looks like gUnicodeCollation is already 
initialized at this point (from UefiShellCommandLib)

Tim

From: Carsey, Jaben [mailto:jaben.car...@intel.com]
Sent: Tuesday, February 11, 2014 3:59 PM
To: edk2-devel@lists.sourceforge.net; Bjorge, Erik C
Subject: Re: [edk2] ShellPkg: Fix changing to file system with 2 colons like 
"fs0::"

Tim,

I don't see anything like that.  It changes the "if" block to require that the 
last character in the string be a colon, and that the first colon in the string 
must be the last character in the string.  No Unicode collation at all...

-Jaben

From: Tim Lewis [mailto:tim.le...@insyde.com]
Sent: Tuesday, February 11, 2014 3:55 PM
To: edk2-devel@lists.sourceforge.net<mailto:edk2-devel@lists.sourceforge.net>; 
Bjorge, Erik C
Subject: Re: [edk2] ShellPkg: Fix changing to file system with 2 colons like 
"fs0::"

It looks like this tries to use UnicodeCollation instead of UnicodeCollation2. 
Did I read this wrong?

Tim

From: Carsey, Jaben [mailto:jaben.car...@intel.com]
Sent: Tuesday, February 11, 2014 3:38 PM
To: Bjorge, Erik C
Cc: edk2-devel@lists.sourceforge.net<mailto:edk2-devel@lists.sourceforge.net>
Subject: [edk2] ShellPkg: Fix changing to file system with 2 colons like "fs0::"

Erik,

Can you review this patch?

ShellPkg: Fix changing to file system with 2 colons like "fs0::"

Contributed-under: TianoCore Contribution Agreement 1.0
Signed-off-by: Jaben Carsey 
mailto:jaben.car...@intel.com>>
--
Android apps run on BlackBerry 10
Introducing the new BlackBerry 10.2.1 Runtime for Android apps.
Now with support for Jelly Bean, Bluetooth, Mapview and more.
Get your Android app in front of a whole new audience.  Start now.
http://pubads.g.doubleclick.net/gampad/clk?id=124407151&iu=/4140/ostg.clktrk___
edk2-devel mailing list
edk2-devel@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/edk2-devel

Re: [edk2] ShellPkg: Fix changing to file system with 2 colons like "fs0::"

2014-02-11 Thread Carsey, Jaben 
Tim,

I don't see anything like that.  It changes the "if" block to require that the 
last character in the string be a colon, and that the first colon in the string 
must be the last character in the string.  No Unicode collation at all...

-Jaben

From: Tim Lewis [mailto:tim.le...@insyde.com]
Sent: Tuesday, February 11, 2014 3:55 PM
To: edk2-devel@lists.sourceforge.net; Bjorge, Erik C
Subject: Re: [edk2] ShellPkg: Fix changing to file system with 2 colons like 
"fs0::"

It looks like this tries to use UnicodeCollation instead of UnicodeCollation2. 
Did I read this wrong?

Tim

From: Carsey, Jaben [mailto:jaben.car...@intel.com]
Sent: Tuesday, February 11, 2014 3:38 PM
To: Bjorge, Erik C
Cc: edk2-devel@lists.sourceforge.net<mailto:edk2-devel@lists.sourceforge.net>
Subject: [edk2] ShellPkg: Fix changing to file system with 2 colons like "fs0::"

Erik,

Can you review this patch?

ShellPkg: Fix changing to file system with 2 colons like "fs0::"

Contributed-under: TianoCore Contribution Agreement 1.0
Signed-off-by: Jaben Carsey 
mailto:jaben.car...@intel.com>>
--
Android apps run on BlackBerry 10
Introducing the new BlackBerry 10.2.1 Runtime for Android apps.
Now with support for Jelly Bean, Bluetooth, Mapview and more.
Get your Android app in front of a whole new audience.  Start now.
http://pubads.g.doubleclick.net/gampad/clk?id=124407151&iu=/4140/ostg.clktrk___
edk2-devel mailing list
edk2-devel@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/edk2-devel

Re: [edk2] ShellPkg: Fix changing to file system with 2 colons like "fs0::"

2014-02-11 Thread Tim Lewis 
It looks like this tries to use UnicodeCollation instead of UnicodeCollation2. 
Did I read this wrong?

Tim

From: Carsey, Jaben [mailto:jaben.car...@intel.com]
Sent: Tuesday, February 11, 2014 3:38 PM
To: Bjorge, Erik C
Cc: edk2-devel@lists.sourceforge.net
Subject: [edk2] ShellPkg: Fix changing to file system with 2 colons like "fs0::"

Erik,

Can you review this patch?

ShellPkg: Fix changing to file system with 2 colons like "fs0::"

Contributed-under: TianoCore Contribution Agreement 1.0
Signed-off-by: Jaben Carsey 
mailto:jaben.car...@intel.com>>
--
Android apps run on BlackBerry 10
Introducing the new BlackBerry 10.2.1 Runtime for Android apps.
Now with support for Jelly Bean, Bluetooth, Mapview and more.
Get your Android app in front of a whole new audience.  Start now.
http://pubads.g.doubleclick.net/gampad/clk?id=124407151&iu=/4140/ostg.clktrk___
edk2-devel mailing list
edk2-devel@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/edk2-devel

Re: [edk2] ShellPkg: Fix changing to file system with 2 colons like "fs0::"

2014-02-11 Thread Bjorge, Erik C 
Reviewed-by: Erik Bjorge 

From: Carsey, Jaben
Sent: Tuesday, February 11, 2014 3:38 PM
To: Bjorge, Erik C
Cc: edk2-devel@lists.sourceforge.net; Carsey, Jaben
Subject: ShellPkg: Fix changing to file system with 2 colons like "fs0::"

Erik,

Can you review this patch?

ShellPkg: Fix changing to file system with 2 colons like "fs0::"

Contributed-under: TianoCore Contribution Agreement 1.0
Signed-off-by: Jaben Carsey 
mailto:jaben.car...@intel.com>>
--
Android apps run on BlackBerry 10
Introducing the new BlackBerry 10.2.1 Runtime for Android apps.
Now with support for Jelly Bean, Bluetooth, Mapview and more.
Get your Android app in front of a whole new audience.  Start now.
http://pubads.g.doubleclick.net/gampad/clk?id=124407151&iu=/4140/ostg.clktrk___
edk2-devel mailing list
edk2-devel@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/edk2-devel

[edk2] ShellPkg: Fix changing to file system with 2 colons like "fs0::"

2014-02-11 Thread Carsey, Jaben 
Erik,

Can you review this patch?

ShellPkg: Fix changing to file system with 2 colons like "fs0::"

Contributed-under: TianoCore Contribution Agreement 1.0
Signed-off-by: Jaben Carsey 
mailto:jaben.car...@intel.com>>


Shell.c.patch
Description: Shell.c.patch
--
Android apps run on BlackBerry 10
Introducing the new BlackBerry 10.2.1 Runtime for Android apps.
Now with support for Jelly Bean, Bluetooth, Mapview and more.
Get your Android app in front of a whole new audience.  Start now.
http://pubads.g.doubleclick.net/gampad/clk?id=124407151&iu=/4140/ostg.clktrk___
edk2-devel mailing list
edk2-devel@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/edk2-devel