Re: [edk2] "goto" vfrConstantValue

2014-08-26 Thread Dong, Eric
Tim,

Add my comments below.

From: Tim Lewis [mailto:tim.le...@insyde.com]
Sent: Wednesday, August 27, 2014 9:12 AM
To: edk2-devel@lists.sourceforge.net
Subject: [edk2] "goto" vfrConstantValue

It appears that the VFR specification has not been updated with the HII_REF 
default format, although it is used in the DriverSampleDxe. Can I verify the 
actual format?

Here is a sample:

  default = 0;0;ZERO_GUID;STRING_TOKEN(STR_NULL_STRING),

It appears that this is: question = 0, formid = 0, formsetguid = ZERO_GUID and 
devicepath = STRING_TOKEN(STR_NULL_STRING). Is this correct?

Then the grammar would be something like:

integer ";" integer ";" guid ";" string-token
[[[Eric]]] yes, I add one sample default code in vfr spec for goto opcod, it 
uses this style.

which differentiates it from the other constant values (like time with ':' and 
date with '/'). Correct?
[[[Eric]]] Yes, I think the ':' and '/' is special used by date and time, also 
these two opcode are not use the same style, so for goto opcode, I use ';'.

Thanks,

Tim
--
Slashdot TV.  
Video for Nerds.  Stuff that matters.
http://tv.slashdot.org/___
edk2-devel mailing list
edk2-devel@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/edk2-devel


[edk2] "goto" vfrConstantValue

2014-08-26 Thread Tim Lewis
It appears that the VFR specification has not been updated with the HII_REF 
default format, although it is used in the DriverSampleDxe. Can I verify the 
actual format?

Here is a sample:

  default = 0;0;ZERO_GUID;STRING_TOKEN(STR_NULL_STRING),

It appears that this is: question = 0, formid = 0, formsetguid = ZERO_GUID and 
devicepath = STRING_TOKEN(STR_NULL_STRING). Is this correct?

Then the grammar would be something like:

integer ";" integer ";" guid ";" string-token

which differentiates it from the other constant values (like time with ':' and 
date with '/'). Correct?

Thanks,

Tim
--
Slashdot TV.  
Video for Nerds.  Stuff that matters.
http://tv.slashdot.org/___
edk2-devel mailing list
edk2-devel@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/edk2-devel