Re: [edk2] "option" statement
Thank you, Eric. Tim From: Dong, Eric [mailto:eric.d...@intel.com] Sent: Monday, July 14, 2014 7:55 PM To: edk2-devel@lists.sourceforge.net Subject: Re: [edk2] "option" statement Tim, Add my comments below. Thanks, Eric From: Tim Lewis [mailto:tim.le...@insyde.com] Sent: Monday, July 14, 2014 10:49 AM To: edk2-devel@lists.sourceforge.net<mailto:edk2-devel@lists.sourceforge.net> Subject: [edk2] "option" statement The option statement has the following flags: oneofoptionFlagsField ::= Number | "OPTION_DEFAULT" | "OPTION_DEFAULT_MFG" | "INTERACTIVE" | "RESET_REQUIRED" | "DEFAULT" But it is not clear what the "INTERACTIVE" and "RESET_REQUIRED" flags should do. Are they OR'd together and put in the parent question? [[[Eric]]] yes, these two flags will be put in the parent question. There are many other flags in the grammar that are undocumented. For example: LATE_CHECK or NV_ACCESS. These flags values are also not defined in the UEFI specification. Is there any further definition or are these from the older Framework spec? If they are from the Framework spec, is there some way to add error checking so that they can be excluded? [[[Eric]]] Yes. LATE_CHECK or NV_ACCESS are for old framework HII. They are kept here for compatible with old VFR file, I will add check for these flags used for old framework HII and report warning info for it. oneofoptionFlagsField [UINT8 & HFlags, UINT8 & LFlags] : N:Number << $LFlags |= _STOU8(N->getText(), N->getLine()); >> | "OPTION_DEFAULT" << $LFlags |= 0x10; >> | "OPTION_DEFAULT_MFG" << $LFlags |= 0x20; >> | InteractiveFlag<< $HFlags |= 0x04; >> | NVAccessFlag << $HFlags |= 0x08; >> | ResetRequiredFlag << $HFlags |= 0x10; >> | LateCheckFlag << $HFlags |= 0x20; >> | ManufacturingFlag << $LFlags |= 0x20; >> | DefaultFlag<< $LFlags |= 0x10; >> ; -- Want fast and easy access to all the code in your enterprise? Index and search up to 200,000 lines of code with a free copy of Black Duck Code Sight - the same software that powers the world's largest code search on Ohloh, the Black Duck Open Hub! Try it now. http://p.sf.net/sfu/bds___ edk2-devel mailing list edk2-devel@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/edk2-devel
Re: [edk2] "option" statement
Tim, Add my comments below. Thanks, Eric From: Tim Lewis [mailto:tim.le...@insyde.com] Sent: Monday, July 14, 2014 10:49 AM To: edk2-devel@lists.sourceforge.net Subject: [edk2] "option" statement The option statement has the following flags: oneofoptionFlagsField ::= Number | "OPTION_DEFAULT" | "OPTION_DEFAULT_MFG" | "INTERACTIVE" | "RESET_REQUIRED" | "DEFAULT" But it is not clear what the "INTERACTIVE" and "RESET_REQUIRED" flags should do. Are they OR'd together and put in the parent question? [[[Eric]]] yes, these two flags will be put in the parent question. There are many other flags in the grammar that are undocumented. For example: LATE_CHECK or NV_ACCESS. These flags values are also not defined in the UEFI specification. Is there any further definition or are these from the older Framework spec? If they are from the Framework spec, is there some way to add error checking so that they can be excluded? [[[Eric]]] Yes. LATE_CHECK or NV_ACCESS are for old framework HII. They are kept here for compatible with old VFR file, I will add check for these flags used for old framework HII and report warning info for it. oneofoptionFlagsField [UINT8 & HFlags, UINT8 & LFlags] : N:Number << $LFlags |= _STOU8(N->getText(), N->getLine()); >> | "OPTION_DEFAULT" << $LFlags |= 0x10; >> | "OPTION_DEFAULT_MFG" << $LFlags |= 0x20; >> | InteractiveFlag<< $HFlags |= 0x04; >> | NVAccessFlag << $HFlags |= 0x08; >> | ResetRequiredFlag << $HFlags |= 0x10; >> | LateCheckFlag << $HFlags |= 0x20; >> | ManufacturingFlag << $LFlags |= 0x20; >> | DefaultFlag<< $LFlags |= 0x10; >> ; -- Want fast and easy access to all the code in your enterprise? Index and search up to 200,000 lines of code with a free copy of Black Duck Code Sight - the same software that powers the world's largest code search on Ohloh, the Black Duck Open Hub! Try it now. http://p.sf.net/sfu/bds___ edk2-devel mailing list edk2-devel@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/edk2-devel
[edk2] "option" statement
The option statement has the following flags: oneofoptionFlagsField ::= Number | "OPTION_DEFAULT" | "OPTION_DEFAULT_MFG" | "INTERACTIVE" | "RESET_REQUIRED" | "DEFAULT" But it is not clear what the "INTERACTIVE" and "RESET_REQUIRED" flags should do. Are they OR'd together and put in the parent question? There are many other flags in the grammar that are undocumented. For example: LATE_CHECK or NV_ACCESS. These flags values are also not defined in the UEFI specification. Is there any further definition or are these from the older Framework spec? If they are from the Framework spec, is there some way to add error checking so that they can be excluded? oneofoptionFlagsField [UINT8 & HFlags, UINT8 & LFlags] : N:Number << $LFlags |= _STOU8(N->getText(), N->getLine()); >> | "OPTION_DEFAULT" << $LFlags |= 0x10; >> | "OPTION_DEFAULT_MFG" << $LFlags |= 0x20; >> | InteractiveFlag<< $HFlags |= 0x04; >> | NVAccessFlag << $HFlags |= 0x08; >> | ResetRequiredFlag << $HFlags |= 0x10; >> | LateCheckFlag << $HFlags |= 0x20; >> | ManufacturingFlag << $LFlags |= 0x20; >> | DefaultFlag<< $LFlags |= 0x10; >> ; -- Want fast and easy access to all the code in your enterprise? Index and search up to 200,000 lines of code with a free copy of Black Duck® Code Sight™ - the same software that powers the world's largest code search on Ohloh, the Black Duck Open Hub! Try it now. http://p.sf.net/sfu/bds___ edk2-devel mailing list edk2-devel@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/edk2-devel
