Re: Marvel Sense GET/POST

2015-01-05 Thread Mark Walkom
I've since been informed this is a known issue and a bug has been raised
for it, so a fix is on the way.

On 6 January 2015 at 07:57, Mark Walkom  wrote:

> It'd be great if you could raise this as an issue on github for this
> behaviour to be checked - https://github.com/elasticsearch/elasticsearch
>
> On 6 January 2015 at 00:06, Paul Scott  wrote:
>
>> Regarding the behaviour of Sense to automatically choose POST regardless
>> of the user writing GET:
>>
>> I was recently rewriting a search query I had written in the Sense UI
>> from a search query to a request for a raw document by ID, using the GET
>> API. In the process of changing from
>>
>> GET /index/type/_search
>> { ... }
>>
>>
>> to
>>
>> GET /index/type/id
>>
>>
>> I submitted
>>
>> GET /index/type/id
>> {... }
>>
>>
>> which Sense helpfully submitted as a POST request, over-writing the
>> document with the search query. In production.
>>
>> To say that this behaviour was unexpected and unhelpful would be an
>> understatement. I would consider it irresponsible and unsafe, and I highly
>> recommend the behaviour be disabled.
>>
>> Please try to read past my obvious irritation and the part of this
>> mistake which falls on my head, to the part in this mistake that the Sense
>> UI played too.
>>
>> All the best,
>>
>> Paul
>>
>> --
>> You received this message because you are subscribed to the Google Groups
>> "elasticsearch" group.
>> To unsubscribe from this group and stop receiving emails from it, send an
>> email to elasticsearch+unsubscr...@googlegroups.com.
>> To view this discussion on the web visit
>> https://groups.google.com/d/msgid/elasticsearch/f2588751-a008-4b59-9041-b63c098580dd%40googlegroups.com
>> 
>> .
>> For more options, visit https://groups.google.com/d/optout.
>>
>
>

-- 
You received this message because you are subscribed to the Google Groups 
"elasticsearch" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to elasticsearch+unsubscr...@googlegroups.com.
To view this discussion on the web visit 
https://groups.google.com/d/msgid/elasticsearch/CAEYi1X-Fxju8SodKDp_LuaK8WXfQuLjtgK2RGD%3DbOkQ2wTi9iQ%40mail.gmail.com.
For more options, visit https://groups.google.com/d/optout.


Re: Marvel Sense GET/POST

2015-01-05 Thread Boaz Leskes
Heya,

Yeah, I agree this is annoying and dangerous. For what it's worth , this 
happens now is that browsers do not allow sending GETs with a body so Sense 
allows you to use the GET syntax as documented but sends it as POST (which 
is accepted by ES). The plan is to change and do this only for while listed 
end points (ala _search). We already have an issue for it. I'll report here 
what it's done.

Cheers,
Boaz

On Monday, January 5, 2015 9:57:41 PM UTC+1, Mark Walkom wrote:
>
> It'd be great if you could raise this as an issue on github for this 
> behaviour to be checked - https://github.com/elasticsearch/elasticsearch
>
> On 6 January 2015 at 00:06, Paul Scott  wrote:
>
>> Regarding the behaviour of Sense to automatically choose POST regardless 
>> of the user writing GET:
>>
>> I was recently rewriting a search query I had written in the Sense UI 
>> from a search query to a request for a raw document by ID, using the GET 
>> API. In the process of changing from
>>
>> GET /index/type/_search
>> { ... }
>>
>>
>> to
>>
>> GET /index/type/id
>>
>>
>> I submitted
>>
>> GET /index/type/id
>> {... }
>>
>>
>> which Sense helpfully submitted as a POST request, over-writing the 
>> document with the search query. In production.
>>
>> To say that this behaviour was unexpected and unhelpful would be an 
>> understatement. I would consider it irresponsible and unsafe, and I highly 
>> recommend the behaviour be disabled.
>>
>> Please try to read past my obvious irritation and the part of this 
>> mistake which falls on my head, to the part in this mistake that the Sense 
>> UI played too.
>>
>> All the best,
>>
>> Paul
>>
>> -- 
>> You received this message because you are subscribed to the Google Groups 
>> "elasticsearch" group.
>> To unsubscribe from this group and stop receiving emails from it, send an 
>> email to elasticsearch+unsubscr...@googlegroups.com.
>> To view this discussion on the web visit 
>> https://groups.google.com/d/msgid/elasticsearch/f2588751-a008-4b59-9041-b63c098580dd%40googlegroups.com
>>  
>> 
>> .
>> For more options, visit https://groups.google.com/d/optout.
>>
>
>

-- 
You received this message because you are subscribed to the Google Groups 
"elasticsearch" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to elasticsearch+unsubscr...@googlegroups.com.
To view this discussion on the web visit 
https://groups.google.com/d/msgid/elasticsearch/06de9586-41f1-4b5e-bce8-fe258dc93574%40googlegroups.com.
For more options, visit https://groups.google.com/d/optout.


Re: Marvel Sense GET/POST

2015-01-05 Thread Mark Walkom
It'd be great if you could raise this as an issue on github for this
behaviour to be checked - https://github.com/elasticsearch/elasticsearch

On 6 January 2015 at 00:06, Paul Scott  wrote:

> Regarding the behaviour of Sense to automatically choose POST regardless
> of the user writing GET:
>
> I was recently rewriting a search query I had written in the Sense UI from
> a search query to a request for a raw document by ID, using the GET API. In
> the process of changing from
>
> GET /index/type/_search
> { ... }
>
>
> to
>
> GET /index/type/id
>
>
> I submitted
>
> GET /index/type/id
> {... }
>
>
> which Sense helpfully submitted as a POST request, over-writing the
> document with the search query. In production.
>
> To say that this behaviour was unexpected and unhelpful would be an
> understatement. I would consider it irresponsible and unsafe, and I highly
> recommend the behaviour be disabled.
>
> Please try to read past my obvious irritation and the part of this mistake
> which falls on my head, to the part in this mistake that the Sense UI
> played too.
>
> All the best,
>
> Paul
>
> --
> You received this message because you are subscribed to the Google Groups
> "elasticsearch" group.
> To unsubscribe from this group and stop receiving emails from it, send an
> email to elasticsearch+unsubscr...@googlegroups.com.
> To view this discussion on the web visit
> https://groups.google.com/d/msgid/elasticsearch/f2588751-a008-4b59-9041-b63c098580dd%40googlegroups.com
> 
> .
> For more options, visit https://groups.google.com/d/optout.
>

-- 
You received this message because you are subscribed to the Google Groups 
"elasticsearch" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to elasticsearch+unsubscr...@googlegroups.com.
To view this discussion on the web visit 
https://groups.google.com/d/msgid/elasticsearch/CAEYi1X_GammQv_kpXTGG6Cv9cGSjfyWOFaUf4Ln6bdLPewGM6w%40mail.gmail.com.
For more options, visit https://groups.google.com/d/optout.


Marvel Sense GET/POST

2015-01-05 Thread Paul Scott
Regarding the behaviour of Sense to automatically choose POST regardless of 
the user writing GET:

I was recently rewriting a search query I had written in the Sense UI from 
a search query to a request for a raw document by ID, using the GET API. In 
the process of changing from

GET /index/type/_search
{ ... }


to

GET /index/type/id


I submitted

GET /index/type/id
{... }


which Sense helpfully submitted as a POST request, over-writing the 
document with the search query. In production.

To say that this behaviour was unexpected and unhelpful would be an 
understatement. I would consider it irresponsible and unsafe, and I highly 
recommend the behaviour be disabled.

Please try to read past my obvious irritation and the part of this mistake 
which falls on my head, to the part in this mistake that the Sense UI 
played too.

All the best,

Paul

-- 
You received this message because you are subscribed to the Google Groups 
"elasticsearch" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to elasticsearch+unsubscr...@googlegroups.com.
To view this discussion on the web visit 
https://groups.google.com/d/msgid/elasticsearch/f2588751-a008-4b59-9041-b63c098580dd%40googlegroups.com.
For more options, visit https://groups.google.com/d/optout.