On Tue, May 17, 2005 at 09:33:09PM -0000, [EMAIL PROTECTED] wrote: > This is an automated notification of a change to the ELinks CVS tree. > > Author: zas > Module: elinks > Tag: <TRUNK> > Date: Tue May 17 21:33:09 2005 GMT > > ---- Log message: > > Pass struct term_event_keyboard * to delete_keybinding(), add_keybinding() > and kbd_ev_lookup(). > > > ---- Files affected: > > elinks/src/config: > dialogs.c (1.222 -> 1.223) > > http://cvsweb.elinks.or.cz/cvsweb.cgi/elinks/src/config/dialogs.c.diff?r1=1.222&r2=1.223&f=u > kbdbind.c (1.284 -> 1.285) > > http://cvsweb.elinks.or.cz/cvsweb.cgi/elinks/src/config/kbdbind.c.diff?r1=1.284&r2=1.285&f=u > kbdbind.h (1.151 -> 1.152) > > http://cvsweb.elinks.or.cz/cvsweb.cgi/elinks/src/config/kbdbind.h.diff?r1=1.151&r2=1.152&f=u > > > ---- Diffs: > > elinks/src/config/dialogs.c | 3 -- > elinks/src/config/kbdbind.c | 38 ++++++++++++++++++------------------ > elinks/src/config/kbdbind.h | 4 +-- > 3 files changed, 23 insertions(+), 22 deletions(-) > > > Index: elinks/src/config/dialogs.c [...] > Index: elinks/src/config/kbdbind.c [...] > @@ -143,24 +143,27 @@ > int > kbd_action(enum keymap kmap, struct term_event *ev, int *event) > { > + struct term_event_keyboard kbd; > struct keybinding *kb; > > if (ev->ev != EVENT_KBD) return -1; > > - kb = kbd_ev_lookup(kmap, get_kbd_key(ev), get_kbd_modifier(ev), event); > + kbd.key = get_kbd_key(ev); > + kbd.modifier = get_kbd_modifier(ev); > + kb = kbd_ev_lookup(kmap, &kbd, event); > return kb ? kb->action : -1; > } > [...] > Index: elinks/src/config/kbdbind.h [...]
Why not pass &ev->info.keyboard to kbd_ev_lookup? If there is a good reason, a comment is in order. -- Miciah Masters <[EMAIL PROTECTED]> / <[EMAIL PROTECTED]> _______________________________________________ elinks-dev mailing list elinks-dev@linuxfromscratch.org http://linuxfromscratch.org/mailman/listinfo/elinks-dev
