Re: [elinks-dev] Re: UTF-8 decoding changes for handle_interlink_event

[Jonas Fonseca]

Kalle Olavi Niemitalo <[EMAIL PROTECTED]> wrote Sun, Aug 27, 2006:
> Jonas Fonseca <[EMAIL PROTECTED]> writes:
> 
> >  - You indented the goto label in the first commit (e333fb37) and
> >normally labels should not be indented.
> 
> Oops.  I see that's in doc/hacking.txt too.  I guess I'll have to
> configure Emacs to use a custom indentation style for ELinks code.

It's not a big deal. It would be better not to use goto at all. ;)

> >  - I don't seem to remember the introduction of is_utf16_surrogate()
> >used in the second commit (be7526d0). Did you forgot to add
> >intl/charset.h to the file commit list?
> 
> I added is_utf16_surrogate in commit 38fe5b72 aka be7526d0~2,
> "Define and use macros for handling UTF-16 surrogates."
> I typically commit a whole tree, rather than individual files.

Ok, sorry for the noise then.

-- 
Jonas Fonseca
___
elinks-dev mailing list
elinks-dev@linuxfromscratch.org
http://linuxfromscratch.org/mailman/listinfo/elinks-dev

[elinks-dev] Re: UTF-8 decoding changes for handle_interlink_event

[Kalle Olavi Niemitalo]

Jonas Fonseca <[EMAIL PROTECTED]> writes:

>  - You indented the goto label in the first commit (e333fb37) and
>normally labels should not be indented.

Oops.  I see that's in doc/hacking.txt too.  I guess I'll have to
configure Emacs to use a custom indentation style for ELinks code.

>  - I don't seem to remember the introduction of is_utf16_surrogate()
>used in the second commit (be7526d0). Did you forgot to add
>intl/charset.h to the file commit list?

I added is_utf16_surrogate in commit 38fe5b72 aka be7526d0~2,
"Define and use macros for handling UTF-16 surrogates."
I typically commit a whole tree, rather than individual files.


pgplmyRpRFn3s.pgp
Description: PGP signature
___
elinks-dev mailing list
elinks-dev@linuxfromscratch.org
http://linuxfromscratch.org/mailman/listinfo/elinks-dev

Re: [elinks-dev] Re: UTF-8 decoding changes for handle_interlink_event

[Jonas Fonseca]

Kalle Olavi Niemitalo <[EMAIL PROTECTED]> wrote Fri, Aug 25, 2006:
> Kalle Olavi Niemitalo <[EMAIL PROTECTED]> writes:
> 
> > I'd like to merge 
> > to the main repository.
> 
> I have now committed patches that have a similar effect.

Two things:

 - You indented the goto label in the first commit (e333fb37) and
   normally labels should not be indented.

 - I don't seem to remember the introduction of is_utf16_surrogate()
   used in the second commit (be7526d0). Did you forgot to add
   intl/charset.h to the file commit list?

-- 
Jonas Fonseca
___
elinks-dev mailing list
elinks-dev@linuxfromscratch.org
http://linuxfromscratch.org/mailman/listinfo/elinks-dev

[elinks-dev] Re: UTF-8 decoding changes for handle_interlink_event

[Kalle Olavi Niemitalo]

Kalle Olavi Niemitalo <[EMAIL PROTECTED]> writes:

> I'd like to merge 
> to the main repository.

I have now committed patches that have a similar effect.


pgpSxhRKhVSur.pgp
Description: PGP signature
___
elinks-dev mailing list
elinks-dev@linuxfromscratch.org
http://linuxfromscratch.org/mailman/listinfo/elinks-dev