[elinks-users] [PATCH] bug 153, 1066: Fix search in bookmark manager.
test_search() was supposed to compare bookmark titles with
strcasestr(), but in commit 311d95358de258656a0c7145a2dcff943fcdcd4b
"bug 153, 1066: Convert bookmarks to/from UTF-8 when searching."
on 2009-02-08, I inadvertently changed that to strcasecmp(), even
while adding a comment about why strcasestr() is needed. strcasestr()
returns non-NULL if the strings match, and strcasecmp() returns
nonzero if they differ, so the search didn't work at all.
---
Stephen Stocker writes:
>Since sometime before Feb 14, 2009, the bookmark search feature seems to
> be
> broken in the daily snapshots. If I hit "s" to display the bookmarks dialog,
> then "s" again to search, and type in whatever I'm looking for, it moves to
> the
> next item in the bookmarks. Searching again moves it ahead one item again,
> and
> so on. In other words, everything appears to match the search.
Thanks for reporting this. It was my fault.
I have pushed the following fix to elinks-0.12 now.
It can be cleanly merged to master. I didn't push the merge.
src/bookmarks/dialogs.c |4 ++--
1 files changed, 2 insertions(+), 2 deletions(-)
diff --git a/src/bookmarks/dialogs.c b/src/bookmarks/dialogs.c
index 69340b1..b20815c 100644
--- a/src/bookmarks/dialogs.c
+++ b/src/bookmarks/dialogs.c
@@ -687,8 +687,8 @@ test_search(struct listbox_item *item, void *data_, int
*offset)
}
if (title) {
- ctx->found = strcasecmp(title,
- ctx->title);
+ ctx->found = (strcasestr(title, ctx->title)
+ != NULL);
mem_free(title);
}
/** @todo Tell the user that the string could
--
1.6.0.6.4.g22c5
___
elinks-users mailing list
elinks-users@linuxfromscratch.org
http://linuxfromscratch.org/mailman/listinfo/elinks-users
[elinks-users] Searching in bookmarks broken (Experimental git snapshot)
Hi, Since sometime before Feb 14, 2009, the bookmark search feature seems to be broken in the daily snapshots. If I hit "s" to display the bookmarks dialog, then "s" again to search, and type in whatever I'm looking for, it moves to the next item in the bookmarks. Searching again moves it ahead one item again, and so on. In other words, everything appears to match the search. Any help would be greatly appreciated. Steve -- Hope, Despair and the Triumph of Life http://www.hdtl.org Abuse Prevention/Survivor Support ___ elinks-users mailing list elinks-users@linuxfromscratch.org http://linuxfromscratch.org/mailman/listinfo/elinks-users
Re: [elinks-users] Searching in bookmarks broken (Experimental git snapshot)
On Sat, Feb 28, 2009 at 07:43:41PM -0600, Stephen Stocker wrote: >Since sometime before Feb 14, 2009, the bookmark search feature seems to > be > broken in the daily snapshots. If I hit "s" to display the bookmarks dialog, > then "s" again to search, and type in whatever I'm looking for, it moves to > the > next item in the bookmarks. Searching again moves it ahead one item again, > and > so on. In other words, everything appears to match the search. ---end quoted text--- I confirm this issue too. -- أحمد المحمودي (Ahmed El-Mahmoudy) Digital design engineer GPG KeyID: 0x9DCA0B27 (@ subkeys.pgp.net) GPG Fingerprint: 087D 3767 8CAC 65B1 8F6C 156E D325 C3C8 9DCA 0B27 ___ elinks-users mailing list elinks-users@linuxfromscratch.org http://linuxfromscratch.org/mailman/listinfo/elinks-users
[elinks-users] Searching in bookmarks broken (Experimental git snapshot)
Hi, Since sometime before Feb 14, 2009, the bookmark search feature seems to be broken in the daily snapshots. If I hit "s" to display the bookmarks dialog, then "s" again to search, and type in whatever I'm looking for, it moves to the next item in the bookmarks. Searching again moves it ahead one item again, and so on. In other words, everything appears to match the search. Any help would be greatly appreciated. Steve -- Hope, Despair and the Triumph of Life http://www.hdtl.org Abuse Prevention/Survivor Support ___ elinks-users mailing list elinks-users@linuxfromscratch.org http://linuxfromscratch.org/mailman/listinfo/elinks-users
Re: [elinks-users] Rendering of google news.
On Sat, Feb 28, 2009 at 07:23:12PM EST, Miciah Dashiel Butler Masters wrote: > On 02/28/2009 07:11 PM, Chris Jones wrote: > > On October 10, 2007 I was using ELinks to visit http://news.google.de > > [...] > > 1. Are you folks seeing the same thing? > > What I get looks like your second screenshot; in particular, there is > little colour and there are only 2 columns. At least it's not just "me". > > 2. Do you know why this is happening? > > Google News probably recently switched from a table-based layout to a > CSS-based layout. > > > 3. Is there a workaround? > > ELinks needs much better support for the CSS box model. Implementing > such is a difficult task at which various developers have made several > aborted attempts throughout the history of ELinks. Sad news. It looks like one web site at a time our great browser is falling behind the times and that eventually there will be nothing left. Wish I had the skills to do something about it. Thanks, CJ ___ elinks-users mailing list elinks-users@linuxfromscratch.org http://linuxfromscratch.org/mailman/listinfo/elinks-users
Re: [elinks-users] Rendering of google news.
On 02/28/2009 07:11 PM, Chris Jones wrote: > On October 10, 2007 I was using ELinks to visit http://news.google.de > [...] > 1. Are you folks seeing the same thing? What I get looks like your second screenshot; in particular, there is little colour and there are only 2 columns. > 2. Do you know why this is happening? Google News probably recently switched from a table-based layout to a CSS-based layout. > 3. Is there a workaround? ELinks needs much better support for the CSS box model. Implementing such is a difficult task at which various developers have made several aborted attempts throughout the history of ELinks. -- Miciah Masters / ___ elinks-users mailing list elinks-users@linuxfromscratch.org http://linuxfromscratch.org/mailman/listinfo/elinks-users
Re: [elinks-users] Rendering of google news.
On Sat, Feb 28, 2009 at 05:29:45PM EST, Thomas Adam wrote: > Any chance you can actually provide some information as to your > problem? I don't like to play "spot the difference". Hmm.. I thought the screenshots were self-explanatory and would cut down on the verbiage. On October 10, 2007 I was using ELinks to visit http://news.google.de and I happened to take a screen dump. The rendering was pretty close to the mozilla foundation's offering's. I visit this particular page and a number of other news.google pages on a daily basis and I noticed a few days ago .. at about the time of the google webmail incident, IIRC .. that the rendering provided by ELinks had changed completely and is now very different from the one provided by seamonkey. The second screenshot "elinks9.png" was taken today, February 28, 2009 to document what I am now seeing. Since I have not changed anything in my ELinks setup or upgraded to a more recent version of ELinks in ages, I suspect that google must have changed something. Questions: 1. Are you folks seeing the same thing? 2. Do you know why this is happening? 3. Is there a workaround? Thanks, CJ ___ elinks-users mailing list elinks-users@linuxfromscratch.org http://linuxfromscratch.org/mailman/listinfo/elinks-users
Re: [elinks-users] Rendering of google news.
2009/2/28 Chris Jones : > Two screenshots of http://news.google.de > > http://www.geocities.com/fcky1000/fckz/elinks0.png - 10/28/07 This is the one which looks "correct". yes? > http://www.geocities.com/fcky1000/fckz/elinks9.png - 02/28/09 And this one isn't, I assume? > Any way I can work around this? Any chance you can actually provide some information as to your problem? I don't like to play "spot the difference". -- Thomas Adam ___ elinks-users mailing list elinks-users@linuxfromscratch.org http://linuxfromscratch.org/mailman/listinfo/elinks-users
[elinks-users] Rendering of google news.
Two screenshots of http://news.google.de http://www.geocities.com/fcky1000/fckz/elinks0.png - 10/28/07 http://www.geocities.com/fcky1000/fckz/elinks9.png - 02/28/09 Any way I can work around this? Thanks, CJ ___ elinks-users mailing list elinks-users@linuxfromscratch.org http://linuxfromscratch.org/mailman/listinfo/elinks-users
