[elixir-core:6080] Keyword module remains mostly untested

[Eugene Pirogov]

Hi all,

I've noticed that Keyword module, despite having > 30 public methods has 
only 4 tests – 
https://github.com/elixir-lang/elixir/blob/master/lib/elixir/test/elixir/keyword_test.exs.
 
Is this on purpose, like testing public functions would be superfluous for 
some reason (although I can't think of one)? If not, would it be OK if to 
start covering the module's publicly exported functions with tests?

-- 
You received this message because you are subscribed to the Google Groups 
"elixir-lang-core" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to elixir-lang-core+unsubscr...@googlegroups.com.
To view this discussion on the web visit 
https://groups.google.com/d/msgid/elixir-lang-core/224f0572-9806-4185-afe9-9cc1102790d2%40googlegroups.com.
For more options, visit https://groups.google.com/d/optout.

Re: [elixir-core:6080] Keyword module remains mostly untested

[José Valim]

All of the functionality is covered via doctests.

On Monday, July 11, 2016, Eugene Pirogov  wrote:

> Hi all,
>
> I've noticed that Keyword module, despite having > 30 public methods has
> only 4 tests –
> https://github.com/elixir-lang/elixir/blob/master/lib/elixir/test/elixir/keyword_test.exs.
> Is this on purpose, like testing public functions would be superfluous for
> some reason (although I can't think of one)? If not, would it be OK if to
> start covering the module's publicly exported functions with tests?
>
> --
> You received this message because you are subscribed to the Google Groups
> "elixir-lang-core" group.
> To unsubscribe from this group and stop receiving emails from it, send an
> email to elixir-lang-core+unsubscr...@googlegroups.com
> 
> .
> To view this discussion on the web visit
> https://groups.google.com/d/msgid/elixir-lang-core/224f0572-9806-4185-afe9-9cc1102790d2%40googlegroups.com
> 
> .
> For more options, visit https://groups.google.com/d/optout.
>


-- 


*José Valim*
www.plataformatec.com.br
Skype: jv.ptec
Founder and Director of R&D

-- 
You received this message because you are subscribed to the Google Groups 
"elixir-lang-core" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to elixir-lang-core+unsubscr...@googlegroups.com.
To view this discussion on the web visit 
https://groups.google.com/d/msgid/elixir-lang-core/CAGnRm4LLtA10Ab-QwoD2S%3DFVN7wTkjWw_V5%2BUo%2Bfvgni8DN%3DmQ%40mail.gmail.com.
For more options, visit https://groups.google.com/d/optout.

[elixir-core:6082] Re: How to manage conflicts with duplicate dependencies (the same module gets defined twice)

[Bartosz Kalinowski]

On Wednesday, July 6, 2016 at 9:16:27 AM UTC+2, Bartosz Kalinowski wrote:
>
> I've started a question on SO about my problem so I won't go into much 
> details here. In general I have trouble with the same module getting 
> defined twice in dependent projects. 
> Please check it out:
>
>
> http://stackoverflow.com/questions/38213089/duplicate-protocol-implementations-in-dependent-projects
>
> For me it seems like a bigger issue with dependencies. Is there some way I 
> could solve this from my code side (like not modifying dependencies)?
> Also I am able to modify one of them (not Ecto obviously) but what would 
> be the best practice here? To avoid having the same module defined twice
>
> Regards
>

-- 
You received this message because you are subscribed to the Google Groups 
"elixir-lang-core" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to elixir-lang-core+unsubscr...@googlegroups.com.
To view this discussion on the web visit 
https://groups.google.com/d/msgid/elixir-lang-core/276744e6-00b7-460a-9ca0-4dd14537c52b%40googlegroups.com.
For more options, visit https://groups.google.com/d/optout.

[elixir-core:6082] Re: How to manage conflicts with duplicate dependencies (the same module gets defined twice)

[Bartosz Kalinowski]

Hey guys, I've started bounty on this question as I think it really should 
get more love and deserves some ideas how to solve the problem with 
implementing Protocols for the same other types in different projects. 
Please give it some thoughts! :)

-- 
You received this message because you are subscribed to the Google Groups 
"elixir-lang-core" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to elixir-lang-core+unsubscr...@googlegroups.com.
To view this discussion on the web visit 
https://groups.google.com/d/msgid/elixir-lang-core/66526ba1-f518-4181-a5df-538da7921545%40googlegroups.com.
For more options, visit https://groups.google.com/d/optout.

[elixir-core:6083] Maybe Add A Warning For Including Commas In ~w List

[Henrik N]

Is there precedent for warnings in Elixir about things that could be a mistake 
but could also be a valid use case?

-- 
You received this message because you are subscribed to the Google Groups 
"elixir-lang-core" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to elixir-lang-core+unsubscr...@googlegroups.com.
To view this discussion on the web visit 
https://groups.google.com/d/msgid/elixir-lang-core/77dc7cd3-07b4-4ef1-8dfa-587587feb0ee%40googlegroups.com.
For more options, visit https://groups.google.com/d/optout.

Re: [elixir-core:6083] Maybe Add A Warning For Including Commas In ~w List

[Onorio Catenacci]

That is sort of the definition of "warning". If it were obviously wrong it 
would be a compiler error.

Henrik N  wrote:
>Is there precedent for warnings in Elixir about things that could be a mistake 
>but could also be a valid use case?
>
>-- 
>You received this message because you are subscribed to a topic in the Google 
>Groups "elixir-lang-core" group.
>To unsubscribe from this topic, visit 
>https://groups.google.com/d/topic/elixir-lang-core/tmAESH8Nhz8/unsubscribe.
>To unsubscribe from this group and all its topics, send an email to 
>elixir-lang-core+unsubscr...@googlegroups.com.
>To view this discussion on the web visit 
>https://groups.google.com/d/msgid/elixir-lang-core/77dc7cd3-07b4-4ef1-8dfa-587587feb0ee%40googlegroups.com.
>For more options, visit https://groups.google.com/d/optout.

-- 
You received this message because you are subscribed to the Google Groups 
"elixir-lang-core" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to elixir-lang-core+unsubscr...@googlegroups.com.
To view this discussion on the web visit 
https://groups.google.com/d/msgid/elixir-lang-core/xmbipso4kehogg28mex2s1j3.1468280949540%40email.android.com.
For more options, visit https://groups.google.com/d/optout.

Re: [elixir-core:6084] Maybe Add A Warning For Including Commas In ~w List

[Louis Pilfold]

Hey

How would I silence the warnings emitted when I have deliberate commas in a
w sigil?

Cheers,
Louis
On 12 Jul 2016 00:49, "Onorio Catenacci"  wrote:

> That is sort of the definition of "warning". If it were obviously wrong it
> would be a compiler error.
>
> Henrik N  wrote:
> >Is there precedent for warnings in Elixir about things that could be a
> mistake but could also be a valid use case?
> >
> >--
> >You received this message because you are subscribed to a topic in the
> Google Groups "elixir-lang-core" group.
> >To unsubscribe from this topic, visit
> https://groups.google.com/d/topic/elixir-lang-core/tmAESH8Nhz8/unsubscribe
> .
> >To unsubscribe from this group and all its topics, send an email to
> elixir-lang-core+unsubscr...@googlegroups.com.
> >To view this discussion on the web visit
> https://groups.google.com/d/msgid/elixir-lang-core/77dc7cd3-07b4-4ef1-8dfa-587587feb0ee%40googlegroups.com
> .
> >For more options, visit https://groups.google.com/d/optout.
>
> --
> You received this message because you are subscribed to the Google Groups
> "elixir-lang-core" group.
> To unsubscribe from this group and stop receiving emails from it, send an
> email to elixir-lang-core+unsubscr...@googlegroups.com.
> To view this discussion on the web visit
> https://groups.google.com/d/msgid/elixir-lang-core/xmbipso4kehogg28mex2s1j3.1468280949540%40email.android.com
> .
> For more options, visit https://groups.google.com/d/optout.
>

-- 
You received this message because you are subscribed to the Google Groups 
"elixir-lang-core" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to elixir-lang-core+unsubscr...@googlegroups.com.
To view this discussion on the web visit 
https://groups.google.com/d/msgid/elixir-lang-core/CAM-pwt5jjqbCNoYU%3DZkDuBMWcU7SwpuwpY7rwn_VBcjEMAUOGQ%40mail.gmail.com.
For more options, visit https://groups.google.com/d/optout.

Re: [elixir-core:6085] Maybe Add A Warning For Including Commas In ~w List

[Onorio Catenacci]

That is part of the discussion.

I am not probably as familiar with the use cases of sigil as others might
be but I get the impression that including commas in a ~w sigil is probably
a pretty rare use case. And we are discussing a _warning_ not an error.

On Mon, Jul 11, 2016, 8:03 PM Louis Pilfold  wrote:

> Hey
>
> How would I silence the warnings emitted when I have deliberate commas in
> a w sigil?
>
> Cheers,
> Louis
> On 12 Jul 2016 00:49, "Onorio Catenacci"  wrote:
>
>> That is sort of the definition of "warning". If it were obviously wrong
>> it would be a compiler error.
>>
>> Henrik N  wrote:
>> >Is there precedent for warnings in Elixir about things that could be a
>> mistake but could also be a valid use case?
>> >
>> >--
>> >You received this message because you are subscribed to a topic in the
>> Google Groups "elixir-lang-core" group.
>> >To unsubscribe from this topic, visit
>> https://groups.google.com/d/topic/elixir-lang-core/tmAESH8Nhz8/unsubscribe
>> .
>> >To unsubscribe from this group and all its topics, send an email to
>> elixir-lang-core+unsubscr...@googlegroups.com.
>> >To view this discussion on the web visit
>> https://groups.google.com/d/msgid/elixir-lang-core/77dc7cd3-07b4-4ef1-8dfa-587587feb0ee%40googlegroups.com
>> .
>> >For more options, visit https://groups.google.com/d/optout.
>>
>> --
>>
> You received this message because you are subscribed to the Google Groups
>> "elixir-lang-core" group.
>> To unsubscribe from this group and stop receiving emails from it, send an
>> email to elixir-lang-core+unsubscr...@googlegroups.com.
>> To view this discussion on the web visit
>> https://groups.google.com/d/msgid/elixir-lang-core/xmbipso4kehogg28mex2s1j3.1468280949540%40email.android.com
>> .
>
>
>> For more options, visit https://groups.google.com/d/optout.
>>
> --
> You received this message because you are subscribed to a topic in the
> Google Groups "elixir-lang-core" group.
> To unsubscribe from this topic, visit
> https://groups.google.com/d/topic/elixir-lang-core/tmAESH8Nhz8/unsubscribe
> .
> To unsubscribe from this group and all its topics, send an email to
> elixir-lang-core+unsubscr...@googlegroups.com.
> To view this discussion on the web visit
> https://groups.google.com/d/msgid/elixir-lang-core/CAM-pwt5jjqbCNoYU%3DZkDuBMWcU7SwpuwpY7rwn_VBcjEMAUOGQ%40mail.gmail.com
> 
> .
> For more options, visit https://groups.google.com/d/optout.
>

-- 
You received this message because you are subscribed to the Google Groups 
"elixir-lang-core" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to elixir-lang-core+unsubscr...@googlegroups.com.
To view this discussion on the web visit 
https://groups.google.com/d/msgid/elixir-lang-core/CAP%3DvNq-VnDMLtZ-5w10shHvxtKeBnn-awZK-tBheeFPcaqrSJw%40mail.gmail.com.
For more options, visit https://groups.google.com/d/optout.

Re: [elixir-core:6086] Maybe Add A Warning For Including Commas In ~w List

[Henrik Nyh]

I ask because the ones I can think of (unused variables, assignment in 
conditional) are such that if you heed the warning, the behaviour of your code 
won't change. So there's never (?) a case where you can't just do what it says 
to get rid of it, without breaking your code.

Whereas heeding this warning would break any code with intended commas in that 
sigil, requiring it to be rewritten without the sigil. Though I guess that 
could be part of the message: "… If the commas are intended, use this other 
construct instead". (I don't like that idea, though.)

Sent from my iPhone

> On 12 Jul 2016, at 00:49, Onorio Catenacci  wrote:
> 
> That is sort of the definition of "warning". If it were obviously wrong it 
> would be a compiler error.
> 
> Henrik N  wrote:
>> Is there precedent for warnings in Elixir about things that could be a 
>> mistake but could also be a valid use case?
>> 
>> -- 
>> You received this message because you are subscribed to a topic in the 
>> Google Groups "elixir-lang-core" group.
>> To unsubscribe from this topic, visit 
>> https://groups.google.com/d/topic/elixir-lang-core/tmAESH8Nhz8/unsubscribe.
>> To unsubscribe from this group and all its topics, send an email to 
>> elixir-lang-core+unsubscr...@googlegroups.com.
>> To view this discussion on the web visit 
>> https://groups.google.com/d/msgid/elixir-lang-core/77dc7cd3-07b4-4ef1-8dfa-587587feb0ee%40googlegroups.com.
>> For more options, visit https://groups.google.com/d/optout.
> 
> -- 
> You received this message because you are subscribed to a topic in the Google 
> Groups "elixir-lang-core" group.
> To unsubscribe from this topic, visit 
> https://groups.google.com/d/topic/elixir-lang-core/tmAESH8Nhz8/unsubscribe.
> To unsubscribe from this group and all its topics, send an email to 
> elixir-lang-core+unsubscr...@googlegroups.com.
> To view this discussion on the web visit 
> https://groups.google.com/d/msgid/elixir-lang-core/xmbipso4kehogg28mex2s1j3.1468280949540%40email.android.com.
> For more options, visit https://groups.google.com/d/optout.

-- 
You received this message because you are subscribed to the Google Groups 
"elixir-lang-core" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to elixir-lang-core+unsubscr...@googlegroups.com.
To view this discussion on the web visit 
https://groups.google.com/d/msgid/elixir-lang-core/9A59F3CC-4BA4-4A9D-80B4-9A1B62E6E72E%40nyh.se.
For more options, visit https://groups.google.com/d/optout.