[elixir-core:9280] Normalize compile errors and warnings

2019-11-26 Thread Mijail Rondon
Hello Elixir Core,

Currently we have different ways to display errors or warnings during 
compile time, we should normalize the output.

For example, warnings are displayed as:

warning: unused alias Stream
  lib/actions_sample.ex:2

and compile errors as:

** (SyntaxError) lib/actions_sample.ex:15: unexpectedly reached end of 
line. ...

So, no problem with compile errors but warnings should have the same format 
as:

** (Warning) lib/actions_sample.ex:2: unused alias Stream

The main reason to make this change is because in CI we have the ability of 
catch those warnings or errors 
and add annotations on specific lines of the corresponding files. 

If we normalize the warnings this will be possible to add annotations of 
warnings to.

-- 
You received this message because you are subscribed to the Google Groups 
"elixir-lang-core" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to elixir-lang-core+unsubscr...@googlegroups.com.
To view this discussion on the web visit 
https://groups.google.com/d/msgid/elixir-lang-core/438ab67c-93c7-4de6-9125-dd684dcd611b%40googlegroups.com.


[elixir-core:9281] Re: Normalize compile errors and warnings

2019-11-26 Thread Mijail Rondon
I think i can make the change for that.

Is on lib/elixir/src/elixir_errors.erl

El miércoles, 27 de noviembre de 2019, 0:57:00 (UTC-5), Mijail Rondon 
escribió:
>
> Hello Elixir Core,
>
> Currently we have different ways to display errors or warnings during 
> compile time, we should normalize the output.
>
> For example, warnings are displayed as:
>
> warning: unused alias Stream
>   lib/actions_sample.ex:2
>
> and compile errors as:
>
> ** (SyntaxError) lib/actions_sample.ex:15: unexpectedly reached end of 
> line. ...
>
> So, no problem with compile errors but warnings should have the same 
> format as:
>
> ** (Warning) lib/actions_sample.ex:2: unused alias Stream
>
> The main reason to make this change is because in CI we have the ability 
> of catch those warnings or errors 
> and add annotations on specific lines of the corresponding files. 
>
> If we normalize the warnings this will be possible to add annotations of 
> warnings to.
>

-- 
You received this message because you are subscribed to the Google Groups 
"elixir-lang-core" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to elixir-lang-core+unsubscr...@googlegroups.com.
To view this discussion on the web visit 
https://groups.google.com/d/msgid/elixir-lang-core/491c2a71-560e-4df3-9547-98696502aaf8%40googlegroups.com.


Re: [elixir-core:9281] Re: Normalize compile errors and warnings

2019-11-26 Thread Louis Pilfold
Hello!

What prevents the tool from attempting to parse both formats and using
whichever succeeds? That way this feature can exist without any changes to
the compiler.

Cheers,
Louis

On Wed, 27 Nov 2019, 06:11 Mijail Rondon,  wrote:

> I think i can make the change for that.
>
> Is on lib/elixir/src/elixir_errors.erl
>
> El miércoles, 27 de noviembre de 2019, 0:57:00 (UTC-5), Mijail Rondon
> escribió:
>>
>> Hello Elixir Core,
>>
>> Currently we have different ways to display errors or warnings during
>> compile time, we should normalize the output.
>>
>> For example, warnings are displayed as:
>>
>> warning: unused alias Stream
>>   lib/actions_sample.ex:2
>>
>> and compile errors as:
>>
>> ** (SyntaxError) lib/actions_sample.ex:15: unexpectedly reached end of
>> line. ...
>>
>> So, no problem with compile errors but warnings should have the same
>> format as:
>>
>> ** (Warning) lib/actions_sample.ex:2: unused alias Stream
>>
>> The main reason to make this change is because in CI we have the ability
>> of catch those warnings or errors
>> and add annotations on specific lines of the corresponding files.
>>
>> If we normalize the warnings this will be possible to add annotations of
>> warnings to.
>>
> --
> You received this message because you are subscribed to the Google Groups
> "elixir-lang-core" group.
> To unsubscribe from this group and stop receiving emails from it, send an
> email to elixir-lang-core+unsubscr...@googlegroups.com.
> To view this discussion on the web visit
> https://groups.google.com/d/msgid/elixir-lang-core/491c2a71-560e-4df3-9547-98696502aaf8%40googlegroups.com
> 
> .
>

-- 
You received this message because you are subscribed to the Google Groups 
"elixir-lang-core" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to elixir-lang-core+unsubscr...@googlegroups.com.
To view this discussion on the web visit 
https://groups.google.com/d/msgid/elixir-lang-core/CABu8xFDk7_z2WoqBCMAOFjNpe3kCFoQC0M0%2BkV%2BwrA4sGtttPg%40mail.gmail.com.