Re: [elixir-core:9175] Detecting bogus defdelegate options

[Louis Pilfold]

Hello!

What would be the desired behaviour of the `when` option?

Cheers,
Louis

On Wed, 16 Oct 2019 at 10:51, Thomas Stratmann <
thomas.stratm...@9elements.com> wrote:

> Hello,
>
> a coworker tried `defdelegate fun(..), to: SomeModule, when:
> some_conditon` the other day. defdelegate does not implement a `when`
> option, but does not complain about any excess options.
>
> Since defdelegate is almost always executed at compile time, the impact of
> an additional check for the options passed should be negligible. It could
> raise with a meaningful message.
>
> Would this be a welcome change?
>
> --
> You received this message because you are subscribed to the Google Groups
> "elixir-lang-core" group.
> To unsubscribe from this group and stop receiving emails from it, send an
> email to elixir-lang-core+unsubscr...@googlegroups.com.
> To view this discussion on the web visit
> https://groups.google.com/d/msgid/elixir-lang-core/8856eeed-f80e-458a-addb-e063e9791473%40googlegroups.com
> 
> .
>

-- 
You received this message because you are subscribed to the Google Groups 
"elixir-lang-core" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to elixir-lang-core+unsubscr...@googlegroups.com.
To view this discussion on the web visit 
https://groups.google.com/d/msgid/elixir-lang-core/CABu8xFAsR95xcnv1ZbwinA3cq_qZJGS8GqARe42u9R%3DJ-Vx4Gg%40mail.gmail.com.

[elixir-core:9175] Detecting bogus defdelegate options

[Thomas Stratmann]

Hello,

a coworker tried `defdelegate fun(..), to: SomeModule, when: some_conditon` 
the other day. defdelegate does not implement a `when` option, but does not 
complain about any excess options.

Since defdelegate is almost always executed at compile time, the impact of 
an additional check for the options passed should be negligible. It could 
raise with a meaningful message.

Would this be a welcome change?

-- 
You received this message because you are subscribed to the Google Groups 
"elixir-lang-core" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to elixir-lang-core+unsubscr...@googlegroups.com.
To view this discussion on the web visit 
https://groups.google.com/d/msgid/elixir-lang-core/8856eeed-f80e-458a-addb-e063e9791473%40googlegroups.com.