Re: [O] Support showing stars as pretty bullets

2018-04-02 Thread Nicolas Goaziou
Hello,

Alex Branham  writes:

> Why not, if you don't mind me asking? Other major modes (python, elisp,
> and latex off the top of my head) setup prettify-symbols themselves.

Because "org.el" file is already 23 kloc long, and I'm trying to put it
on a diet.

Regards,

-- 
Nicolas Goaziou



Re: [O] Support showing stars as pretty bullets

2018-04-02 Thread William Denton

On 2 April 2018, Alex Branham wrote:


It could go into some "org-art.el" library (along with Org bullet mode,
or something that would auto-number headlines) within the code base, or
simply in GNU ELPA.


I'm fine putting it into org-XXX.el if you want. I didn't for now since
it's only a few lines of code.


Wherever it goes, it would be great if it's integrated into the code base.  It's 
a very nice visual improvement.


Bill
--
William Denton :: Toronto, Canada   ---   Listening to Art: 
https://listeningtoart.org/
https://www.miskatonic.org/ ---   GHG.EARTH: http://ghg.earth/
Caveat lector.  ---   STAPLR: http://staplr.org/



Re: [O] Support showing stars as pretty bullets

2018-04-02 Thread Alex Branham

On Mon 02 Apr 2018 at 13:47, Nicolas Goaziou  wrote:

> Hello,
>
> Alex Branham  writes:
>
>> I've written this patch that makes use of prettify-symbols-mode to show
>> the stars in org headings as nice UTF bullets. There's already
>> org-bullet-mode[1] but that seems to have been abandoned, plus it isn't
>> included in org mode itself.
>
> Is it abandoned, or simply complete? Org lists haven't changed for
> a while.

Seems abandoned. The author hasn't had any activity on github since May
2015. Several issues and PR's have accumulated. Mind you, it still works
well overall. Looking more into this, there's already been some
discussion about it: https://github.com/sabof/org-bullets/issues/18

> In any case, I don't think this belongs to "org.el" proper.

Why not, if you don't mind me asking? Other major modes (python, elisp,
and latex off the top of my head) setup prettify-symbols themselves.

> It could go into some "org-art.el" library (along with Org bullet mode,
> or something that would auto-number headlines) within the code base, or
> simply in GNU ELPA.

I'm fine putting it into org-XXX.el if you want. I didn't for now since
it's only a few lines of code.

Thanks for the comments!
Alex



Re: [O] [PATCH] ob-shell add "zsh" and "fish" to shell names.

2018-04-02 Thread Nicolas Goaziou
Hello,

stardiviner  writes:

> Add "zsh" and "fish" into ob-shell support.

Applied. Thank you.

Regards,

-- 
Nicolas Goaziou



Re: [O] Support showing stars as pretty bullets

2018-04-02 Thread Nicolas Goaziou
Hello,

Alex Branham  writes:

> I've written this patch that makes use of prettify-symbols-mode to show
> the stars in org headings as nice UTF bullets. There's already
> org-bullet-mode[1] but that seems to have been abandoned, plus it isn't
> included in org mode itself.

Is it abandoned, or simply complete? Org lists haven't changed for
a while.

In any case, I don't think this belongs to "org.el" proper. 

It could go into some "org-art.el" library (along with Org bullet mode,
or something that would auto-number headlines) within the code base, or
simply in GNU ELPA.

WDYT?

Regards,

-- 
Nicolas Goaziou



Re: [O] [PATCH] fix org-babel-js-initiate-session required second optional argument

2018-04-02 Thread Nicolas Goaziou
Hello,

stardiviner  writes:

> From e6e11810c793aaaca0c491c263447fcad39b2eb0 Mon Sep 17 00:00:00 2001
> From: stardiviner 
> Date: Sun, 1 Apr 2018 17:25:19 +0800
> Subject: [PATCH 1/2] * ob-js.el (org-babel-js-initiate-session) add required
>  optional second arg.

Applied. Thank you.

Regards,

-- 
Nicolas Goaziou



Re: [O] [PATCH] ob-python: Insert necessary blank line when sending code to interpreter

2018-04-02 Thread Nicolas Goaziou
Hello,

qijian gong  writes:

> I've written this patch to fix the syntax error alarm caused by evaluating
> the following code block:
>
> #+BEGIN_SRC python :session
> if True:
> 1
> 2
> #+END_SRC

Thank you. 

Could you add a test in "test-ob-python.el"? Could you also add
a comment explaining what you are doing?

> +(let ((curr-indent (string-match "[^\s]" line)))

  (string-match "\\S-" line)

Regards,

-- 
Nicolas Goaziou



[O] Bug: master: "Capture abort: (error Format specifier doesn’t match argument type)"

2018-04-02 Thread Gregor Zattler
Hi org-mode developers,

with

GNU Emacs 26.0.91 (build 2, x86_64-pc-linux-gnu, GTK+ Version
3.22.11) of 2018-04-02

and 

Org mode version 9.1.9 (release_9.1.9-560-gf93aa7 @
/home/grfz/src/org-mode/lisp/)


I get

"Capture abort: (error Format specifier doesn’t match argument
type)"

after hitting the template key in order to capture something.

This is not the case in

Org mode version 9.1.9 (release_9.1.9-3-gb1a639 @
/home/grfz/src/org-mode/lisp/)
from maint as of b1a6395dfeadd9adc5ce7633f341dfbbb30bd39e.


I tried to bisect this with
make autoloads ; emacs-snapshot -nw --debug-init --eval '(org-capture 4 "t")'
as a test, but did not find the culprit.

As a workaround I switched to main.

Thanks for your attention, Gregor




[O] org-wikinodes.el and "invalid format operation %%\"

2018-04-02 Thread Michael Maurer
I've enabled org-wikinodes.el to get CamelCase wiki links. But
whenever I try to follow a link/camelcase word, I just get "invalid
format operation %%\". Although there is a headline by that name in
the current file.
I'm using org-mode 9.1.6 and Emacs 25.3.1 64-bit on Win7.