Re: [O] [PATCH] Add feature to org-drill to auto pronounce word

2019-01-30 Thread Nicolas Goaziou
Hello,

stardiviner  writes:

> Oh, sorry, seems yes.

OK. A couple of comments if you don't mind.
> +(defcustom org-drill-pronounce-command ""
> +  "Org-drill pronounce command."
> +  :type 'string
> +  :safe #'stringp
> +  :group 'org-drill)

This is clearly not a safe command. You can remove the :safe keyword, or
put :safe nil

> +(defun org-drill-pronounce-word ()
> +  "Pronounce word after querying."
> +  (when org-drill-auto-pronounce
> +(shell-command-to-string
> + (format "%s %s %s &"
> +  org-drill-pronounce-command org-drill-pronounce-command-args
> +  (shell-quote-argument
> +   (substring-no-properties
> +(org-get-heading 'no-tags 'no-todo 'no-priority 
> 'no-comment)))

Is there any reason to use `shell-command-to-string'? You don't seem to
need the returned string anyway. Why not calling `start-process', or at
least `async-shell-command'?

Regards,

-- 
Nicolas Goaziou



Re: [O] please read: bug when marking tasks done

2019-01-30 Thread Nicolas Goaziou
Hello,

cesar mena  writes:

> Nicolas Goaziou  writes:
>> However, we still need to move forward. So, I suggest to revert the
>> change about inactive timestamps. Inactive timestamps cannot be
>> repeated. This is less disruptive than the current situation. 
>
> yes, agreed.

Done in maint.

>> However, I also suggest to add a new hook, run after repeating
>> timestamps. With this hook, and a proper, user-specific, markup, it
>> should be possible to pick inactive timestamps in the section and
>> "repeat" them manually, i.e., on a case-by-case basis.

Done too.

> another (maybe crazy) idea is to advise org-auto-repeat-maybe and set
> org-repeat-re as needed before it gets called.

It is possible, but should be done on the user side, not on the Org one.

Regards,

-- 
Nicolas Goaziou



Re: [O] Bug: `comment-line` within a SRC block moves point to beginning of block [9.2 (9.2-43-gf9a8cc-elpaplus)]

2019-01-30 Thread kadal

I have the same issue with:

Org mode version 9.2 (9.2-43-gf9a8cc-elpaplus)
GNU Emacs 27.0.50 (build 2, x86_64-pc-linux-gnu, GTK+ Version 3.18.9) of 
2018-12-14


I assumed it was a bug in comment-dwim-2, but it occurs with 
comment-line too.


On 1/30/19 1:13 PM, Nicolas Goaziou wrote:

Hello,

Spencer Russell  writes:


Thanks for trying it out. Would you mind sharing your emacs and org
versions?


Sure.

Org mode version 9.2 (release_9.2-213-g5c07b4)
GNU Emacs 26.1

Could you try master branch?

Regards,






Re: [O] Bug: `comment-line` within a SRC block moves point to beginning of block [9.2 (9.2-43-gf9a8cc-elpaplus)]

2019-01-30 Thread Nicolas Goaziou
Hello,

Spencer Russell  writes:

> Thanks for trying it out. Would you mind sharing your emacs and org
> versions?

Sure.

Org mode version 9.2 (release_9.2-213-g5c07b4)
GNU Emacs 26.1

Could you try master branch?

Regards,

-- 
Nicolas Goaziou



Re: [O] Org without Emacs?

2019-01-30 Thread Scott Randby
On 1/29/19 8:33 PM, nly wrote:
> btw, you can run emacs on android, and use org from there.
> 
> You can install termux from fdroid
> and then, at a termux shell, enter:
> $ pkg install emacs
> 

I have Termux and Emacs installed on my Android tablet, but I've had too many 
issues with yanking from one file to another (it doesn't work most of the time) 
and other things. I prefer using Emacs on my laptop which has Xubuntu installed.

Scott



Re: [O] Bug: `comment-line` within a SRC block moves point to beginning of block [9.2 (9.2-43-gf9a8cc-elpaplus)]

2019-01-30 Thread Spencer Russell
On Tue, Jan 29, 2019, at 3:32 PM, Nicolas Goaziou wrote:
> 
> FWIW, I cannot reproduce it.
> 

Thanks for trying it out. Would you mind sharing your emacs and org versions?

-s



Re: [O] please read: bug when marking tasks done

2019-01-30 Thread cesar mena
Nicolas Goaziou  writes:

> Hello,
>
> Samuel Wales  writes:
>
>> commented repeater cookies does not have any of the above drawbacks.
>> it might require a 3rd party tool to update its re if that tool uses
>> repeaters.  this is not unprecedented.  the inactive repeater feature
>> might already require a 3rd party tool to update its re.
>>
>> so upon reflection i think i'd go for commentable repeater cookies.
>> it has a bonus too: whenever you turn off a repeater, it can be
>> annoying that it zeroes out the interval.  commenting would fix that.
>>
>> perhaps there is a better, unmentioned solution?
>
> I think commented repeaters add unnecessary overhead to the already
> loaded timestamp syntax. This is, IMO, not a common enough need to
> warrant even a minor syntax change.
>
> However, we still need to move forward. So, I suggest to revert the
> change about inactive timestamps. Inactive timestamps cannot be
> repeated. This is less disruptive than the current situation. 

yes, agreed.

> However, I also suggest to add a new hook, run after repeating
> timestamps. With this hook, and a proper, user-specific, markup, it
> should be possible to pick inactive timestamps in the section and
> "repeat" them manually, i.e., on a case-by-case basis.

another (maybe crazy) idea is to advise org-auto-repeat-maybe and set
org-repeat-re as needed before it gets called.

regards,
-cm





Re: [O] Org without Emacs?

2019-01-30 Thread Jude DaShiell
Too bad Apple's IOS is so limited the app store only offers not emacs
along with the org clones which have to operate separately.

On Wed, 30 Jan 2019, nly wrote:

> Date: Tue, 29 Jan 2019 20:33:33
> From: nly 
> To: emacs-orgmode@gnu.org
> Subject: Re: [O] Org without Emacs?
>
> btw, you can run emacs on android, and use org from there.
>
> You can install termux from fdroid
> and then, at a termux shell, enter:
> $ pkg install emacs
>
> I use emacs for org and matrix because matrix clients on android are not as 
> nice.
>
> Cheers,
> Amar 
>
> On January 29, 2019 3:46:43 PM UTC, Scott Randby  wrote:
> >On 1/28/19 11:42 PM, Tim Cross wrote:
> >> Of course, this says nothing about the ethical position associated
> >with re-implementing functionality from a GPL'd sysem under a non-free
> >license. We can hope people do the right thing, but have no control to
> >enforce it. I also doubt it will cause any fracture in the org user
> >community - the bottom line is most of use came to org because of
> >Emacs. These other systems don't have Emacs and therefore are really
> >only a pale imitation.
> >
> >I'm one of those who came to Emacs because of Org. I read an article in
> >some magazine (Linux Journal?) about Org and knew I had to try it out.
> >Once I was into using Org, Emacs took over more and more of my
> >computing life. People who use a non-free semi-implementation of Org
> >may not even realize Emacs is the software that made Org possible and
> >that Emacs is so great, and I think that is sad.
> >
> >Scott
>
>

--