Re: `org-emphasize' missing in the manual

2024-04-23 Thread Arash Esbati
Ihor Radchenko  writes:

> Thanks!
> Applied, onto main.
> https://git.savannah.gnu.org/cgit/emacs/org-mode.git/commit/?id=ff9d00c9c

Thanks for considering this.

Best, Arash



Re: `org-emphasize' missing in the manual

2024-04-22 Thread Arash Esbati
Ihor Radchenko  writes:

> Makes sense.
> Would you be interested to submit a patch?
> You will need to modify doc/org-manual.org file in Org repository.
> See https://orgmode.org/worg/org-contribute.html

Thanks for your response.  I'm not really familiar with Org development,
but I hope the attached change fits the bill.  Please feel free to
adjust when necessary.

Best, Arash
>From 91704900ff6b0a299b9cba71124b984366489dac Mon Sep 17 00:00:00 2001
From: Arash Esbati 
Date: Tue, 23 Apr 2024 07:36:18 +0200
Subject: [PATCH] doc/org-manual.org: Document `org-emphasize'

* doc/org-manual.org (Emphasis and Monospace): Document the
command `org-emphasize'.

Link: https://lists.gnu.org/archive/html/emacs-orgmode/2024-04/msg00381.html
---
 doc/org-manual.org | 12 +++-
 1 file changed, 11 insertions(+), 1 deletion(-)

diff --git a/doc/org-manual.org b/doc/org-manual.org
index ca1c9b482..aa18f7514 100644
--- a/doc/org-manual.org
+++ b/doc/org-manual.org
@@ -11233,7 +11233,17 @@ but not any simpler
 You can make words =*bold*=, =/italic/=, =_underlined_=, ==verbatim==
 and =~code~=, and, if you must, =+strike-through+=.  Text in the code
 and verbatim string is not processed for Org specific syntax; it is
-exported verbatim.
+exported verbatim.  Org provides a single command as entry point for
+inserting the marker character.
+
+- {{{kbd(C-c C-x C-f)}}} (~org-emphasize~) ::
+
+  #+kindex: C-c C-x C-f
+  #+findex: org-emphasize
+  Prompt for a marker character and insert or change an emphasis.  If
+  there is an active region, change that region to a new emphasis.  If
+  there is no region, just insert the marker characters and position
+  the cursor between them.
 
 #+vindex: org-fontify-emphasized-text
 To turn off fontification for marked up text, you can set
-- 
2.44.0



`org-emphasize' missing in the manual

2024-04-22 Thread Arash Esbati
Hi all,

I wonder why the function `org-emphasize' is missing in the manual.  I'm
not an versed Org user, but it seems that this command is the entry
point for users to mark up text.  So I suggest to add it to

  12.2 Emphasis and Monospace[1],[2]

incl. the keybinding "C-c C-x C-f".

Best, Arash

Footnotes:
[1]  https://orgmode.org/manual/Emphasis-and-Monospace.html
[2]  
https://git.savannah.gnu.org/cgit/emacs/org-mode.git/tree/doc/org-manual.org#n11222



Re: [PATCH] Fix one remaining emacs-30 byte-compile warning

2023-01-26 Thread Arash Esbati
Ihor Radchenko  writes:

> Thanks!
> Applied, onto bugfix.
> https://git.savannah.gnu.org/cgit/emacs/org-mode.git/commit/?id=65ca7bc6a

Thanks!

> You are also now listed as a contributor.
> https://git.sr.ht/~bzg/worg/commit/36cbf082

Thanks for adding me.  You have me now under this section:

  * Current contributors with tiny changes

  These people have submitted tiny change patches that made it into Org
  without FSF papers.  When they submit more, we need to get papers
  eventually.

I have signed the FSF paper for GNU Emacs.  I'm not familiar with Org
development, but maybe you want to put me under, if at all:

  Here is the list of people who signed the papers with the Free Software
  Foundation and can now freely submit code to Org files that are included
  within GNU Emacs:

Best, Arash



Re: [PATCH] Fix one remaining emacs-30 byte-compile warning

2023-01-25 Thread Arash Esbati
Robert Pluim  writes:

>>>>>> On Tue, 24 Jan 2023 10:29:17 +0100, Arash Esbati  said:
>
> I didnʼt miss it, it was next on my list,

Sorry for my wrong assumption here.

> Of course my fixes are incomplete, as Ihor has pointed out, so more
> work is needed there. 😀

I know why I volunteered for the change I suggested 😉

> Arash> +use it to set a major mode there, e.g.,
>
> I prefer ':' to ',' in such situations, but I donʼt recall what the
> official position is (if there is one).

-> git --no-pager grep "e.g.:$" | wc -l
13

-> git --no-pager grep "e.g.,$" | wc -l
49

':' would have been my preference my well.

Best, Arash



Re: [PATCH] Fix one remaining emacs-30 byte-compile warning

2023-01-25 Thread Arash Esbati
Ihor Radchenko  writes:

> Could you please write a full patch with commit message? See
> https://orgmode.org/worg/org-contribute.html#first-patch

Thanks for your response.  I hope I've got it right.

Best, Arash
>From c550ed05d29cf163c286cffc328e5860423c7cde Mon Sep 17 00:00:00 2001
From: Arash Esbati 
Date: Wed, 25 Jan 2023 16:34:42 +0100
Subject: [PATCH] lisp/ox.el: Pacify compiler warning

* lisp/ox.el (org-export-to-buffer): Escape single quote in the
example given in docstring.
Add missing '.' after the abbreviation.
---
 lisp/ox.el | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

diff --git a/lisp/ox.el b/lisp/ox.el
index ebf89bb..4c84686 100644
--- a/lisp/ox.el
+++ b/lisp/ox.el
@@ -6683,14 +6683,14 @@ see.
 Optional argument POST-PROCESS is a function which should accept
 no argument.  It is always called within the current process,
 from BUFFER, with point at its beginning.  Export back-ends can
-use it to set a major mode there, e.g,
+use it to set a major mode there, e.g.,
 
   (defun org-latex-export-as-latex
 (&optional async subtreep visible-only body-only ext-plist)
 (interactive)
 (org-export-to-buffer \\='latex \"*Org LATEX Export*\"
   async subtreep visible-only body-only ext-plist
-  #'LaTeX-mode))
+  #\\='LaTeX-mode))
 
 When expressed as an anonymous function, using `lambda',
 POST-PROCESS needs to be quoted.
-- 
2.39.1



[PATCH] Fix one remaining emacs-30 byte-compile warning

2023-01-24 Thread Arash Esbati
Hi all,

Robert sent a patch[1] which pacifies emacs-30 compiler warning.  He
missed one which is fixed by the patch below.  It is against org-mode
master (6b15897a56).

Footnotes:
[1]  https://lists.gnu.org/archive/html/emacs-orgmode/2023-01/msg00743.html

Best, Arash

--8<---cut here---start->8---
diff --git a/lisp/ox.el b/lisp/ox.el
index ebf89bb..4c84686 100644
--- a/lisp/ox.el
+++ b/lisp/ox.el
@@ -6683,14 +6683,14 @@ see.
 Optional argument POST-PROCESS is a function which should accept
 no argument.  It is always called within the current process,
 from BUFFER, with point at its beginning.  Export back-ends can
-use it to set a major mode there, e.g,
+use it to set a major mode there, e.g.,

   (defun org-latex-export-as-latex
 (&optional async subtreep visible-only body-only ext-plist)
 (interactive)
 (org-export-to-buffer \\='latex \"*Org LATEX Export*\"
   async subtreep visible-only body-only ext-plist
-  #'LaTeX-mode))
+  #\\='LaTeX-mode))

 When expressed as an anonymous function, using `lambda',
 POST-PROCESS needs to be quoted.
--8<---cut here---end--->8---