Re: [O] [PATCH] Allow relative times in clocktable tstart and tend options
Nicolas Goaziou (2012-11-30 16:31:47 +0100) wrote: Hello, Ivan Vilata i Balaguer i...@elvil.net writes: I expected to find some existing clocktable test I could base mine upon, but it seems that there's none yet. Yes, Org is lacking in the regression tests area. I hope that will change in the future. So I wrote a simple example file (attached) in case it can be useful for a test. Great. I wrote tests out of it. I'm also attaching a small update to patch that adds a trivial example to the info file. Thanks anyway! This is now applied. Thank you for you work. Regards, It was very instructive to look at the new tests. :) Thanks! -- Ivan Vilata i Balaguer -- https://elvil.net/
Re: [O] [PATCH] Allow relative times in clocktable tstart and tend options
Nicolas Goaziou (2012-11-28 13:47:32 +0100) wrote: Ivan Vilata i Balaguer i...@selidor.net writes: * lisp/org-clock.el (org-clock-get-table-data): Pass tstart and tend time strings through `org-matcher-time` to allow relative times besides absolute ones, convert result to encoded time. * doc/org.texi (The clock table): Document acceptance of relative times in tstart and tend, link to syntax description. Inspired in the original relative times proposal by Ilya Shlyakhter, this is less invasive and it doesn't modify core functions, thus it avoids the original's infinite recursion when hitting normal dates in other locations. TINYCHANGE Thank you for your patch. Would you mind providing a (couple) of simple test case(s) (or better, a complete ert test) for that situation? Of course, I will do it ASAP. Thanks for considering the patch! -- Ivan Vilata i Balaguer -- https://elvil.net/
Re: [O] [PATCH] Allow relative times in clocktable tstart and tend options
Ivan Vilata i Balaguer (2012-11-28 17:11:46 +0100) wrote:
Nicolas Goaziou (2012-11-28 13:47:32 +0100) wrote:
Ivan Vilata i Balaguer i...@selidor.net writes:
* lisp/org-clock.el (org-clock-get-table-data): Pass tstart and tend
time strings through `org-matcher-time` to allow relative times besides
absolute ones, convert result to encoded time.
* doc/org.texi (The clock table): Document acceptance of relative times
in tstart and tend, link to syntax description.
Inspired in the original relative times proposal by Ilya Shlyakhter,
this is less invasive and it doesn't modify core functions, thus it
avoids the original's infinite recursion when hitting normal dates in
other locations.
TINYCHANGE
Thank you for your patch.
Would you mind providing a (couple) of simple test case(s) (or
better, a complete ert test) for that situation?
Of course, I will do it ASAP. Thanks for considering the patch!
I expected to find some existing clocktable test I could base mine upon,
but it seems that there's none yet, and my elisp skills are insufficient
to write a completely new test mysef. So I wrote a simple example file
(attached) in case it can be useful for a test.
Then I realised that using it for a test can be difficult since relative
times depend on the moment that functions are invoked, so no luck. :(
I'm really sorry that I can provide nothing more than this. However it
seems to work from my live tests, and I confined the changes as much as
possible to avoid other failures.
I'm also attaching a small update to patch that adds a trivial example
to the info file.
Thanks anyway!
--
Ivan Vilata i Balaguer -- https://elvil.net/
#+TITLE: Testing relative times in a clocktable
* Relative times in clocktable :ATTACH:
:PROPERTIES:
:ID: af259fdb-b7b7-4307-81b0-0a4439fd944d
:END:
Previous two days:
#+BEGIN: clocktable :tstart today-2 :tend today :link nil :indent nil
Clock summary at [2012-11-28 dc 22:28]
| Headline | Time | |
|--+---+---|
| *Total time* | *16:00* | |
|--+---+---|
| Relative times in clocktable | 16:00 | |
| Foo | | 5:00 |
| Bar | | 11:00 |
#+END: clocktable
From yesterday until now:
#+BEGIN: clocktable :tstart yesterday :tend now :link nil :indent nil
Clock summary at [2012-11-28 dc 22:28]
| Headline | Time | |
|--+---+--|
| *Total time* | *13:00* | |
|--+---+--|
| Relative times in clocktable | 13:00 | |
| Foo | | 5:00 |
| Bar | | 8:00 |
#+END: clocktable
** Foo
CLOCK: [2012-11-26 dl 08:00]--[2012-11-26 dl 13:00] = 5:00
CLOCK: [2012-11-28 dc 08:00]--[2012-11-28 dc 13:00] = 5:00
** Bar
CLOCK: [2012-11-26 dl 15:00]--[2012-11-26 dl 18:00] = 3:00
CLOCK: [2012-11-27 dt 08:00]--[2012-11-27 dt 13:00] = 5:00
CLOCK: [2012-11-27 dt 15:00]--[2012-11-27 dt 18:00] = 3:00
CLOCK: [2012-11-28 dc 15:00]
From e85bd48ee3ba39c2bd365cabddd695a32a0184fa Mon Sep 17 00:00:00 2001
From: Ivan Vilata i Balaguer i...@selidor.net
Date: Wed, 28 Nov 2012 20:57:55 +0100
Subject: [PATCH] Allow relative times in clocktable tstart and tend options
* lisp/org-clock.el (org-clock-get-table-data): Pass tstart and tend
time strings through `org-matcher-time' to allow relative times besides
absolute ones, convert result to encoded time.
* doc/org.texi (The clock table): Document acceptance of relative times
in tstart and tend, link to syntax description and provide example.
Inspired in the original relative times proposal by Ilya Shlyakhter,
this is less invasive and it doesn't modify core functions, thus it
avoids the original's infinite recursion when hitting normal dates in
other locations.
TINYCHANGE
---
doc/org.texi |9 +
lisp/org-clock.el |4 ++--
2 files changed, 11 insertions(+), 2 deletions(-)
diff --git a/doc/org.texi b/doc/org.texi
index bf67876..e3a40ec 100644
--- a/doc/org.texi
+++ b/doc/org.texi
@@ -6263,7 +6263,11 @@ be selected:
thisyear, lastyear, thisyear-@var{N} @r{a relative year}
@r{Use @kbd{S-@key{left}/@key{right}} keys to shift the time interval.}
:tstart @r{A time string specifying when to start considering times.}
+ @r{Relative times like @code{-2w} can also be used. See}
+ @r{@ref{Matching tags and properties} for relative time syntax.}
:tend@r{A time string specifying when to stop considering times.}
+ @r{Relative times like @code{now} can also be used. See}
+ @r{@ref{Matching tags and properties} for relative time syntax.}
:step@r{@code{week} or @code{day}, to split the table into chunks.}
@r
[O] [PATCH] Allow relative times in clocktable tstart and tend options
* lisp/org-clock.el (org-clock-get-table-data): Pass tstart and tend
time strings through `org-matcher-time` to allow relative times besides
absolute ones, convert result to encoded time.
* doc/org.texi (The clock table): Document acceptance of relative times
in tstart and tend, link to syntax description.
Inspired in the original relative times proposal by Ilya Shlyakhter,
this is less invasive and it doesn't modify core functions, thus it
avoids the original's infinite recursion when hitting normal dates in
other locations.
TINYCHANGE
---
doc/org.texi |4
lisp/org-clock.el |4 ++--
2 files changed, 6 insertions(+), 2 deletions(-)
diff --git a/doc/org.texi b/doc/org.texi
index bf67876..c88b745 100644
--- a/doc/org.texi
+++ b/doc/org.texi
@@ -6263,7 +6263,11 @@ be selected:
thisyear, lastyear, thisyear-@var{N} @r{a relative year}
@r{Use @kbd{S-@key{left}/@key{right}} keys to shift the time
interval.}
:tstart @r{A time string specifying when to start considering times.}
+ @r{Relative times like @code{-2w} can also be used. See}
+ @r{@ref{Matching tags and properties} for relative time syntax.}
:tend@r{A time string specifying when to stop considering times.}
+ @r{Relative times like @code{now} can also be used. See}
+ @r{@ref{Matching tags and properties} for relative time syntax.}
:step@r{@code{week} or @code{day}, to split the table into chunks.}
@r{To use this, @code{:block} or @code{:tstart}, @code{:tend} are
needed.}
:stepskip0 @r{Do not show steps that have zero time.}
diff --git a/lisp/org-clock.el b/lisp/org-clock.el
index 54e4018..6595330 100644
--- a/lisp/org-clock.el
+++ b/lisp/org-clock.el
@@ -2604,9 +2604,9 @@ TIME: The sum of all time spend in this tree, in
minutes. This time
(setq te (format %4d-%02d-%02d (nth 2 te) (car te) (nth 1 te
;; Now the times are strings we can parse.
(if ts (setq ts (org-float-time
-(apply 'encode-time (org-parse-time-string ts)
+(seconds-to-time (org-matcher-time ts)
(if te (setq te (org-float-time
-(apply 'encode-time (org-parse-time-string te)
+(seconds-to-time (org-matcher-time te)
(save-excursion
(org-clock-sum ts te
(unless (null matcher)
--
1.7.10.4
--
Ivan Vilata i Balaguer -- https://elvil.net/
Re: [O] [PATCH] Time specifications: Allow specifying relative times
Achim Gratz (2012-11-14 20:44:55 +0100) wrote: Ivan Vilata i Balaguer writes: Bastien (2012-11-13 23:02:40 +0100) wrote: I'm not sure what went wrong on your side but the patch has been applied here: http://orgmode.org/cgit.cgi/org-mode.git/commit/?id=001bcb9645bf0a5ea72f09ae502a8410319473c0 I apologise if I'm getting confused with git or the way the Org repo is structured, but maybe the change was accidentally reverted later. It was reverted with 6f78edd68c, two hours after having been applied. So the relative time specifications patch caused some kind of problem? That'd be a real shame, the feature could be very useful. :( Thanks for the info, -- Ivan Vilata i Balaguer -- https://elvil.net/
Re: [O] [PATCH] Time specifications: Allow specifying relative times
Bastien (2012-11-13 23:02:40 +0100) wrote: Ivan Vilata i Balaguer i...@selidor.net writes: However, I'm looking at the Git master branch and I see that the patch hasn't actually been applied [there][1] yet (and the [original thread][2] is from March). Is there any problem with it? Am I looking at the wrong repo? [1]: http://orgmode.org/cgit.cgi/org-mode.git/tree/lisp/org.el#n16359 [2]: http://comments.gmane.org/gmane.emacs.orgmode/54101 I'm not sure what went wrong on your side but the patch has been applied here: http://orgmode.org/cgit.cgi/org-mode.git/commit/?id=001bcb9645bf0a5ea72f09ae502a8410319473c0 Sure I can see the patch, but then how come the version of ``org-parse-time-string`` in the head of both the master and maint branches is still the one from before the patch was applied? It's quite strange... I apologise if I'm getting confused with git or the way the Org repo is structured, but maybe the change was accidentally reverted later. In any case, thanks for your answer! -- Ivan Vilata i Balaguer -- https://elvil.net/
Re: [O] calfw, get rid of file names
Kyle Machulis (2012-06-12 03:47:40 +0200) wrote: I used defadvice to fix this: (defadvice qdot/cfw:org-extract-summary (after cfw:org-extract-summary) Remove tags and filenames from item summary (message item)) I placed that and `(ad-activate 'qdot/cfw:org-extract-summary)` in my `.emacs` but tags and file names are still shown by calfw after restarting Emacs. Did I miss something? Thanks, On Sun, Jun 10, 2012 at 1:57 AM, Michael Welle mwe012...@gmx.net wrote: I just discovered calfw. That's neat stuff ;). I wonder if I can customise away the org file names that are shown with the calendar entries? Mouse clicking on the entry brings me to the associated file, so IMHO showing the file's name does not provide additional information. -- Ivan Vilata i Balaguer -- https://elvil.net/
Re: [O] calfw, get rid of file names
Michael Welle (2012-06-12 10:40:00 +0200) wrote: Ivan Vilata i Balaguer i...@selidor.net writes: Kyle Machulis (2012-06-12 03:47:40 +0200) wrote: (defadvice qdot/cfw:org-extract-summary (after cfw:org-extract-summary) Remove tags and filenames from item summary (message item)) I placed that and `(ad-activate 'qdot/cfw:org-extract-summary)` in my `.emacs` but tags and file names are still shown by calfw after restarting Emacs. Did I miss something? I use a function similar to my-open-calendar from the documentation. The above advice doesn't seem to be called then. It is called if I use cfw:open-org-calendar instead. I have to look into how advices work I guess ;). The thing Kyle wanted to point out is that you can customise the item in the above advice. (message item) just prints the item to the status line. That explains the strange use of the `message` call ;) . It didn't work for me either (buffer `*Messages*` doesn't get anything new), but thanks for the clarification anyway. Cheers, -- Ivan Vilata i Balaguer -- https://elvil.net/
[O] Bug: Timestamp not removed from recurring appointment [7.7]
Hi, I've noticed that timestamps referring to a date before today are not removed from the text showed in appointments. For instance, if today is 2011-11-05, an appointment like this: * Reminders ** Call dad 2011-11-05 ds 12:42 +7d Shows up today as 12:42 Call dad. However, if the base date belongs to one week ago like this: * Reminders ** Call dad 2011-10-29 ds 12:42 +7d The message shows up today as 12:42 Call dad 2011-10-29 ds 12:42 +7d Thanks a lot! Emacs : GNU Emacs 23.3.1 (x86_64-pc-linux-gnu, GTK+ Version 2.24.6) of 2011-10-26 on trouble, modified by Debian Package: Org-mode version 7.7 current state: == (setq appt-disp-window-function (quote ivb/appt-disp-window) org-agenda-files '(~/bzr/ivan/org/tasks.org ~/bzr/ivan/org/reminders.org) org-agenda-skip-scheduled-if-done t org-finalize-agenda-hook '(bh/org-agenda-to-appt) org-agenda-before-write-hook '(org-agenda-add-entry-text) org-directory ~/bzr/ivan/org/ org-agenda-todo-ignore-with-date t org-agenda-skip-deadline-if-done t ) (defun ivb/appt-disp-window (min-to-app new-time appt-msg) (if (condition-case nil (server-running-p) (void-function nil)) (call-process notify nil 0 nil Recordatori appt-msg)) (appt-disp-window min-to-app new-time appt-msg)) ;; Vegeu http://doc.norang.ca/org-mode.html#Reminders. ;; Erase all reminders and rebuild reminders for today from the agenda. (defun bh/org-agenda-to-appt () (interactive) (setq appt-time-msg-list nil) (org-agenda-to-appt)) ;; Rebuild the reminders everytime the agenda is displayed. (add-hook 'org-finalize-agenda-hook 'bh/org-agenda-to-appt 'append) ;; Habilitar els avisos i carregar els recordatoris. (appt-activate +1) (bh/org-agenda-to-appt) -- Ivan Vilata i Balaguer -- http://elvil.net/
[O] Automatic ID insertion on entry creation
Hi all, I'm toying with MobileOrg and I see it prefers agenda entries having an ID property. That's ok with me, but since I'm keeping my agenda files under version control, I don't like that they are modified a long time after they are created, when pushing entries to MobileOrg. So I've tried that entries in agenda files be created right away with an ID property. Since I didn't find an option for that, I tried to use =%(org-id-get)= in my task template, which didn't work either. Then I came across this thread[1] and wrote the following function: #+BEGIN_SRC emacs-lisp (defun ivb/org-id-insert-maybe () Insert an ID property into the current entry and return it. This is only done if the file has the local variable `auto-insert-id' set to `t'. This function is intended for `org-insert-heading-hook' and `org-capture-after-finalize-hook'. (if (member (cons 'auto-insert-id t) file-local-variables-alist) (org-id-get-create))) #+END_SRC It works right for inserted headings, but it's quite unreliable when capturing: when capturing to a file with =auto-insert-id= set to =t=, =file-local-variables-alist= is sometimes nil (esp. when capturing from outside the file) and sometimes it has the right variables (when capturing from the same file, but not always). I got the values by debugging the function. Any suggestions to fix the function (or getting the same result by other means)? I'm using Emacs 23.3 and Org 7.5, both from Debian unstable. Thanks a lot, [1] http://www.mail-archive.com/emacs-orgmode@gnu.org/msg16143.html -- Ivan Vilata i Balaguer -- http://ivan.lovesgazpacho.net/
[Orgmode] Re: [BUG] Junk appended when exporting visible
David Maus (2010-11-07 20:25:59 +0100) wrote: At Wed, 03 Nov 2010 13:26:55 +0100, Ivan Vilata i Balaguer wrote: Hi, I've noticed that exporting an entry with at least two examples, when limiting the export to the visible tree (i.e. C-c C-e v format), appends some junk examples at the end of the entry. Curiously enough, this doesn't happen when the whole file is exported (i.e. C-c C-e format). This should be fixed in master now. The problem was that Org searched for possible in-buffer options in the source buffer without limiting this search to the region between beginning of buffer and beginning of first headline. Thanks a lot, David! -- Ivan Vilata i Balaguer -- http://ivan.lovesgazpacho.net/ ___ Emacs-orgmode mailing list Please use `Reply All' to send replies to the list. Emacs-orgmode@gnu.org http://lists.gnu.org/mailman/listinfo/emacs-orgmode
[Orgmode] [BUG] Junk appended when exporting visible
Hi, I've noticed that exporting an entry with at least two examples, when limiting the export to the visible tree (i.e. C-c C-e v format), appends some junk examples at the end of the entry. Curiously enough, this doesn't happen when the whole file is exported (i.e. C-c C-e format). The following sample file triggers the problem: 8 * Title ** Subtitle Foo1. #+BEGIN_EXAMPLE foo1 #+END_EXAMPLE Foo2. #+BEGIN_EXAMPLE foo2 #+END_EXAMPLE 8 Please note that an additional example is appended after foo2 in the exported file. I'm using Org version 7.01h. Thanks! -- Ivan Vilata i Balaguer -- http://ivan.lovesgazpacho.net/ ___ Emacs-orgmode mailing list Please use `Reply All' to send replies to the list. Emacs-orgmode@gnu.org http://lists.gnu.org/mailman/listinfo/emacs-orgmode
[Orgmode] Re: [BUG] OrgTbl exports raw ampersands in HTML
Nick Dokos (2010-10-13 22:52:02 +0200) wrote: The following patch should fix it: Thanks for the patch, Nick! -- Ivan Vilata i Balaguer -- http://ivan.lovesgazpacho.net/ ___ Emacs-orgmode mailing list Please use `Reply All' to send replies to the list. Emacs-orgmode@gnu.org http://lists.gnu.org/mailman/listinfo/emacs-orgmode
[Orgmode] [BUG] OrgTbl exports raw ampersands in HTML
(This is a rewrite of my previous post so it gets properly noticed as a bug. ;) ) When generating HTML tables with ampersands in the text, OrgTbl outputs raw ampersands () instead of escaped ampersands (amp;), which renders the file invalid. This bug does not affect normal HTML generation when exporting standalone files. I'm using Org version 7.01h. I've attached a sample HTML file with an OrgTbl table in it so you can check for yourselves. Thanks! message/external-body; name*=us-ascii''~%2ftmp%2fprova.html; access-type=local-file: Unrecognized -- Ivan Vilata i Balaguer -- http://ivan.lovesgazpacho.net/ ___ Emacs-orgmode mailing list Please use `Reply All' to send replies to the list. Emacs-orgmode@gnu.org http://lists.gnu.org/mailman/listinfo/emacs-orgmode
[Orgmode] Re: [BUG] OrgTbl exports raw ampersands in HTML
Nick Dokos (2010-10-13 18:37:11 +0200) wrote: AFAIK, orgtbl-mode is a minor mode so that you can use org's table generation facilities in other modes (e.g. text, or including a table in a comment in a C/python/perl/foo source file, or in mail...) In particular, it does not generate HTML. That is done by org's export facilities. So either your description is inaccurate or my understanding is flawed. Given the absence of responses, I suspect other people share my bafflement. It would help if you described the process you used exactly: Of course, Nick. First, I write an HTML file like the attached one, which already has an OrgTbl table and the markers describing where it is going to be output. Then I enable orgtbl-mode, I place the cursor over the table and press C-c C-c. The table is output in HTML between the markers. The problem is that foobar in the original table gets exported as foobar, when it should be exported as fooamp;bar to avoid spoling the HTML code. I hope it's clear enough this time. :) message/external-body; name*=us-ascii''~%2ftmp%2fprova.html; access-type=local-file: Unrecognized -- Ivan Vilata i Balaguer -- http://ivan.lovesgazpacho.net/ ___ Emacs-orgmode mailing list Please use `Reply All' to send replies to the list. Emacs-orgmode@gnu.org http://lists.gnu.org/mailman/listinfo/emacs-orgmode
[Orgmode] Re: [BUG] OrgTbl exports raw ampersands in HTML
Nick Dokos (2010-10-13 21:10:33 +0200) wrote: Yes, thanks. I'll try it out later. FWIW, my mail reader does not see an attachment in your message: all I get is the following attachmen with an external body. Not sure whose fault that is though: maybe mh-e gets hopelessly confused with it. Can you post the HTML file inline? Argh, I made an external attachment, sorry. Here you have the file: 8 html body !-- [CDATA[ #+ORGTBL: SEND test orgtbl-to-html | foobar | ]] -- !-- BEGIN RECEIVE ORGTBL test -- !-- END RECEIVE ORGTBL test -- /body /html 8 -- Ivan Vilata i Balaguer -- http://ivan.lovesgazpacho.net/ ___ Emacs-orgmode mailing list Please use `Reply All' to send replies to the list. Emacs-orgmode@gnu.org http://lists.gnu.org/mailman/listinfo/emacs-orgmode
[Orgmode] Ampersands in OrgTbl to HTML
OrgTbl fails to escape ampersands when exporting to HTML (see the attached example), possibly rendering the HTML file invalid. However, the ampersand is properly escaped when exporting the same table in a standalone Org file. I'm using Org version 7.01h. Thanks! foo -- Ivan Vilata i Balaguer -- http://ivan.lovesgazpacho.net/ ___ Emacs-orgmode mailing list Please use `Reply All' to send replies to the list. Emacs-orgmode@gnu.org http://lists.gnu.org/mailman/listinfo/emacs-orgmode
[Orgmode] Re: Orgmode meetup at FOSDEM, February 2011. Who would come?
Having an Org meet-up would be one more great reason to attend FOSDEM this year! :) Carsten Dominik (2010-09-28 19:44:30 +0200) wrote: Please reply to this email if you'd consider to come to FOSDEM[1,2], February 5 and 6 next year in Brussels, in order to join an Org-mode meet-up there. - [ ] I would come and listen - [ ] I would come and give a talk in the devroom [1] http://www.fosdem.org/2011/ [2] http://www.fosdem.org/2011/call_for_devrooms -- Ivan Vilata i Balaguer -- http://ivan.lovesgazpacho.net/ ___ Emacs-orgmode mailing list Please use `Reply All' to send replies to the list. Emacs-orgmode@gnu.org http://lists.gnu.org/mailman/listinfo/emacs-orgmode
[Orgmode] Re: Agenda and weather forecast
Julien Danjou (2010-09-09 08:19:17 +0200) wrote: If anybody is interested, I've wrote an small extension to put some weather forecasts in the agenda. Certainly impressive! Your fellow Debian developer Jordi Mallach just told me about your Emacs projects this morning and I've been having a look at them. For instance, the OfflineIMAP and Google Maps modes also look great. Keep the good work! :) -- Ivan Vilata i Balaguer -- http://ivan.lovesgazpacho.net/ ___ Emacs-orgmode mailing list Please use `Reply All' to send replies to the list. Emacs-orgmode@gnu.org http://lists.gnu.org/mailman/listinfo/emacs-orgmode
[Orgmode] Re: Plotting date on xaxis
Johan Ekh (2010-02-22 19:31:41 +0100) wrote: I try to plot a table looking like this | Date | Kg | |-+| | 2010-02-21 | 95.0 | | 2010-02-22 | 93.0 | | 2010-02-23 | 92.0 | | 2010-02-24 | 91.5 | | 2010-02-25 | 91.0 | | 2010-02-29 | 92.0 | | | | with the dates on the xaxis using #+PLOT: title:Weight ind:1 deps:(2) type:2d with:linespo set:xdata time timefmt:%Y-%m-%d set:yrange [90:] but no plot is generated. If I remove set:xdata time, the plot is generated but without interpreting the dates as dates. Can anyone see what I do wrong? Today I faced the same problem and I fixed it by replacing ``timefmt:%Y-%m-%d`` with ``set:timefmt '%Y-%m-%d'. HTH, -- Ivan Vilata i Balaguer -- http://ivan.lovesgazpacho.net/ ___ Emacs-orgmode mailing list Please use `Reply All' to send replies to the list. Emacs-orgmode@gnu.org http://lists.gnu.org/mailman/listinfo/emacs-orgmode
Re: [Orgmode] [PATCH] Trivial fix for %3f in URL bug
Carsten Dominik (2010-03-17 12:04:37 +0100) dixit:: On Mar 17, 2010, at 11:53 AM, Ivan Vilata i Balaguer wrote: Fixing the old behaviour is trivial: just remove the ``(?? . %3F)`` entry from the ``org-link-escape-chars`` list in ``org.el``. OK, I have applied this patch, thanks. I am, however, wondering if this does the right thing consistently, for example also when adding URLs containing a question mark using `C-c C-l'. Or when editing a link with `C-c C-l' while the cursor is on it. Maybe you or others can make a few more tests in this direction? I've tested those behaviours in the new, fixed release and they all seem to be ok. HTML export also works correctly. Thanks! :: Ivan Vilata i Balaguer -- http://ivan.lovesgazpacho.net/ signature.asc Description: Digital signature ___ Emacs-orgmode mailing list Please use `Reply All' to send replies to the list. Emacs-orgmode@gnu.org http://lists.gnu.org/mailman/listinfo/emacs-orgmode
[Orgmode] Flyspell highlighting (again)
Here Matthew Lundin reported Flyspell highlighting URL components: http://www.mail-archive.com/emacs-orgmode@gnu.org/msg14029.html The issue should be fixed according to the thread, but URLs like http://example.com/foo_blarghaa still cause problems (blarghaa is highlighted by Flyspell). For the wishlist, it'd also be nice to exclude #+FOO options from flyspelling, since they tend to get highlighted when writing non-English text. Thanks a lot! :: Ivan Vilata i Balaguer -- http://ivan.lovesgazpacho.net/ signature.asc Description: Digital signature ___ Emacs-orgmode mailing list Please use `Reply All' to send replies to the list. Emacs-orgmode@gnu.org http://lists.gnu.org/mailman/listinfo/emacs-orgmode
[Orgmode] [PATCH] Trivial fix for %3f in URL bug
Hi all, Regarding the previous thread “%3f shouldn't be unescaped in HTTP URLs”, I suggested that leaving the '?' or '%3f' characters in a URL as provided by the user might be the best thing to do, since they mean different things (query separator and literal question mark, respectively) and the user should know best (especially if the URL was copied from a browser). Fixing the old behaviour is trivial: just remove the ``(?? . %3F)`` entry from the ``org-link-escape-chars`` list in ``org.el``. Cheers, :: Ivan Vilata i Balaguer -- http://ivan.lovesgazpacho.net/ --- org.el.orig 2010-03-17 11:51:04.0 +0100 +++ org.el 2010-03-17 11:51:42.0 +0100 @@ -7877,7 +7877,6 @@ (?\371 . %F9) ; `u (?\373 . %FB) ; ^u (?\; . %3B) -(??. %3F) (?=. %3D) (?+. %2B) ) signature.asc Description: Digital signature ___ Emacs-orgmode mailing list Please use `Reply All' to send replies to the list. Emacs-orgmode@gnu.org http://lists.gnu.org/mailman/listinfo/emacs-orgmode
Re: [Orgmode] %3f shouldn't be unescaped in HTTP URLs
Sebastien Delafond (el 2010-03-09 a les 17:36:16 +) va dir:: Quoting from Debian bug #573186[0]: Some HTTP URLs have literal '?' in them. Since '?' also separates the path from query arguments, it needs to be escaped in the first case. These are examples of the two cases: - http://en.wikipedia.org/wiki/Who%27s_Afraid_of_Virginia_Woolf%3F (literal '?') - http://www.google.com/search?q=org+mode (query separator) These are the URLs generated by Org mode when exporting them to HTML: - http://en.wikipedia.org/wiki/Who%27s_Afraid_of_Virginia_Woolf? - http://www.google.com/search?q=org+mode I.e. '?' is left as is, but '%3f' is unescaped, producing the wrong URL (don't be fooled by the fact that Wikipedia actually accepts it ;) ). This makes impossible to correctly export an HTTP URL with a literal question mark in it. The solution would be to leave '%3f' as is, too, in the same way as '%27' has been left as is in the previous example. Hasn't anyone come across this behaviour? I think it's a bug which should be fixed since it makes some URLs impossible to write. And according to that last sentence, the solution doesn't seem too hard. Thanks and cheers, :: Ivan Vilata i Balaguer -- http://ivan.lovesgazpacho.net/ signature.asc Description: Digital signature ___ Emacs-orgmode mailing list Please use `Reply All' to send replies to the list. Emacs-orgmode@gnu.org http://lists.gnu.org/mailman/listinfo/emacs-orgmode
