Re: [O] PATCH: org-mac-link.el: Don't fail on machines without Growl installed
On 9 Oct 2014, at 12:40, Alan Schmitt alan.schm...@polytechnique.org wrote: Applied. Thank you for the patch and sorry for the delay. Thanks for merging both of those patches. I’ll re-work the other one (re. broken “message:” links) in the near future and resubmit. -Steve
Re: [O] PATCH: Fix malformed message links produced by org-mac-link.el
On 9 Oct 2014, at 13:15, Alan Schmitt alan.schm...@polytechnique.org wrote: On 2014-09-25 08:14, Alan Schmitt alan.schm...@polytechnique.org writes: On 2014-09-24 20:56, Steve Purcell st...@sanityinc.com writes: It seems that the difference is with getting quotes or not. How about changing org-as-get-selected-mail to make sure there is no quote? We could for instance test whether the first and last characters are quotes, and remove them if they are. Would this work for you? Yes, that works nicely here! -Steve
[O] PATCH: Fix malformed message links produced by org-mac-link.el
Links which should look like: [[message://2.11f23692084eb783e40c@NY-WEB01][Private beta invitation for Emacs QA site - Area 51 - Stack Exchange]] are currently mangled into: [[essage://2.11f23692084eb783e40c@NY-WEB01][Private beta invitation for Emacs QA site - Area 51 - Stack Exchang]] This tiny patch fixes this issue. Tested on OS X 10.9. -Steve 0001-org-mac-link.el-Fix-malformed-message-links.patch Description: Binary data
[O] PATCH: org-mac-link.el: Fix multi-line file description
The file description line was broken across multiple lines, and therefore malformed. -Steve 0001-org-mac-link.el-Fix-multi-line-file-description.patch Description: Binary data
[O] PATCH: org-mac-link.el: Don't fail on machines without Growl installed
The existing Applescript for grabbing flagged mail messages can only work on machines which have Growl installed. This is increasingly rarely the case as Growl has been obsoleted by OS X’s own notification system. -Steve 0001-org-mac-link.el-Don-t-fail-on-machines-without-Growl.patch Description: Binary data
Re: [O] PATCH: org-mac-link.el: Don't fail on machines without Growl installed
Alan Schmitt alan.schm...@polytechnique.org writes: On 2014-09-24 12:12, Steve Purcell st...@sanityinc.com writes: I'm surprised: I don't have Growl installed and it still works. I agree there is not much point in testing for Growl, though. I get the system popup asking me to locate the growlHelperApp program. -Steve
Re: [O] PATCH: Fix malformed message links produced by org-mac-link.el
Alan Schmitt alan.schm...@polytechnique.org writes: I just tested it with the current version and I'm not seeing this problem. Is there something special about that email that breaks, or are you seeing problems with every email? I see it with every mail. I'm on OS X 10.9.5, but the problem was also present on 10.9.4. The substring part of the removed code led to the trimming of the characters at each end, so it's not clear to me how it could ever have worked, unless the output is routinely wrapped in quotes on others' machines. Mysterious indeed. In any case, there were a few blocks of identical-looking code dotted around the file: the block appears to have been wisely extracted into org-mac-paste-applescript-links, but the duplicate code hasn't been replaced with a call to that function. So this patch does so for the Mail case, and the same fix should also probably be made in org-mac-outlook-message-get-links. -Steve
Re: [O] PATCH: Fix malformed message links produced by org-mac-link.el
On 24 Sep 2014, at 20:01, Alan Schmitt alan.schm...@polytechnique.org wrote:
This was the case here: the string returned by the AppleScript had
quotes (and it still does).
For instance, with the message you mention, the call to
org-as-get-selected-mail returns this (doing a debug):
Result: \message://2.b2af716655bbac583727@NY-WEB01::split::Private beta
invitation for Emacs QA site - Area 51 - Stack Exchange\””
I definitely don’t get quotes in the result of org-as-get-selected-mail.
It works well for grabbing a single message, but it breaks when grabbing
several. Here is one such broken result:
[[message://9670a832-d0b3-46a8-96bf-05c30d850...@gmail.com][Re: De passage ˆ
San Jose]]
[[message://4b980c40-db9a-47a7-95a7-17bb8cf81...@gmail.com][Re: De passage ˆ
San Jose]]
The string returned by the AppleScript was this:
Result:
\message://4b980c40-db9a-47a7-95a7-17bb8cf81...@gmail.com::split::Re: De
passage \210 San
Jose\nmessage://9670a832-d0b3-46a8-96bf-05c30d850...@gmail.com::split::Re: De
passage \210 San Jose\
Does it work on your machine with several messages selected?
Yes, it works correctly, as in the following links to this mail thread:
[[message://m2h9zwzvuz@polytechnique.org][Re: {O} PATCH: Fix malformed
message links produced by org-mac-link.el]]
[[message://m28ul9vxnr@top.irisa.fr][Re: {O} PATCH: Fix malformed message
links produced by org-mac-link.el]]
Not sure how to proceed, then…
-Steve
Re: [O] PATCH: org-mac-link.el: Don't fail on machines without Growl installed
On 24 Sep 2014, at 20:13, Alan Schmitt alan.schm...@polytechnique.org wrote: tell application System Events set growlHelpers to the name of every process whose creator type contains GRRR if (count of growlHelpers) 0 then set growlHelperApp to item 1 of growlHelpers else set growlHelperApp to end if end tell I get an empty string as returned value. Is is the same for you? Yes, that part works fine on its own even on my machine. But when the code passed to AppleScript includes 'tell application “GrowlHelperApp”’, then the code will not execute unless the app is present — there’s a precompilation step where, presumably, AppleScript determines that the target application supports the listed commands. -Steve
Re: [O] Regression: org-export-as-html failure
On 2 Mar 2013, at 11:22, Bastien b...@altern.org wrote: I cannot reproduce this with the current maint HEAD and emacs -Q. Can you? Let us know, thanks, Well, I have a clean Emacs HEAD build as of the following commit, and it still fails with -Q: Author: Glenn Morris r...@gnu.org Date: Sat Mar 2 06:17:34 2013 -0500 Auto-commit of generated files. -Steve
Re: [O] Regression: org-export-as-html failure
On 2 Mar 2013, at 12:09, Bastien b...@altern.org wrote: I meant the HEAD of the maint branch, from the Org-mode git repository. Does anyone with a local install of Org can reproduce this bug? Ah, yes -- that seems to work better. No backtrace, and just a small rendering quirk: the _ in the bare URLs is escaped with a backslash in the resulting HTML. That should be a trivial fix. :-) Thanks, -Steve
[O] Regression: org-export-as-html failure
Using the org-mode included in Emacs HEAD as of yesterday, the following content causes an error when exporting as html: https://gist.github.com/purcell/5055957 Backtrace: Debugger entered--Lisp error: (wrong-type-argument stringp nil) string-match(\\([^]\\)\\([_^]\\) nil) org-export-protect-sub-super(nil) org-export-normalize-links() org-export-preprocess-string(...) org-export-as-html(nil) call-interactively(org-export-as-html) Export as iCal works fine. The list of bare http links seems to be the problem, but until recently org-mode happily exported this content to html. -Steve
[O] Patch: org-mac-iCal is a no-op on OS X 10.8
I just found that org-mac-iCal.el doesn't work on OS X 10.8 (Mountain Lion). The trivial patch below fixes this. Cheers, -Steve commit 71b50131b5e6ae00a5e6c2f0bff2cec377c68c0f (HEAD, refs/heads/master) Author: Steve Purcell st...@sanityinc.com Date: Sat Dec 1 14:06:02 2012 + org-mac-iCal: also use post-Leopard logic to concatenate calendars in 10.8 Modified contrib/lisp/org-mac-iCal.el diff --git a/contrib/lisp/org-mac-iCal.el b/contrib/lisp/org-mac-iCal.el index 0fdc95f..a48cf22 100644 --- a/contrib/lisp/org-mac-iCal.el +++ b/contrib/lisp/org-mac-iCal.el @@ -99,7 +99,7 @@ the the Emacs diary ;; for each calendar, concatenate individual events into a single ics file (with-temp-buffer (shell-command sw_vers (current-buffer)) -(when (re-search-backward 10\\.[567] nil t) +(when (re-search-backward 10\\.[5678] nil t) (omi-concat-leopard-ics all-calendars))) ;; move all caldav ics files to the same place as local ics files
