Re: [BUG] Cursor is moved after changing list bullets

2022-06-16 Thread Ihor Radchenko
Daniel Fleischer  writes:

> Ihor Radchenko [2022-06-14 Tue 21:30] wrote:
>
>> I am unable to reproduce using any of the supported Emacs versions.
>> Could you please provide more concrete steps? Or better a test.
>
> Create a file called `list.org` with the following:
> ...
> Then put the cursor on one of the hyphens...

Thanks! I missed the part that cursor should be on one of the hyphens.

Fixed via 707d3a093 on main.

Best,
Ihor



Re: [BUG] Cursor is moved after changing list bullets

2022-06-14 Thread Daniel Fleischer
Ihor Radchenko [2022-06-14 Tue 21:30] wrote:

> I am unable to reproduce using any of the supported Emacs versions.
> Could you please provide more concrete steps? Or better a test.

Create a file called `list.org` with the following:

* Test

- Hello.
- hi.
- bye.

Then call:

emacs -Q -L ./Projects/org-mode/lisp/ -l org list.org

Then put the cursor on one of the hyphens and change its style using
S-right. The bullet will change and the cursor will move to the
beginning of a word instead of stay in place.

-- 

Daniel Fleischer



Re: [BUG] Cursor is moved after changing list bullets

2022-06-14 Thread Ihor Radchenko
Daniel Fleischer  writes:

> Hi, there is a regression introduced in:
>
> ed6f8dc67 org-list: Do not move point and change space when
>   promoting/demoting items
>
> When calling `org-cycle-list-bullet' (e.g. using S-right or S-left) the
> cursor moves to the beginning of the text after changing the bullet
> type. It used to not move which is useful to when trying different
> bullet styles. This is due to the changes in
> `org-list-struct-apply-struct'. I tried to debug it but I'm not sure
> what was the issue the patch was meant to solve.

I am unable to reproduce using any of the supported Emacs versions.
Could you please provide more concrete steps? Or better a test.

Best,
Ihor



[BUG] Cursor is moved after changing list bullets

2022-06-14 Thread Daniel Fleischer
Hi, there is a regression introduced in:

ed6f8dc67 org-list: Do not move point and change space when
  promoting/demoting items

When calling `org-cycle-list-bullet' (e.g. using S-right or S-left) the
cursor moves to the beginning of the text after changing the bullet
type. It used to not move which is useful to when trying different
bullet styles. This is due to the changes in
`org-list-struct-apply-struct'. I tried to debug it but I'm not sure
what was the issue the patch was meant to solve.

Thanks, 

-- 

Daniel Fleischer