Re: [BUG] columnview cannot deal with more than 100 headings [N/A (N/A @ /home/oub/emacs/site-lisp/packages/org/)]

2022-10-18 Thread Uwe Brauer
>>> "IR" == Ihor Radchenko  writes:

> Uwe Brauer  writes:
>> I attach a file that hopefully explains the problem.
>> 
>> That file contains 109 heading, each heading has 17 different properties 
>> when all of them are included in the 
>> #+BEGIN: columnview
>> #+END:
>> 
>> Block then not all headings are included. It seems to work with 15 
>> properties but not for all 17.

> I tried your file on the latest main, but I do not see anything
> obviously wrong. Could you please clarify what you expect to see?

I had the time to check my document which contains now 140 entries, it
worked like charm very fast and produced the right table out of the box.

Thanks, so that seems fix, if I find something strange I report back,

Thanks 

-- 
I strongly condemn Putin's war of aggression against the Ukraine.
I support to deliver weapons to Ukraine's military. 
I support the ban of Russia from SWIFT.
I support the EU membership of the Ukraine. 


smime.p7s
Description: S/MIME cryptographic signature


Re: [BUG] columnview cannot deal with more than 100 headings [N/A (N/A @ /home/oub/emacs/site-lisp/packages/org/)]

2022-10-17 Thread Ihor Radchenko
Uwe Brauer  writes:

> BTW, you send me some time ago (the <2022-07-30>) a patch that allowed
> edit-comment-blk: support COMMENT blocks
>
> Is this now in master/main? It is very convenient for my workflow
>
> For you convenience I attach the patch below

I have applied the patch and replied in the thread.
It is on main.

-- 
Ihor Radchenko // yantar92,
Org mode contributor,
Learn more about Org mode at .
Support Org development at ,
or support my work at 



Re: [BUG] columnview cannot deal with more than 100 headings [N/A (N/A @ /home/oub/emacs/site-lisp/packages/org/)]

2022-10-16 Thread Uwe Brauer
>>> "IR" == Ihor Radchenko  writes:

> Uwe Brauer  writes:
>> I attach a file that hopefully explains the problem.
>> 
>> That file contains 109 heading, each heading has 17 different properties 
>> when all of them are included in the 
>> #+BEGIN: columnview
>> #+END:
>> 
>> Block then not all headings are included. It seems to work with 15 
>> properties but not for all 17.

> I tried your file on the latest main, but I do not see anything
> obviously wrong. Could you please clarify what you expect to see?

Ok then, I will pull and install the latest master/main.

BTW, you send me some time ago (the <2022-07-30>) a patch that allowed
edit-comment-blk: support COMMENT blocks

Is this now in master/main? It is very convenient for my workflow

For you convenience I attach the patch below

Regards



-- 
I strongly condemn Putin's war of aggression against the Ukraine.
I support to deliver weapons to Ukraine's military. 
I support the ban of Russia from SWIFT.
I support the EU membership of the Ukraine. 
diff --git a/etc/ORG-NEWS b/etc/ORG-NEWS
index 478fcf95c..0bc3fa638 100644
--- a/etc/ORG-NEWS
+++ b/etc/ORG-NEWS
@@ -141,6 +141,14 @@ discouraged when working with Org files.
 
 ** New features
 
+*** Interactive commands now support escaping text inside comment blocks
+
+~org-edit-special~ and ~org-insert-structure-template~ now handle
+comment blocks.
+
+See [[*New command ~org-edit-comment-block~ to edit comment block at
+point]].
+
 *** New customization option =org-property-separators=
 A new alist variable to control how properties are combined.
 
@@ -253,6 +261,16 @@ instance,
 includes all available items in the printed bibliography.
 ** New functions and changes in function arguments
 
+*** New command ~org-edit-comment-block~ to edit comment block at point
+
+As the contents of comments blocks is not parsed as Org markup, the
+headlines and keywords inside should be escaped, similar to src
+blocks, example blocks, and export blocks.  This in inconvenient to do
+manually and ~org-edit-special~ is usually advised to edit text in
+such kind of blocks.
+
+Now, comment block editing is also supported via this new function.
+
 *** New function ~org-element-cache-map~ for quick mapping across Org elements
 
 When element cache is enabled, the new function provides the best
@@ -266,7 +284,6 @@ to ~org-element--cache-map-statistics~ and
 ~org-element--cache-map-statistics-threshold~.
 
 ~org-scan-tags~ and tag views in agenda utilise the new function.
-
 *** New function ~org-element-at-point-no-context~
 
 This function is like ~org-element-at-point~, but it does not try to
diff --git a/lisp/org-src.el b/lisp/org-src.el
index b7e0af50e..0249af60b 100644
--- a/lisp/org-src.el
+++ b/lisp/org-src.el
@@ -384,7 +384,7 @@ (defun org-src--contents-area (datum)
(let ((beg (org-element-property :contents-begin datum))
 	 (end (org-element-property :contents-end datum)))
 	 (list beg end (buffer-substring-no-properties beg end
-  ((memq type '(example-block export-block src-block))
+  ((memq type '(example-block export-block src-block comment-block))
(list (progn (goto-char (org-element-property :post-affiliated datum))
 		(line-beginning-position 2))
 	 (progn (goto-char (org-element-property :end datum))
@@ -1161,6 +1161,29 @@ (defun org-edit-export-block ()
(lambda () (org-escape-code-in-region (point-min) (point-max)
 t))
 
+(defun org-edit-comment-block ()
+  "Edit comment block at point.
+\\
+A new buffer is created and the block is copied into it, and the
+buffer is switched into Org mode.
+
+When done, exit with `\\[org-edit-src-exit]'.  The edited text \
+will then replace the area in the Org mode buffer.
+
+Throw an error when not at a comment block."
+  (interactive)
+  (let ((element (org-element-at-point)))
+(unless (and (eq (org-element-type element) 'comment-block)
+		 (org-src--on-datum-p element))
+  (user-error "Not in a comment block"))
+(org-src--edit-element
+ element
+ (org-src--construct-edit-buffer-name (buffer-name) "org")
+ 'org-mode
+ (lambda () (org-escape-code-in-region (point-min) (point-max)))
+ (org-unescape-code-in-string (org-element-property :value element)))
+t))
+
 (defun org-edit-src-code (&optional code edit-buffer-name)
   "Edit the source or example block at point.
 \\
diff --git a/lisp/org.el b/lisp/org.el
index 937892ef3..d75894590 100644
--- a/lisp/org.el
+++ b/lisp/org.el
@@ -8869,7 +8869,8 @@ (defun org-insert-structure-template (type)
 	 (region-end (and region? (copy-marker (region-end
 	 (extended? (string-match-p "\\`\\(src\\|export\\)\\'" type))
 	 (verbatim? (string-match-p
-		 (concat "\\`" (regexp-opt '("example" "export" "src")))
+		 (concat "\\`" (regexp-opt '("example" "export"
+"src" "comment")))
 		 type))
  (upcase? (string= (car (split-string type))
(upcase (car (spli

Re: [BUG] columnview cannot deal with more than 100 headings [N/A (N/A @ /home/oub/emacs/site-lisp/packages/org/)]

2022-10-16 Thread Ihor Radchenko
Uwe Brauer  writes:

> I attach a file that hopefully explains the problem.
>
> That file contains 109 heading, each heading has 17 different properties when 
> all of them are included in the 
> #+BEGIN: columnview
> #+END:
>
> Block then not all headings are included. It seems to work with 15 properties 
> but not for all 17.

I tried your file on the latest main, but I do not see anything
obviously wrong. Could you please clarify what you expect to see?

-- 
Ihor Radchenko // yantar92,
Org mode contributor,
Learn more about Org mode at .
Support Org development at ,
or support my work at 



[a kludge] (was: [BUG] columnview cannot deal with more than 100 headings [N/A (N/A @ /home/oub/emacs/site-lisp/packages/org/)])

2022-07-21 Thread Uwe Brauer
>>> "UB" == Uwe Brauer  writes:

> Hi
> I attach a file that hopefully explains the problem.

> That file contains 109 heading, each heading has 17 different properties when 
> all of them are included in the 

It seems that 

#+begin_src emacs-lisp :results silent :exports none
(org-update-all-dblocks)
(org-table-iterate-buffer-tables)
#+end_src


Somehow solves the issue.


smime.p7s
Description: S/MIME cryptographic signature