Re: [O] [BABEL] [PATCH] Make it possible to use buffer local noweb start/end patterns

2012-08-26 Thread Eric Schulte
Sean O'Halpin sean.ohal...@gmail.com writes:

 On Sat, Aug 25, 2012 at 11:50 PM, Eric Schulte eric.schu...@gmx.com wrote:
 Are you familiar with file local variables?

 See (info (emacs)Specifying File Variables)


 Yes. That's what I'm trying to enable. Without the patch, it seems that
 the =with-temp-buffer= used in =org-babel-expand-noweb-references=
 overrides any file local variables. In other words, setting
 =org-babel-noweb-wrap-start= and =org-babel-noweb-wrap-end= using
 file local variables doesn't work for me without this patch. Am I
 missing something?


Ah, right you are.  I apologize for not thoroughly understanding your
patch before replying.  I just committed this to the git repo.

Thanks for the contribution!
(and thanks for packaging your patch so that it was easy to apply)


 Regards,
 Sean

-- 
Eric Schulte
http://cs.unm.edu/~eschulte



Re: [O] [BABEL] [PATCH] Make it possible to use buffer local noweb start/end patterns

2012-08-26 Thread Sean O'Halpin
On Sun, Aug 26, 2012 at 3:31 PM, Eric Schulte eric.schu...@gmx.com wrote:
 [snip]
 I just committed this to the git repo.

 Thanks for the contribution!
 (and thanks for packaging your patch so that it was easy to apply)

Great! Thanks.



[O] [BABEL] [PATCH] Make it possible to use buffer local noweb start/end patterns

2012-08-25 Thread Sean O'Halpin
* lisp/ob.el (org-babel-expand-noweb-references): Capture current
noweb start and end patterns then use to set buffer locals in
(with-temp-buffer) form.

This solves the problem that using different patterns for
org-babel-noweb-wrap-start and org-babel-noweb-wrap-end could be done
only globally.

TINYCHANGE
---
 lisp/ob.el |4 
 1 files changed, 4 insertions(+), 0 deletions(-)

diff --git a/lisp/ob.el b/lisp/ob.el
index 7518293..f9e9ae1 100644
--- a/lisp/ob.el
+++ b/lisp/ob.el
@@ -2270,6 +2270,8 @@ block but are passed literally to the \example-block\.
  (info (or info (org-babel-get-src-block-info)))
  (lang (nth 0 info))
  (body (nth 1 info))
+(ob-nww-start org-babel-noweb-wrap-start)
+(ob-nww-end org-babel-noweb-wrap-end)
 (comment (string= noweb (cdr (assoc :comments (nth 2 info)
 (rx-prefix (concat \\( org-babel-src-name-regexp \\|
:noweb-ref[ \t]+ \\)))
@@ -2282,6 +2284,8 @@ block but are passed literally to the \example-block\.
 (org-babel-trim (buffer-string)
 index source-name evaluate prefix blocks-in-buffer)
 (with-temp-buffer
+  (org-set-local 'org-babel-noweb-wrap-start ob-nww-start)
+  (org-set-local 'org-babel-noweb-wrap-end ob-nww-end)
   (insert body) (goto-char (point-min))
   (setq index (point))
   (while (and (re-search-forward (org-babel-noweb-wrap) nil t))
-- 
1.7.0.4



Re: [O] [BABEL] [PATCH] Make it possible to use buffer local noweb start/end patterns

2012-08-25 Thread Eric Schulte
Are you familiar with file local variables?

See (info (emacs)Specifying File Variables)

Sean O'Halpin sean.ohal...@gmail.com writes:

 * lisp/ob.el (org-babel-expand-noweb-references): Capture current
 noweb start and end patterns then use to set buffer locals in
 (with-temp-buffer) form.

 This solves the problem that using different patterns for
 org-babel-noweb-wrap-start and org-babel-noweb-wrap-end could be done
 only globally.

 TINYCHANGE
 ---
  lisp/ob.el |4 
  1 files changed, 4 insertions(+), 0 deletions(-)

 diff --git a/lisp/ob.el b/lisp/ob.el
 index 7518293..f9e9ae1 100644
 --- a/lisp/ob.el
 +++ b/lisp/ob.el
 @@ -2270,6 +2270,8 @@ block but are passed literally to the 
 \example-block\.
   (info (or info (org-babel-get-src-block-info)))
   (lang (nth 0 info))
   (body (nth 1 info))
 +  (ob-nww-start org-babel-noweb-wrap-start)
 +  (ob-nww-end org-babel-noweb-wrap-end)
(comment (string= noweb (cdr (assoc :comments (nth 2 info)
(rx-prefix (concat \\( org-babel-src-name-regexp \\|
   :noweb-ref[ \t]+ \\)))
 @@ -2282,6 +2284,8 @@ block but are passed literally to the 
 \example-block\.
(org-babel-trim (buffer-string)
index source-name evaluate prefix blocks-in-buffer)
  (with-temp-buffer
 +  (org-set-local 'org-babel-noweb-wrap-start ob-nww-start)
 +  (org-set-local 'org-babel-noweb-wrap-end ob-nww-end)
(insert body) (goto-char (point-min))
(setq index (point))
(while (and (re-search-forward (org-babel-noweb-wrap) nil t))

-- 
Eric Schulte
http://cs.unm.edu/~eschulte



Re: [O] [BABEL] [PATCH] Make it possible to use buffer local noweb start/end patterns

2012-08-25 Thread Sean O'Halpin
On Sat, Aug 25, 2012 at 11:50 PM, Eric Schulte eric.schu...@gmx.com wrote:
 Are you familiar with file local variables?

 See (info (emacs)Specifying File Variables)


Yes. That's what I'm trying to enable. Without the patch, it seems that
the =with-temp-buffer= used in =org-babel-expand-noweb-references=
overrides any file local variables. In other words, setting
=org-babel-noweb-wrap-start= and =org-babel-noweb-wrap-end= using
file local variables doesn't work for me without this patch. Am I
missing something?

Regards,
Sean