Re: [O] [BUG] Re: Time range end in agenda view not displayed

2011-10-05 Thread Niels Giesen
>
> Thanks, this patch has been accepted.
>
> - Carsten
>

Thank you.

niels
-- 
http://pft.github.com


Re: [O] [BUG] Re: Time range end in agenda view not displayed

2011-10-05 Thread Carsten Dominik

Niels Giesen  gmail.com> writes:

passed."
>org-agenda-timerange-leaders)
>   (1+ (- d0 d1)) (1+ (- d2 d1)))
>  head category tags
> -(cond ((= d1 d0)
> +(cond ((and (= d1 d0) (= d2 d0))
> +   (concat "<" start-time ">--<" end-time 
> ">"))
> + ((= d1 d0)
> (concat "<" start-time ">"))
>((= d2 d0)
> (concat "<" end-time ">"))


Thanks, this patch has been accepted.

- Carsten






Re: [O] [BUG] Re: Time range end in agenda view not displayed

2011-09-30 Thread Michael Brand
Hi Niels

On Fri, Sep 30, 2011 at 16:41, Niels Giesen  wrote:
> [...] I whipped up this patch. [...] Please test (it's still young) [...]

This is a nice water proofing as I like it. The patch passes my tests.

(The patch can be found here:)
http://patchwork.newartisans.com/patch/970

Michael



Re: [O] [BUG] Re: Time range end in agenda view not displayed

2011-09-30 Thread Niels Giesen
Giovanni Ridolfi  writes:

> michael holzer  writes:
>
>> When I have an entry that contains a time range, for example:
>>
>> * timerange
>>   <2011-09-30 Fri 14:00>--<2011-09-30 Fri 18:00>
>>
>> this shows up in the agenda view as:
>>
>>   uni:14:00.. timerange
>>
>> while I would expect something like:
>>
>>   uni:14:00-18:00 timerange
>>
>
> |the manual says:
> |Time ranges can be specified with two timestamps, 
> |like ‘<2005-05-10 Tue 20:30>--<2005-05-10 Tue 22:15>’.
> |
> | 20:30-22:15 Marvin escorts the Hitchhikers to the bridge
>
> I confirm this bug.
>
> Org-mode version 7.7 0e9d401519c020af29a7e35da7acfca25e6c3be4
> GNU Emacs 23.3.1 (i386-mingw-nt5.1.2600) of 2011-03-10 on 3249CTO
>
> Giovanni
>
>

Funny enough, I noticed this too last week, so I whipped up this patch.
It inserts the range when start date is the same as the end date. Please
test (it's still young) && include in Org if you so please.
  
#+begin_src diff
>From dcf81753aa5cab311f2a3a0272e4691e4bc6ea38 Mon Sep 17 00:00:00 2001
From: Niels Giesen 
Date: Mon, 26 Sep 2011 11:43:55 +0200
Subject: [PATCH] Show timestamp ranges in agenda

* lisp/org-agenda.el (org-agenda-get-blocks): Show timestamp ranges in
  agenda if start day is same as end day
---
 lisp/org-agenda.el |4 +++-
 1 files changed, 3 insertions(+), 1 deletions(-)

diff --git a/lisp/org-agenda.el b/lisp/org-agenda.el
index b1fa5f5..e8effd5 100644
--- a/lisp/org-agenda.el
+++ b/lisp/org-agenda.el
@@ -5396,7 +5396,9 @@ FRACTION is what fraction of the head-warning time has 
passed."
 org-agenda-timerange-leaders)
(1+ (- d0 d1)) (1+ (- d2 d1)))
   head category tags
-  (cond ((= d1 d0)
+  (cond ((and (= d1 d0) (= d2 d0))
+ (concat "<" start-time ">--<" end-time 
">"))
+ ((= d1 d0)
  (concat "<" start-time ">"))
 ((= d2 d0)
  (concat "<" end-time ">"))
-- 
1.7.4.1
#+end_src

Regards, Niels.
-- 
http://pft.github.com/



[O] [BUG] Re: Time range end in agenda view not displayed

2011-09-30 Thread Giovanni Ridolfi
michael holzer  writes:

> When I have an entry that contains a time range, for example:
>
> * timerange
>   <2011-09-30 Fri 14:00>--<2011-09-30 Fri 18:00>
>
> this shows up in the agenda view as:
>
>   uni:14:00.. timerange
>
> while I would expect something like:
>
>   uni:14:00-18:00 timerange
>

|the manual says:
|Time ranges can be specified with two timestamps, 
|like ‘<2005-05-10 Tue 20:30>--<2005-05-10 Tue 22:15>’.
|
| 20:30-22:15 Marvin escorts the Hitchhikers to the bridge

I confirm this bug.

Org-mode version 7.7 0e9d401519c020af29a7e35da7acfca25e6c3be4
GNU Emacs 23.3.1 (i386-mingw-nt5.1.2600) of 2011-03-10 on 3249CTO

Giovanni