Re: [O] [PATCH] Avoid lisp error with (org-deadline nil +1d)
On Thu, Nov 24 2011, Nick Dokos wrote: Are they free variable warnings? If so, you now know how to fix them: go wild :-) All right, done so... ;) -- Peter
Re: [O] [PATCH] Avoid lisp error with (org-deadline nil +1d)
On Wed, Nov 23 2011, Carsten Dominik wrote: Fixed, thanks, please verify. Verified: ok, thanks. Is `(defvar parse-time-weekdays)' still needed then? And if yes, why? -- Peter
Re: [O] [PATCH] Avoid lisp error with (org-deadline nil +1d)
Peter Münster pmli...@free.fr wrote: On Wed, Nov 23 2011, Carsten Dominik wrote: Fixed, thanks, please verify. Verified: ok, thanks. Is `(defvar parse-time-weekdays)' still needed then? And if yes, why? Generally speaking, defvars like this tell the compiler to shut up about the free variable. You can see if it is needed, by commenting out the defvar and then trying to compile the file. Nick
Re: [O] [PATCH] Avoid lisp error with (org-deadline nil +1d)
On Wed, Nov 23 2011, Nick Dokos wrote: Generally speaking, defvars like this tell the compiler to shut up about the free variable. You can see if it is needed, by commenting out the defvar and then trying to compile the file. Indeed, now there are 30 warnings instead of only 29 ... ;) Thanks for the explanation! -- Peter
Re: [O] [PATCH] Avoid lisp error with (org-deadline nil +1d)
Peter Münster pmli...@free.fr wrote: On Wed, Nov 23 2011, Nick Dokos wrote: Generally speaking, defvars like this tell the compiler to shut up about the free variable. You can see if it is needed, by commenting out the defvar and then trying to compile the file. Indeed, now there are 30 warnings instead of only 29 ... ;) Thanks for the explanation! Are they free variable warnings? If so, you now know how to fix them: go wild :-) Nick
Re: [O] [PATCH] Avoid lisp error with (org-deadline nil +1d)
On 21.11.2011, at 23:39, Peter Münster wrote: * lisp/org.el (parse-time-weekdays): Must not be void. TINYCHANGE --- lisp/org.el |2 +- 1 files changed, 1 insertions(+), 1 deletions(-) diff --git a/lisp/org.el b/lisp/org.el index 253703b..41d418a 100644 --- a/lisp/org.el +++ b/lisp/org.el @@ -15229,7 +15229,7 @@ user. (setq org-read-date-analyze-futurep futurep) (list second minute hour day month year))) -(defvar parse-time-weekdays) +(defvar parse-time-weekdays nil) This is not allowed, we cannot define a variable defined in another package. Can you send a backtrace of the error, please? - Carsten (defun org-read-date-get-relative (s today default) Check string S for special relative date string. -- 1.7.3.4
Re: [O] [PATCH] Avoid lisp error with (org-deadline nil +1d)
On Tue, Nov 22 2011, Carsten Dominik wrote: This is not allowed, we cannot define a variable defined in another package. Oh, pardon. Can you send a backtrace of the error, please? Of course (from emacs -Q): --8---cut here---start-8--- Debugger entered--Lisp error: (void-variable parse-time-weekdays) org-read-date-get-relative(+1d (20172 36366 853978) (20170 55280)) org-read-date-analyze(+1d (20170 55280) (0 0 0 22 11 2011 2 nil 3600)) byte-code(\306\203J. \203. ;\203J.\307\310 \\203J.\212\311\312!\210\212\313 \210`).\314\315=\203-. \202..\f\n\312#\203I.\316\317!.\320\321\322.!\.3.\205G.\323.!.4)\203y. ;\203i.\307\310 \\203i.\320\321\324.3\325.3!#\\202x. \206x.\326\327\330\327\211.3.4..5\203\244.\331\235\203\244.\315=\203\217.6\202\221.7\332\261.\210\333 .8\327\211\211.9C.\210\327.\212\214\327\211\211\211\211.:. ;..=\311\312!\210\334.\335P!\210\317\225b\210i.=\336\225b\210m\203\324.\337c\210\202\327.\317u\210\204\351.\334\340.?P!\204\351.\341\342\327\\210\334.!\204\f.\334\343.@\344Q!\203\f.\316\317!.A\232\204\f.\336\224\336\225}\210\202!.\345\337!\210\346u\210``}\210.B\203!.\347.=!\210.CB..\203s.\211A.@\211.;\315=\203C.\314 \327\312#\204b.;\350=\203R.\314\f\327\312#\204b.;\351=\203'.\314.D\327\312#\203'.\352\353!\210\334\354!\203'.\352\353!\210\202'.\334\355!\203}.\352\353!\210.B\203\213.n\203\213.\347.=!\210\203\375.n\204\237.`Sf\356=\204\237.\332\202\240.\353\315=\203\253.6\202\276.\350=\203\266.7\202\276.\351=\205\276.E\332\261.\210\333 .8\206\321.\351=\205\321.F\351=\327\211.9C.n\204\367.`Sf\356=\204\367.\327f\357\204\367.m\204\367.\332\202\370.\353c\210\317\210eb\210~\210\334\360!\203.`Sf\361\232\203.`S\362 |\210..\207 [what time end org-scheduled-time-regexp org-deadline-time-regexp ts (scheduled deadline) string-match ^[-+]+[0-9] org-back-to-heading t outline-next-heading re-search-forward scheduled match-string 1 apply encode-time org-parse-time-string org-get-compact-tod org-read-date-analyze decode-time org-read-date nil to-time (scheduled deadline) org-insert-time-stamp looking-at \\( *\\)[^.\n]* 0 \n [ ]* throw exit [^.\n]*? [^.\n]* insert-before-markers -1 org-indent-to-column deadline closed replace-match --+[^]+ ^[ ]+ 32 (32 10) [ ]*\n 10 ...] 8) org-add-planning-info(deadline +1d closed) org-deadline(nil +1d) eval((org-deadline nil +1d) nil) eval-expression((org-deadline nil +1d) nil) call-interactively(eval-expression nil nil) --8---cut here---end---8--- -- Peter
Re: [O] [PATCH] Avoid lisp error with (org-deadline nil +1d)
Fixed, thanks, please verify. - Carsten On 23.11.2011, at 07:14, Peter Münster wrote: On Tue, Nov 22 2011, Carsten Dominik wrote: This is not allowed, we cannot define a variable defined in another package. Oh, pardon. Can you send a backtrace of the error, please? Of course (from emacs -Q): --8---cut here---start-8--- Debugger entered--Lisp error: (void-variable parse-time-weekdays) org-read-date-get-relative(+1d (20172 36366 853978) (20170 55280)) org-read-date-analyze(+1d (20170 55280) (0 0 0 22 11 2011 2 nil 3600)) byte-code(\306\203J. \203. ;\203J.\307\310 \\203J.\212\311\312!\210\212\313 \210`).\314\315=\203-. \202..\f\n\312#\203I.\316\317!.\320\321\322.!\.3.\205G.\323.!.4)\203y. ;\203i.\307\310 \\203i.\320\321\324.3\325.3!#\\202x. \206x.\326\327\330\327\211.3.4..5\203\244.\331\235\203\244.\315=\203\217.6\202\221.7\332\261.\210\333 .8\327\211\211.9C.\210\327.\212\214\327\211\211\211\211.:. ;..=\311\312!\210\334.\335P!\210\317\225b\210i.=\336\225b\210m\203\324.\337c\210\202\327.\317u\210\204\351.\334\340.?P!\204\351.\341\342\327\\210\334.!\204\f.\334\343.@\344Q!\203\f.\316\317!.A\232\204\f.\336\224\336\225}\210\202!.\345\337!\210\346u\210``}\210.B\203!.\347.=!\210.CB..\203s.\211A.@\211.;\315=\203C.\314 \327\312#\204b.;\350=\203R.\314\f\327\312#\204b.;\351=\203'.\314.D\327\312#\203'.\352\353!\210\334\354!\203'.\352\353!\210\202'.\334\355!\203}.\352\353!\210.B\203\213.n\203\213.\347.=!\210\203\375.n\204\237.`Sf\356=\204\237.\332\202\240.\353\315=\203\253.6\202\276.\350=\203\266.7\202\276.\351=\205\276.E\332\261.\210\333 .8\206\321.\351=\205\321.F\351=\327\211.9C.n\204\367.`Sf\356=\204\367.\327f\357\204\367.m\204\367.\332\202\370.\353c\210\317\210eb\210~\210\334\360!\203.`Sf\361\232\203.`S\362 |\210..\207 [what time end org-scheduled-time-regexp org-deadline-time-regexp ts (scheduled deadline) string-match ^[-+]+[0-9] org-back-to-heading t outline-next-heading re-search-forward scheduled match-string 1 apply encode-time org-parse-time-string org-get-compact-tod org-read-date-analyze decode-time org-read-date nil to-time (scheduled deadline) org-insert-time-stamp looking-at \\( *\\)[^.\n]* 0 \n [ ]* throw exit [^.\n]*? [^.\n]* insert-before-markers -1 org-indent-to-column deadline closed replace-match --+[^]+ ^[ ]+ 32 (32 10) [ ]*\n 10 ...] 8) org-add-planning-info(deadline +1d closed) org-deadline(nil +1d) eval((org-deadline nil +1d) nil) eval-expression((org-deadline nil +1d) nil) call-interactively(eval-expression nil nil) --8---cut here---end---8--- -- Peter
[O] [PATCH] Avoid lisp error with (org-deadline nil +1d)
* lisp/org.el (parse-time-weekdays): Must not be void. TINYCHANGE --- lisp/org.el |2 +- 1 files changed, 1 insertions(+), 1 deletions(-) diff --git a/lisp/org.el b/lisp/org.el index 253703b..41d418a 100644 --- a/lisp/org.el +++ b/lisp/org.el @@ -15229,7 +15229,7 @@ user. (setq org-read-date-analyze-futurep futurep) (list second minute hour day month year))) -(defvar parse-time-weekdays) +(defvar parse-time-weekdays nil) (defun org-read-date-get-relative (s today default) Check string S for special relative date string. -- 1.7.3.4
