[O] [PATCH] Respect org-attach-commit everywhere

2017-06-17 Thread Allen Li

TINYCHANGE

* lisp/org-attach.el (org-attach-delete-one): Respect org-attach-commit
(org-attach-delete-all): Respect org-attach-commit
(org-attach-sync): Respect org-attach-commit
---
 lisp/org-attach.el | 9 ++---
 1 file changed, 6 insertions(+), 3 deletions(-)

diff --git a/lisp/org-attach.el b/lisp/org-attach.el
index 8093527ae..bfd7106b0 100644
--- a/lisp/org-attach.el
+++ b/lisp/org-attach.el
@@ -459,7 +459,8 @@ The attachment is created as an Emacs buffer."
 (unless (file-exists-p file)
   (error "No such attachment: %s" file))
 (delete-file file)
-(org-attach-commit)))
+(when org-attach-commit
+  (org-attach-commit
 
 (defun org-attach-delete-all (&optional force)
   "Delete all attachments from the current task.
@@ -475,14 +476,16 @@ A safer way is to open the directory in dired and delete 
from there."
 (y-or-n-p "Are you sure you want to remove all attachments of 
this entry? ")))
   (shell-command (format "rm -fr %s" attach-dir))
   (message "Attachment directory removed")
-  (org-attach-commit)
+  (when org-attach-commit
+(org-attach-commit))
   (org-attach-untag
 
 (defun org-attach-sync ()
   "Synchronize the current tasks with its attachments.
 This can be used after files have been added externally."
   (interactive)
-  (org-attach-commit)
+  (when org-attach-commit
+(org-attach-commit))
   (when (and org-attach-file-list-property (not org-attach-inherited))
 (org-entry-delete (point) org-attach-file-list-property))
   (let ((attach-dir (org-attach-dir)))
-- 
2.13.1



signature.asc
Description: PGP signature


Re: [O] [PATCH] Respect org-attach-commit everywhere

2017-06-17 Thread Nicolas Goaziou
Hello,

Allen Li  writes:

> TINYCHANGE
>
> * lisp/org-attach.el (org-attach-delete-one): Respect org-attach-commit
> (org-attach-delete-all): Respect org-attach-commit
> (org-attach-sync): Respect org-attach-commit

Applied. Thank you.

If you plan to provide more patches, please consider signing FSF papers!


Regards,

-- 
Nicolas Goaziou