Re: [O] [PATCH] fix org-num-mode detect enabled already issue
Hello, stardiviner writes: > And here is the steps to reproduce this issue: > > my config: > > (require 'org-num) > (setq org-num-skip-footnotes t) > (add-hook 'org-mode-hook #'org-num-mode) > > 1. Then open an Org file, it has `org-num-mode` enabled because upper >config added to hook. > > 2. Execute command with `[M-x org-mode]` again, then it will become as >in screenshot. OK, I see. Fixed. Thank you! Regards, -- Nicolas Goaziou
Re: [O] [PATCH] fix org-num-mode detect enabled already issue
I fixed my previous patch which work in reverse direction. modified lisp/org-num.el @@ -438,17 +438,16 @@ NUMBERING is a list of numbers." (define-minor-mode org-num-mode "Dynamic numbering of headlines in an Org buffer." :lighter " o#" - (cond - (org-num-mode -(unless (derived-mode-p 'org-mode) - (user-error "Cannot activate headline numbering outside Org mode")) -(setq org-num--numbering nil) -(setq org-num--overlays (nreverse (org-num--number-region nil nil))) -(add-hook 'after-change-functions #'org-num--verify nil t)) - (t + (if org-num-mode + (progn + (unless (derived-mode-p 'org-mode) + (user-error "Cannot activate headline numbering outside Org mode")) + (setq org-num--numbering nil) + (setq org-num--overlays (nreverse (org-num--number-region nil nil))) + (add-hook 'after-change-functions #'org-num--verify nil t)) (mapc #'delete-overlay org-num--overlays) (setq org-num--overlays nil) -(remove-hook 'after-change-functions #'org-num--verify t +(remove-hook 'after-change-functions #'org-num--verify t))) -- [ stardiviner ] I try to make every word tell the meaning what I want to express. Blog: https://stardiviner.github.io/ IRC(freenode): stardiviner, Matrix: stardiviner GPG: F09F650D7D674819892591401B5DF1C95AE89AC3
Re: [O] [PATCH] fix org-num-mode detect enabled already issue
Here is the screenshot which can demostrate this issue: And here is the steps to reproduce this issue: my config: (require 'org-num) (setq org-num-skip-footnotes t) (add-hook 'org-mode-hook #'org-num-mode) 1. Then open an Org file, it has `org-num-mode` enabled because upper config added to hook. 2. Execute command with `[M-x org-mode]` again, then it will become as in screenshot. -- [ stardiviner ] I try to make every word tell the meaning what I want to express. Blog: https://stardiviner.github.io/ IRC(freenode): stardiviner, Matrix: stardiviner GPG: F09F650D7D674819892591401B5DF1C95AE89AC3
Re: [O] [PATCH] fix org-num-mode detect enabled already issue
Hello, stardiviner writes: > When I execute command `[M-x org-mode]` on an Org buffer which is > already have `org-num-mode` enabled. It will re-generate overlay. I don't understand the issue you are encountering. Could you elaborate? Regards, -- Nicolas Goaziou
[O] [PATCH] fix org-num-mode detect enabled already issue
When I execute command `[M-x org-mode]` on an Org buffer which is already have `org-num-mode` enabled. It will re-generate overlay. Here is a quick patch: modified lisp/org-num.el @@ -438,17 +438,16 @@ NUMBERING is a list of numbers." (define-minor-mode org-num-mode "Dynamic numbering of headlines in an Org buffer." :lighter " o#" - (cond - (org-num-mode + (if org-num-mode + (progn + (mapc #'delete-overlay org-num--overlays) + (setq org-num--overlays nil) + (remove-hook 'after-change-functions #'org-num--verify t)) (unless (derived-mode-p 'org-mode) (user-error "Cannot activate headline numbering outside Org mode")) (setq org-num--numbering nil) (setq org-num--overlays (nreverse (org-num--number-region nil nil))) -(add-hook 'after-change-functions #'org-num--verify nil t)) - (t -(mapc #'delete-overlay org-num--overlays) -(setq org-num--overlays nil) -(remove-hook 'after-change-functions #'org-num--verify t +(add-hook 'after-change-functions #'org-num--verify nil t))) -- [ stardiviner ] I try to make every word tell the meaning what I want to express. Blog: https://stardiviner.github.io/ IRC(freenode): stardiviner, Matrix: stardiviner GPG: F09F650D7D674819892591401B5DF1C95AE89AC3
