Re: [O] [PATCH] lisp/ob-sql.el: Fix filename conversion in minGW environment.

[Nicolas Goaziou]

Hello,

Xi Shen  writes:

> Subject: [PATCH] lisp/ob-sql.el: Fix filename conversion in minGW environment.
>
> (org-babel-sql-convert-standard-filename): If it is not in Cygwin
> environment, and `system-nt' is "windows-nt", Emacs must be in minGW
> or MSYS environment, can can handle Windows filename correctly.

Applied. Thank you.

Regards,

-- 
Nicolas Goaziou

Re: [O] [PATCH] lisp/ob-sql.el: Fix filename conversion in minGW environment.

[Xi Shen]

On Wed, Apr 12, 2017, 11:16 Xi Shen  wrote:

> Hi,
>
> Regarding a patch I made early. Ref. title: [PATCH] ob-sql.el: Support
> sqlcmd and cygwin environment.
>
> I found it does not for Emacs for Windows. More generally, it does not
> work in minGW or MSYS environments. I think it is because minGW is not a
> POSIX environment, and applications in minGW can actually talk to Windows
> system and handle Windows file path directly.
>
> Because there's no official way to identify if Emacs is in minGW
> environment, I must roll out cygwin environment first, then I test if it is
> in "windows-nt" environment.
>
> Please review the patch, and let me know if you have any comments/question.
>
>
> Thanks,
> David
>
>

[O] [PATCH] lisp/ob-sql.el: Fix filename conversion in minGW environment.

[Xi Shen]

Hi,

Regarding a patch I made early. Ref. title: [PATCH] ob-sql.el: Support
sqlcmd and cygwin environment.

I found it does not for Emacs for Windows. More generally, it does not work
in minGW or MSYS environments. I think it is because minGW is not a POSIX
environment, and applications in minGW can actually talk to Windows system
and handle Windows file path directly.

Because there's no official way to identify if Emacs is in minGW
environment, I must roll out cygwin environment first, then I test if it is
in "windows-nt" environment.

Please review the patch, and let me know if you have any comments/question.


Thanks,
David


ob-sql.el.patch
Description: Binary data