Re: [O] [PATCH] lisp/ox-html.el: reorder output of meta data in head

[Nicolas Goaziou]

Hello,

apers...@lbl.gov writes:

 * lisp/ox-html.el (org-html--build-meta-info ): charset and viewport
   meta data should come first in `head'. As mentioned for example in:
   - https://code.google.com/p/doctype-mirror/wiki/MetaCharsetAttribute
   - http://getbootstrap.com/getting-started/#template
   Only reordered output, no other code changes.

Applied. Thank you.


Regards,

-- 
Nicolas Goaziou

Re: [O] [PATCH] lisp/ox-html.el: reorder output of meta data in head

[Arun Persaud]

Hi

just as a quick follow up. I found this earlier message on the topic

http://thread.gmane.org/gmane.emacs.orgmode/84306/focus=84355

I would like to push for a change though. I don't have a test case where
charset doesn't work, but
https://code.google.com/p/doctype-mirror/wiki/MetaCharsetAttribute
claims that a title tag before a charset tag would not work in all
browsers which would be nice and seems easy to fix.

Arun

[O] [PATCH] lisp/ox-html.el: reorder output of meta data in head

[apersaud]

From: Arun Persaud apers...@lbl.gov

* lisp/ox-html.el (org-html--build-meta-info ): charset and viewport
  meta data should come first in `head'. As mentioned for example in:
  - https://code.google.com/p/doctype-mirror/wiki/MetaCharsetAttribute
  - http://getbootstrap.com/getting-started/#template
  Only reordered output, no other code changes.

TINYCHANGE
---
 lisp/ox-html.el | 30 +++---
 1 file changed, 15 insertions(+), 15 deletions(-)

diff --git a/lisp/ox-html.el b/lisp/ox-html.el
index 75c6993..d50ff5e 100644
--- a/lisp/ox-html.el
+++ b/lisp/ox-html.el
@@ -1701,7 +1701,6 @@ INFO is a plist used as a communication channel.
 'mime-charset))
 iso-8859-1)))
 (concat
- (format title%s/title\n title)
  (when (plist-get info :time-stamp-file)
(format-time-string
(concat !-- 
@@ -1714,6 +1713,20 @@ INFO is a plist used as a communication channel.
 meta  http-equiv=\Content-Type\ content=\text/html;charset=%s\
 info))
   charset) \n
+ (let ((viewport-options
+   (org-remove-if-not (lambda (cell) (org-string-nw-p (cadr cell)))
+  (plist-get info :html-viewport
+   (and viewport-options
+   (concat
+(org-html-close-tag
+ meta
+ (format  name=\viewport\ content=\%s\
+ (mapconcat
+  (lambda (elm) (format %s=%s (car elm) (cadr elm)))
+  viewport-options , ))
+ info)
+\n)))
+ (format title%s/title\n title)
  (org-html-close-tag meta  name=\generator\ content=\Org-mode\ 
info)
  \n
  (and (org-string-nw-p author)
@@ -1736,20 +1749,7 @@ INFO is a plist used as a communication channel.
   (format  name=\keywords\ content=\%s\
   (funcall protect-string keywords))
   info)
-  \n))
- (let ((viewport-options
-   (org-remove-if-not (lambda (cell) (org-string-nw-p (cadr cell)))
-  (plist-get info :html-viewport
-   (and viewport-options
-   (concat
-(org-html-close-tag
- meta
- (format  name=\viewport\ content=\%s\
- (mapconcat
-  (lambda (elm) (format %s=%s (car elm) (cadr elm)))
-  viewport-options , ))
- info)
-\n))
+  \n)
 
 (defun org-html--build-head (info)
   Return information for the head../head of the HTML output.
-- 
2.4.2