Re: [O] [PATCH] ob-sql: Don't print out the command

[Nicolas Goaziou]

Hello,

Sacha Chua  writes:

> * lisp/ob-sql.el (org-babel-execute:sql): Don't print out the command
>   in the echo area, since it could be very long.

Applied. Thank you.


Regards,

-- 
Nicolas Goaziou

[O] [PATCH] ob-sql: Don't print out the command

[Sacha Chua]

Out of curiosity, is there a particular reason why ob-sql messages the
whole command, aside from debugging/development purposes? funnykitty on
#emacs said that executing a long command set was rather slow because of
the message. I've attached a tiny patch to remove the (message ...) in
case it's left over from debugging, and I've suggested that funnykitty
either use cl-flet to override message or redefine org-babel-execute:sql
in the meantime.

>From 04da1fb280847613290e11ce494ba58f17e951ac Mon Sep 17 00:00:00 2001
From: Sacha Chua 
Date: Thu, 24 Dec 2015 12:36:40 -0500
Subject: [PATCH] ob-sql: Don't print out the command

* lisp/ob-sql.el (org-babel-execute:sql): Don't print out the command
  in the echo area, since it could be very long.
---
 lisp/ob-sql.el | 1 -
 1 file changed, 1 deletion(-)

diff --git a/lisp/ob-sql.el b/lisp/ob-sql.el
index 275370e..14d5c61 100644
--- a/lisp/ob-sql.el
+++ b/lisp/ob-sql.el
@@ -175,7 +175,6 @@ SET COLSEP '|'
 ")
 	 (_ ""))
(org-babel-expand-body:sql body params)))
-(message command)
 (org-babel-eval command "")
 (org-babel-result-cond result-params
   (with-temp-buffer
-- 
2.6.3


Sacha