Re: [O] [PATCH] org-colview.el: Fix typo in function name

[Nicolas Goaziou]

Lele Gaifax  writes:

> Nicolas Goaziou  writes:
>
>> I see you didn't add TINYCHANGE at the end of the commit message.
>> I assume you have signed FSF papers already. Am I correct?
>
> Yes, sorry for not mentioning it explicitly.

No problem. I just wanted to be sure. 

I applied your patch. Thank you again.

Regards,

Re: [O] [PATCH] org-colview.el: Fix typo in function name

[Lele Gaifax]

Nicolas Goaziou  writes:

> I see you didn't add TINYCHANGE at the end of the commit message.
> I assume you have signed FSF papers already. Am I correct?

Yes, sorry for not mentioning it explicitly.

ciao, lele.
-- 
nickname: Lele Gaifax | Quando vivrò di quello che ho pensato ieri
real: Emanuele Gaifas | comincerò ad aver paura di chi mi copia.
l...@metapensiero.it  | -- Fortunato Depero, 1929.

Re: [O] [PATCH] org-colview.el: Fix typo in function name

[Nicolas Goaziou]

Lele Gaifax  writes:

> Here it is!

It looks good. Thank you.

> From 7919e3ecb9362451a2f1f5e919e378dadadaf8de Mon Sep 17 00:00:00 2001
> From: Lele Gaifax 
> Date: Fri, 24 Jun 2016 14:14:34 +0200
> Subject: [PATCH] org-colview.el: Fix typo in function name
>
> * lisp/org-colview.el (org-columns-hscroll-title): rename from
>   `org-columns-hscoll-title'
> (org-columns--display-here-title): adjust reference to renamed function
> (org-columns-remove-overlays): likewise

I see you didn't add TINYCHANGE at the end of the commit message.
I assume you have signed FSF papers already. Am I correct?

Regards,

[O] [PATCH] org-colview.el: Fix typo in function name

[Lele Gaifax]

>>> BTW, in lisp/org-colview.el there is what seems a typo in the name of the
>>> function `org-columns-hscoll-title`: since accordingly with "git grep" it is
>>> referenced in two places and only in that source, is the following
>>> acceptable?
>>
>> Sure. Could you provide a proper commit message and send the patch using
>> "git format-patch" command? See
>>  for details.

Here it is!

>From 7919e3ecb9362451a2f1f5e919e378dadadaf8de Mon Sep 17 00:00:00 2001
From: Lele Gaifax 
Date: Fri, 24 Jun 2016 14:14:34 +0200
Subject: [PATCH] org-colview.el: Fix typo in function name

* lisp/org-colview.el (org-columns-hscroll-title): rename from
  `org-columns-hscoll-title'
(org-columns--display-here-title): adjust reference to renamed function
(org-columns-remove-overlays): likewise
---
 lisp/org-colview.el | 6 +++---
 1 file changed, 3 insertions(+), 3 deletions(-)

diff --git a/lisp/org-colview.el b/lisp/org-colview.el
index 864b221..d26f16a 100644
--- a/lisp/org-colview.el
+++ b/lisp/org-colview.el
@@ -438,9 +438,9 @@ for the duration of the command.")
   (org-add-props " " nil 'display '(space :align-to 0))
   (org-add-props (substring title 0 -1) nil 'face 'org-column-title)))
 (setq org-columns-previous-hscroll -1)
-(add-hook 'post-command-hook 'org-columns-hscoll-title nil 'local)))
+(add-hook 'post-command-hook 'org-columns-hscroll-title nil 'local)))
 
-(defun org-columns-hscoll-title ()
+(defun org-columns-hscroll-title ()
   "Set the `header-line-format' so that it scrolls along with the table."
   (sit-for .0001) ; need to force a redisplay to update window-hscroll
   (when (not (= (window-hscroll) org-columns-previous-hscroll))
@@ -463,7 +463,7 @@ for the duration of the command.")
   (when (local-variable-p 'org-previous-header-line-format)
(setq header-line-format org-previous-header-line-format)
(kill-local-variable 'org-previous-header-line-format)
-   (remove-hook 'post-command-hook 'org-columns-hscoll-title 'local))
+   (remove-hook 'post-command-hook 'org-columns-hscroll-title 'local))
   (move-marker org-columns-begin-marker nil)
   (move-marker org-columns-top-level-marker nil)
   (org-with-silent-modifications
-- 
2.8.1

Thank you,
ciao, lele.
-- 
nickname: Lele Gaifax | Quando vivrò di quello che ho pensato ieri
real: Emanuele Gaifas | comincerò ad aver paura di chi mi copia.
l...@metapensiero.it  | -- Fortunato Depero, 1929.