Re: [O] [PATCH] orgcontacts.el: Fix `date' being broken in `org-contacts-anniversaries'.

2013-03-03 Thread Bastien
Hi Rüdiger,

Rüdiger Sonderfeld  writes:

> * contrib/lisp/org-contacts.el: Add defvar for date.  Similar to org.el.
>
>   (org-contacts-anniversaries): Setting date to nil breaks the
>   function.  Bug was introduced in e4cebbe40.

Applied, thanks a lot.

-- 
 Bastien



[O] [PATCH] orgcontacts.el: Fix `date' being broken in `org-contacts-anniversaries'.

2013-03-03 Thread Rüdiger Sonderfeld
* contrib/lisp/org-contacts.el: Add defvar for date.  Similar to org.el.

  (org-contacts-anniversaries): Setting date to nil breaks the
  function.  Bug was introduced in e4cebbe40.

Signed-off-by: Rüdiger Sonderfeld 
---
 contrib/lisp/org-contacts.el | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

diff --git a/contrib/lisp/org-contacts.el b/contrib/lisp/org-contacts.el
index 4ffe360..d849e7f 100644
--- a/contrib/lisp/org-contacts.el
+++ b/contrib/lisp/org-contacts.el
@@ -499,6 +499,7 @@ A group FOO is composed of contacts with the tag FOO."
;; show the next heading
(org-flag-heading nil)))
 
+(org-no-warnings (defvar date)) ;; unprefixed, from calendar.el
 (defun org-contacts-anniversaries (&optional field format)
   "Compute FIELD anniversary for each contact, returning FORMAT.
 Default FIELD value is \"BIRTHDAY\".
@@ -512,8 +513,7 @@ Format is a string matching the following format 
specification:
   (let ((calendar-date-style 'american)
 (entry ""))
 (unless format (setq format org-contacts-birthday-format))
-(loop with date = nil  ; FIXME: prevent a warning
- for contact in (org-contacts-filter)
+(loop for contact in (org-contacts-filter)
   for anniv = (let ((anniv (cdr (assoc-string
  (or field 
org-contacts-birthday-property)
  (caddr contact)
-- 
1.8.1.1