Re: [O] [PATCH 00/10] babel cleanups
Eric Schulte writes: > I've reviewed these patches and applied most of them. > > Let me express a heartfelt THANKS. It is always good to have more eyes > on code (as these patches indicate), and I'm very happy you're learning > the internals of Org mode's code block support. Although these patches > are mainly refactoring I'm excited to have your help in bug-fixing and > feature enhancements in the future. Yes, thanks a lot to both of you! -- Bastien
Re: [O] [PATCH 00/10] babel cleanups
Eric Schulte writes: > Aaron Ecay writes: > >> Here are several patches to fix things in and around org-babel. >> They're each independent of the others (and hopefully all apply >> cleanly, without depending on other members of the series). Here's a >> little summary of each: >> > > Thanks for these patches, many look like obvious wins, some less so. I > likely won't have time to review them (or do much of anything) in the > near term, but at some point I will make time to review them and reply > here. I've reviewed these patches and applied most of them. Let me express a heartfelt THANKS. It is always good to have more eyes on code (as these patches indicate), and I'm very happy you're learning the internals of Org mode's code block support. Although these patches are mainly refactoring I'm excited to have your help in bug-fixing and feature enhancements in the future. Cheers, -- Eric Schulte http://cs.unm.edu/~eschulte
Re: [O] [PATCH 00/10] babel cleanups
Aaron Ecay writes: > Here are several patches to fix things in and around org-babel. > They're each independent of the others (and hopefully all apply > cleanly, without depending on other members of the series). Here's a > little summary of each: > Thanks for these patches, many look like obvious wins, some less so. I likely won't have time to review them (or do much of anything) in the near term, but at some point I will make time to review them and reply here. -- Eric Schulte http://cs.unm.edu/~eschulte
[O] [PATCH 00/10] babel cleanups
Here are several patches to fix things in and around org-babel. They're each independent of the others (and hopefully all apply cleanly, without depending on other members of the series). Here's a little summary of each: Aaron Ecay (10): Fix org-babel-R-initiate-session -> An obvious bugfix Clean up org-babel-expand-body: functions for awk and picolisp -> Makes these functions consistent with other babel languages, though I don't use these languages so can't test Clean up various org-babel-*-maybe commands -> Code simplification and avoids an expensive operation under some circumstances Add 'light argument to some uses of org-babel-get-src-block-info -> Avoids an expensive operation Remove info arg from several org-babel functions -> Code cleanup. Could break third-party code. Use prefix arg in org-edit-special -> Makes the function consistent with its docstring, although the new behavior is somewhat odd (C-u C-c ' becomes basically the same as C-c C-v C-z, AFAICT) Simplify org-babel-execute-src-block -> Makes data flow cleaner through this function Fix testing/lisp/test-ob-emacs-lisp.el -> Obvious bugfix Remove org-babel-check-confirm-evaluate macro -> Refactoring. Of all the patches, I am least sure of this one. It is a complicated operation however you slice it, but I find the approach where the complexity is local easier to understand. Deserves careful review, since it touches code which decides whether to evaluate source blocks. Read: has security implications. Document how :var introduces code block dependencies. -> Documentation. doc/org.texi | 9 +++ lisp/ob-R.el | 20 +++-- lisp/ob-awk.el | 2 +- lisp/ob-core.el| 156 + lisp/ob-picolisp.el| 2 +- lisp/ob-tangle.el | 2 +- lisp/org.el| 7 +- testing/lisp/test-ob-emacs-lisp.el | 19 +++-- 8 files changed, 112 insertions(+), 105 deletions(-) -- 1.8.2
