[O] [PATH] Customize org-annotate-file

2014-05-09 Thread Daimrod 
Hi,

Here is a small patch for contrib/lisp/org-annotate-file.el.

This patch creates a customization group for org-annotate-file (child of
the org group) and convert defvars to defcustoms.

Okay to push?

From ea5be445776f7d139f52b38306552e0012b47d0a Mon Sep 17 00:00:00 2001
From: =?UTF-8?q?Gr=C3=A9goire=20Jadi?= gregoire.j...@gmail.com
Date: Fri, 9 May 2014 14:58:59 +0900
Subject: [PATCH] contrib/lisp/org-annotate-file.el: Create a customization
 group and convert `defvar' customization variables to `defcustom'

* contrib/lisp/org-annotate-file.el (org-annotate-file): New customization
group.

(org-annotate-file-storage-file org-annotate-file-add-search
org-annotate-file-always-open): Convert `defvar' symbols to `defcustom' using the new group.
---
 contrib/lisp/org-annotate-file.el | 26 ++
 1 file changed, 18 insertions(+), 8 deletions(-)

diff --git a/contrib/lisp/org-annotate-file.el b/contrib/lisp/org-annotate-file.el
index 8fbb590..b8e8bd9 100644
--- a/contrib/lisp/org-annotate-file.el
+++ b/contrib/lisp/org-annotate-file.el
@@ -59,14 +59,24 @@
 
 (require 'org)
 
-(defvar org-annotate-file-storage-file ~/.org-annotate-file.org
-  File in which to keep annotations.)
-
-(defvar org-annotate-file-add-search nil
-  If non-nil, add a link as a second level to the actual file location.)
-
-(defvar org-annotate-file-always-open t
-  If non-nil, always expand the full tree when visiting the annotation file.)
+(defgroup org-annotate-file nil
+  Org Annotate
+  :group 'org)
+
+(defcustom org-annotate-file-storage-file ~/.org-annotate-file.org
+  File in which to keep annotations.
+  :group 'org-annotate-file
+  :type 'file)
+
+(defcustom org-annotate-file-add-search nil
+  If non-nil, add a link as a second level to the actual file location.
+  :group 'org-annotate-file
+  :type 'boolean)
+
+(defcustom org-annotate-file-always-open t
+  If non-nil, always expand the full tree when visiting the annotation file.
+  :group 'org-annotate-file
+  :type 'boolean)
 
 (defun org-annotate-file-ellipsify-desc (string optional after)
   Return shortened STRING with appended ellipsis.
-- 
1.8.0.2722.gc0242e5


-- 
Daimrod/Greg

Re: [O] [PATH] Customize org-annotate-file

2014-05-09 Thread Bastien 
Daimrod daim...@gmail.com writes:

 Okay to push?

Please go ahead, thanks,

-- 
 Bastien

Re: [O] [PATH] Customize org-annotate-file

2014-05-09 Thread Daimrod 
Bastien b...@gnu.org writes:

 Daimrod daim...@gmail.com writes:

 Okay to push?

 Please go ahead, thanks,

done.

-- 
Daimrod/Greg