Re: [O] 63 failures for org-test-run-all-tests in an Emacs GUI

2015-01-30 Thread Sebastien Vauban


Nicolas Goaziou wrote:
 Sebastien Vauban writes:

 Here is a patch you can apply with no problem -- just checked it on
 a fresh copy of master.

 Thanks.

 I can apply it but it introduces test failures.

FAILED  ob-shell/generic-uses-no-arrays
FAILED  ob-shell/generic-uses-no-assoc-arrays
FAILED  ob-tangle/continued-code-blocks-w-noweb-ref
FAILED  test-ob/specific-colnames

 Could you look into it?

I only see 3 problems right now (not `test-ob/specific-colnames'
anymore!?).

Regarding `ob-tangle/continued-code-blocks-w-noweb-ref', it's because
some `babel.shell' is now created (from a tangle operation) and is
inserted in the test in question:

  ┌
  │ (ert-deftest ob-tangle/continued-code-blocks-w-noweb-ref ()
  │   Test that the :noweb-ref header argument is used correctly.
  │   (org-test-at-id 54d68d4b-1544-4745-85ab-4f03b3cbd8a0
  │ (let ((tangled
  │df|sed '1d'|awk '{print $5 \ \ $6}'|sort -n |tail -1|awk '{print 
$2}'))
  │   (org-narrow-to-subtree)
  │   (org-babel-tangle)
  │   (with-temp-buffer
  │ (insert-file-contents babel.shell) ;  was babel.sh
  │ (goto-char (point-min))
  │ (should (re-search-forward (regexp-quote tangled) nil t)))
  │   (delete-file babel.shell ;  was babel.sh
  └

Changing the file extension in the above test makes the problem
disappears, though I'm not sure it's the cleanest way to do it: the
shell block should be tangled to a file with the `sh' extension in the
first place, but why isn't it still the case?

Regarding `ob-shell/generic-uses-no-arrays' and
`ob-shell/generic-uses-no-assoc-arrays', they both make use of the code
block defined in the file `testing/examples/ob-shell-test.org':

  ┌
  │ * Array tests
  │   :PROPERTIES:
  │   :ID:   0ba56632-8dc1-405c-a083-c204bae477cf
  │   :END:
  │ ** Generic shell: no arrays
  │ #+begin_src shell :exports results :var array=sample_array
  │ # ^^^ was sh only
  │ echo ${array}
  │ #+end_src
  └

Still, I don't understand what's wrong in the tests, for example here
in `ob-shell/generic-uses-no-arrays':

  ┌
  │ ; A list of tests using the samples in ob-shell-test.org
  │ (ert-deftest ob-shell/generic-uses-no-arrays ()
  │   No arrays for generic
  │   (org-test-at-id 0ba56632-8dc1-405c-a083-c204bae477cf
  │ (org-babel-next-src-block)
  │ (should (equal one two three (org-babel-execute-src-block)
  └

Any hint?

PS- Two tests are defined under the same name:

--8---cut here---start-8---
./test-ob-shell.el:63:(ert-deftest ob-shell/generic-uses-no-assoc-arrays ()
./test-ob-shell.el:76:(ert-deftest ob-shell/generic-uses-no-assoc-arrays ()
--8---cut here---end---8---

Isn't there any protection mechanism against test name duplicates?

Best regards,
  Seb




Re: [O] 63 failures for org-test-run-all-tests in an Emacs GUI

2015-01-23 Thread Nicolas Goaziou


Sebastien Vauban sva-news-D0wtAvR13HarG/idocf...@public.gmane.org
writes:

 Here is a patch you can apply with no problem -- just checked it on
 a fresh copy of master.

Thanks.

I can apply it but it introduces test failures.

   FAILED  ob-shell/generic-uses-no-arrays
   FAILED  ob-shell/generic-uses-no-assoc-arrays
   FAILED  ob-tangle/continued-code-blocks-w-noweb-ref
   FAILED  test-ob/specific-colnames

Could you look into it?


Regards,




Re: [O] 63 failures for org-test-run-all-tests in an Emacs GUI

2015-01-23 Thread Sebastien Vauban
Nicolas Goaziou wrote:
 Sebastien Vauban writes:
 Nicolas Goaziou wrote:
 Sebastien Vauban writes:

 Did I misunderstand the change of last year (Dec '13) or should `sh'
 language be abandoned in favor of `shell'?

 I think you're right.

 IIUC, then, those blocks should be updated: ...
 And those inline calls as well: ...
 I am willing to make the patch.

 Great. Please do.

 Here it is.

 Thanks. 

 Unfortunately, I'm still unable to apply your patch. Before using git
 format-patch, please ensure that your patch is the only one on top of
 HEAD, and send it again.

Here is a patch you can apply with no problem -- just checked it on
a fresh copy of master.

And you know what?  I've understood the problem: when editing the *patch
file* to include the results of `C-x 4 a', and *saving* it, all the
trailing spaces *in the patch file* are removed, because of my custom:

#+begin_src emacs-lisp
  (add-hook 'before-save-hook (lambda ()
;; Nuke all trailing whitespaces in the
;; buffer.
(unless (eq major-mode 'message-mode)
  (delete-trailing-whitespace
#+end_src

Hence, Git fails to find some of the lines it searches for, when trying
to apply my changes...

Best regards,
  Seb

-- 
Sebastien Vauban
From 744facc265a7fc3808d8af1438c2393be9168ef4 Mon Sep 17 00:00:00 2001
From: Sebastien Vauban sva-n...@mygooglest.com
Date: Fri, 23 Jan 2015 16:13:16 +0100
Subject: [PATCH] Replace `sh' language by `shell'

* testing/README, testing/examples/babel.org, ob-shell-test.org, testing/lisp/test-ob-exp.el, test-ob.el: Replace `sh' language by `shell'.
---
 testing/README |  2 +-
 testing/examples/babel.org | 54 +++---
 testing/examples/ob-shell-test.org | 11 
 testing/lisp/test-ob-exp.el| 12 -
 testing/lisp/test-ob.el| 24 -
 5 files changed, 51 insertions(+), 52 deletions(-)

diff --git a/testing/README b/testing/README
index 34f6fcd..d8a31ac 100644
--- a/testing/README
+++ b/testing/README
@@ -17,7 +17,7 @@ relative to the base of the Org-mode directory.
 
 Also note that many of the current tests uses babel evaluation...
 
-#+BEGIN_SRC sh :dir (expand-file-name ..)
+#+BEGIN_SRC shell :dir (expand-file-name ..)
   # For Emacs earlier than 24, add -L /path/to/ert
   emacs -Q --batch \
 -L lisp/ -L testing/ -L testing/lisp -l lisp/org.el \
diff --git a/testing/examples/babel.org b/testing/examples/babel.org
index 1f9ce3d..7bdc2ff 100644
--- a/testing/examples/babel.org
+++ b/testing/examples/babel.org
@@ -125,7 +125,7 @@
 (list (my-map 'list #'+
   (append prev-row '(0))
   (append '(0) prev-row)))
-  
+
   (pascals-triangle n)
 #+end_src
 
@@ -196,9 +196,9 @@ an = sign.
   :results:  silent
   :ID:   54cb8dc3-298c-4883-a933-029b3c9d4b18
   :END:
-Here is one in the middle src_sh{echo 1} of a line.
-Here is one at the end of a line. src_sh{echo 2}
-src_sh{echo 3} Here is one at the beginning of a line.
+Here is one in the middle src_shell{echo 1} of a line.
+Here is one at the end of a line. src_shell{echo 2}
+src_shell{echo 3} Here is one at the beginning of a line.
 
 * exported inline source block
 :PROPERTIES:
@@ -206,10 +206,10 @@ src_sh{echo 3} Here is one at the beginning of a line.
 :results:  silent
 :exports:  code
 :END:
-Here is one in the middle src_sh{echo 1} of a line.
-Here is one at the end of a line. src_sh{echo 2}
-src_sh{echo 3} Here is one at the beginning of a line.
-Here is one that is also evaluated: src_sh[:exports both]{echo 4}
+Here is one in the middle src_shell{echo 1} of a line.
+Here is one at the end of a line. src_shell{echo 2}
+src_shell{echo 3} Here is one at the beginning of a line.
+Here is one that is also evaluated: src_shell[:exports both]{echo 4}
 
 * mixed blocks with exports both
   :PROPERTIES:
@@ -235,27 +235,27 @@ Here is one that is also evaluated: src_sh[:exports both]{echo 4}
   :noweb-sep: 
   :END:
 
-#+begin_src sh :tangle yes :noweb yes :shebang #!/bin/sh
+#+begin_src shell :tangle yes :noweb yes :shebang #!/bin/sh
   fullest-disk
 #+end_src
 
 ** query all mounted disks
-#+begin_src sh :noweb-ref fullest-disk
+#+begin_src shell :noweb-ref fullest-disk
   df
 #+end_src
 
 ** strip the header row
-#+begin_src sh :noweb-ref fullest-disk
+#+begin_src shell :noweb-ref fullest-disk
   |sed '1d'
 #+end_src
 
 ** sort by the percent full
-#+begin_src sh :noweb-ref fullest-disk
+#+begin_src shell :noweb-ref fullest-disk
   |awk '{print $5   $6}'|sort -n |tail -1
 #+end_src
 
 ** extract the mount point
-#+begin_src sh :noweb-ref fullest-disk
+#+begin_src shell :noweb-ref fullest-disk
   |awk '{print $2}'
 #+end_src
 * resolving sub-trees as references
@@ -290,20 +290,20 @@ has length 14
   :results:  silent
   :ID:   

Re: [O] 63 failures for org-test-run-all-tests in an Emacs GUI

2015-01-10 Thread Nicolas Goaziou
Sebastien Vauban sva-news-D0wtAvR13HarG/idocf...@public.gmane.org
writes:

 Nicolas Goaziou wrote:
 Sebastien Vauban writes:

 Did I misunderstand the change of last year (Dec '13) or should `sh'
 language be abandoned in favor of `shell'?

 I think you're right.

 IIUC, then, those blocks should be updated: ...
 And those inline calls as well: ...
 I am willing to make the patch.

 Great. Please do.

 Here it is.

Thanks. 

Unfortunately, I'm still unable to apply your patch. Before using git
format-patch, please ensure that your patch is the only one on top of
HEAD, and send it again.

If you already did, maybe someone else with write access to the repo
will be able to sort it out.


Regards,



Re: [O] 63 failures for org-test-run-all-tests in an Emacs GUI

2015-01-09 Thread Sebastien Vauban
Nicolas Goaziou wrote:
 Sebastien Vauban writes:

 Did I misunderstand the change of last year (Dec '13) or should `sh'
 language be abandoned in favor of `shell'?

 I think you're right.

 IIUC, then, those blocks should be updated: ...
 And those inline calls as well: ...
 I am willing to make the patch.

 Great. Please do.

Here it is.

Best regards,
  Seb

-- 
Sebastien Vauban
From: Sebastien Vauban sva-n...@mygooglest.com
Date: Fri, 9 Jan 2015 11:10:25 +0100
Subject: [PATCH] Replace `sh' language by `shell'

	* README, babel.org, ob-shell-test.org, test-ob-exp.el,
  test-ob.el: Replace `sh' language by `shell'.

---
 testing/README |  2 +-
 testing/examples/babel.org | 54 +++---
 testing/examples/ob-shell-test.org | 11 
 testing/lisp/test-ob-exp.el| 12 -
 testing/lisp/test-ob.el| 28 ++--
 5 files changed, 53 insertions(+), 54 deletions(-)

diff --git a/testing/README b/testing/README
index 34f6fcd..d8a31ac 100644
--- a/testing/README
+++ b/testing/README
@@ -17,7 +17,7 @@ relative to the base of the Org-mode directory.

 Also note that many of the current tests uses babel evaluation...

-#+BEGIN_SRC sh :dir (expand-file-name ..)
+#+BEGIN_SRC shell :dir (expand-file-name ..)
   # For Emacs earlier than 24, add -L /path/to/ert
   emacs -Q --batch \
 -L lisp/ -L testing/ -L testing/lisp -l lisp/org.el \
diff --git a/testing/examples/babel.org b/testing/examples/babel.org
index 8bae65b..978df7a 100644
--- a/testing/examples/babel.org
+++ b/testing/examples/babel.org
@@ -125,7 +125,7 @@
 (list (my-map 'list #'+
   (append prev-row '(0))
   (append '(0) prev-row)))
-
+
   (pascals-triangle n)
 #+end_src

@@ -196,9 +196,9 @@ an = sign.
   :results:  silent
   :ID:   54cb8dc3-298c-4883-a933-029b3c9d4b18
   :END:
-Here is one in the middle src_sh{echo 1} of a line.
-Here is one at the end of a line. src_sh{echo 2}
-src_sh{echo 3} Here is one at the beginning of a line.
+Here is one in the middle src_shell{echo 1} of a line.
+Here is one at the end of a line. src_shell{echo 2}
+src_shell{echo 3} Here is one at the beginning of a line.

 * exported inline source block
 :PROPERTIES:
@@ -206,10 +206,10 @@ src_sh{echo 3} Here is one at the beginning of a line.
 :results:  silent
 :exports:  code
 :END:
-Here is one in the middle src_sh{echo 1} of a line.
-Here is one at the end of a line. src_sh{echo 2}
-src_sh{echo 3} Here is one at the beginning of a line.
-Here is one that is also evaluated: src_sh[:exports both]{echo 4}
+Here is one in the middle src_shell{echo 1} of a line.
+Here is one at the end of a line. src_shell{echo 2}
+src_shell{echo 3} Here is one at the beginning of a line.
+Here is one that is also evaluated: src_shell[:exports both]{echo 4}

 * mixed blocks with exports both
   :PROPERTIES:
@@ -235,27 +235,27 @@ Here is one that is also evaluated: src_sh[:exports both]{echo 4}
   :noweb-sep: 
   :END:

-#+begin_src sh :tangle yes :noweb yes :shebang #!/bin/sh
+#+begin_src shell :tangle yes :noweb yes :shebang #!/bin/sh
   fullest-disk
 #+end_src

 ** query all mounted disks
-#+begin_src sh :noweb-ref fullest-disk
+#+begin_src shell :noweb-ref fullest-disk
   df
 #+end_src

 ** strip the header row
-#+begin_src sh :noweb-ref fullest-disk
+#+begin_src shell :noweb-ref fullest-disk
   |sed '1d'
 #+end_src

 ** sort by the percent full
-#+begin_src sh :noweb-ref fullest-disk
+#+begin_src shell :noweb-ref fullest-disk
   |awk '{print $5   $6}'|sort -n |tail -1
 #+end_src

 ** extract the mount point
-#+begin_src sh :noweb-ref fullest-disk
+#+begin_src shell :noweb-ref fullest-disk
   |awk '{print $2}'
 #+end_src
 * resolving sub-trees as references
@@ -290,20 +290,20 @@ has length 14
   :results:  silent
   :ID:   0D0983D4-DE33-400A-8A05-A225A567BC74
   :END:
-src_sh{echo One} block at start of line
- One spaced block in  src_sh{ echo middle } of line
-src_sh{echo 2} blocks on the src_emacs-lisp{same} line
- Inline block with src_sh[:results silent]{ echo parameters }.
+src_shell{echo One} block at start of line
+ One spaced block in  src_shell{ echo middle } of line
+src_shell{echo 2} blocks on the src_emacs-lisp{same} line
+ Inline block with src_shell[:results silent]{ echo parameters }.

 * org-babel-get-inline-src-block-matches (with empty args)
   :PROPERTIES:
   :results:  silent
   :ID:   d55dada7-de0e-4340-8061-787cccbedee5
   :END:
-src_sh[]{echo One} block at start of line
- One spaced block in  src_sh[]{ echo middle } of line
-src_sh[]{echo 2} blocks on the src_emacs-lisp[]{same} line
- Inline block with src_sh[:results silent]{ echo parameters }.
+src_shell[]{echo One} block at start of line
+ One spaced block in  src_shell[]{ echo middle } of line
+src_shell[]{echo 2} blocks on the src_emacs-lisp[]{same} line
+ Inline block with src_shell[:results silent]{ echo parameters }.

 

Re: [O] 63 failures for org-test-run-all-tests in an Emacs GUI

2015-01-03 Thread Nicolas Goaziou


Sebastien Vauban sva-news-D0wtAvR13HarG/idocf...@public.gmane.org
writes:

 Did I misunderstand the change of last year (Dec '13) or should `sh'
 language be abandoned in favor of `shell'?

I think you're right.

 IIUC, then, those blocks should be updated:

[...]

 And those inline calls as well:

[...]

 I am willing to make the patch.

Great. Please do.


Regards,




Re: [O] 63 failures for org-test-run-all-tests in an Emacs GUI

2014-12-31 Thread Sebastien Vauban
Hello Nicolas,

Nicolas Goaziou wrote:
 Sebastien Vauban writes:

 I just ran `org-test-run-all-tests' in my active WinNT Emacs session
 (with Org-mode release_8.3beta-677-g0497e3), and was surprised by the
 high number of failures:

 You probably heavily customized Org, and many tests expect default
 values for defcustoms to run properly.

 I fixed the most obvious one, but there is more work to do in that area.

Did I misunderstand the change of last year (Dec '13) or should `sh'
language be abandoned in favor of `shell'?

IIUC, then, those blocks should be updated:

--8---cut here---start-8---
./examples/babel.org:238:#+begin_src sh :tangle yes :noweb yes :shebang 
#!/bin/sh
./examples/babel.org:243:#+begin_src sh :noweb-ref fullest-disk
./examples/babel.org:248:#+begin_src sh :noweb-ref fullest-disk
./examples/babel.org:253:#+begin_src sh :noweb-ref fullest-disk
./examples/babel.org:258:#+begin_src sh :noweb-ref fullest-disk
./examples/babel.org:315:#+begin_src sh :foo baz
./examples/babel.org:327:#+BEGIN_SRC sh :exports none
./examples/babel.org:333:#+BEGIN_SRC sh :noweb no-export :exports both
./examples/babel.org:376:#+BEGIN_SRC sh :exports none
./examples/babel.org:380:#+BEGIN_SRC sh :noweb strip-export :exports code 
:results silent
./examples/babel.org:447:#+BEGIN_SRC sh :shebang #!/bin/sh :exports results 
:results verbatim
./examples/ob-shell-test.org:25:#+begin_src sh :exports results :var 
array=sample_array
./examples/ob-shell-test.org:50:#+begin_src sh :exports results :var 
table=sample_mapping_table
./examples/ob-shell-test.org:72:#+begin_src sh :exports results :var 
table=sample_big_table
./lisp/test-ob.el:471:#+begin_src sh :results scalar
./lisp/test-ob.el:478:#+begin_src sh :results raw scalar
./lisp/test-ob.el:509:  (org-test-with-temp-text #+begin_src sh\necho 
Hello\n#+end_src\n
./lisp/test-ob.el:669:  (org-test-with-temp-text #+begin_src sh :results 
output :tangle yes
./lisp/test-ob.el:674:#+begin_src sh
./lisp/test-ob.el:680:  (org-test-with-temp-text #+begin_src sh :results 
output :tangle yes
./lisp/test-ob.el:685:#+begin_src sh :noweb-sep \\
./lisp/test-ob.el:689:#+begin_src sh :noweb-ref foo :noweb-sep \\
./lisp/test-ob.el:812:  #+begin_src sh :results file wrap
./lisp/test-ob.el:1140:#+begin_src sh :var data=input-table :exports results 
:colnames '(Rev Author)
./lisp/test-ob.el:1158:#+begin_src sh :var data=input-table :exports results 
:colnames '(Rev Author)
./README:20:#+BEGIN_SRC sh :dir (expand-file-name ..)
--8---cut here---end---8---

And those inline calls as well:

--8---cut here---start-8---
./examples/babel.org:199:Here is one in the middle src_sh{echo 1} of a line.
./examples/babel.org:200:Here is one at the end of a line. src_sh{echo 2}
./examples/babel.org:201:src_sh{echo 3} Here is one at the beginning of a line.
./examples/babel.org:209:Here is one in the middle src_sh{echo 1} of a line.
./examples/babel.org:210:Here is one at the end of a line. src_sh{echo 2}
./examples/babel.org:211:src_sh{echo 3} Here is one at the beginning of a line.
./examples/babel.org:212:Here is one that is also evaluated: src_sh[:exports 
both]{echo 4}
./examples/babel.org:293:src_sh{echo One} block at start of line
./examples/babel.org:294: One spaced block in  src_sh{ echo middle } of line
./examples/babel.org:295:src_sh{echo 2} blocks on the src_emacs-lisp{same} 
line
./examples/babel.org:296: Inline block with src_sh[:results silent]{ echo 
parameters }.
./examples/babel.org:303:src_sh[]{echo One} block at start of line
./examples/babel.org:304: One spaced block in  src_sh[]{ echo middle } of line
./examples/babel.org:305:src_sh[]{echo 2} blocks on the 
src_emacs-lisp[]{same} line
./examples/babel.org:306: Inline block with src_sh[:results silent]{ echo 
parameters }.
./lisp/test-ob-exp.el:242: \\[]{ \\(?:\\[]\\)?{ ;accept both 
src_sh[]{...} or src_sh{...}
./lisp/test-ob-exp.el:243: (regexp-quote Here is one in the middle 
src_sh[]{echo 1} of a line.
./lisp/test-ob-exp.el:244:Here is one at the end of a line. src_sh[]{echo 2}
./lisp/test-ob-exp.el:245:src_sh[]{echo 3} Here is one at the beginning of a 
line.
./lisp/test-ob-exp.el:246:Here is one that is also evaluated: src_sh[]{echo 4} 
=4=)
./lisp/test-ob.el:297:  (let ((test-line src_sh{echo 1}))
--8---cut here---end---8---

I am willing to make the patch.

Best regards,
  Seb

-- 
Sebastien Vauban




Re: [O] 63 failures for org-test-run-all-tests in an Emacs GUI

2014-12-24 Thread Nicolas Goaziou


Hello,

Sebastien Vauban sva-news-D0wtAvR13HarG/idocf...@public.gmane.org
writes:

 I just ran `org-test-run-all-tests' in my active WinNT Emacs session
 (with Org-mode release_8.3beta-677-g0497e3), and was surprised by the
 high number of failures:

You probably heavily customized Org, and many tests expect default
values for defcustoms to run properly.

I fixed the most obvious one, but there is more work to do in that area.


Regards,

-- 
Nicolas Goaziou




Re: [O] 63 failures for org-test-run-all-tests in an Emacs GUI

2014-12-24 Thread Sebastien Vauban
Hello,

Nicolas Goaziou wrote:
 Sebastien Vauban writes:

 I just ran `org-test-run-all-tests' in my active WinNT Emacs session
 (with Org-mode release_8.3beta-677-g0497e3), and was surprised by the
 high number of failures:

 You probably heavily customized Org

For sure ;-)

 and many tests expect default values for defcustoms to run properly.

 I fixed the most obvious one, but there is more work to do in that area.

IIUC, the top 1 problem for test failures is my customization of
`org-babel-no-eval-on-ctrl-c-ctrl-c' to `t'.

For the tests to work with that (common?) customization, should we
replace, in the tests, all calls to:

--8---cut here---start-8---
  (org-ctrl-c-ctrl-c)
--8---cut here---end---8---

by:

--8---cut here---start-8---
  (let (org-babel-no-eval-on-ctrl-c-ctrl-c)
(org-ctrl-c-ctrl-c))
--8---cut here---end---8---

?

Best regards,
  Seb

-- 
Sebastien Vauban




Re: [O] 63 failures for org-test-run-all-tests in an Emacs GUI

2014-12-24 Thread Sebastien Vauban
Sebastien Vauban wrote:
 Nicolas Goaziou wrote:
 Sebastien Vauban writes:

 I just ran `org-test-run-all-tests' in my active WinNT Emacs session
 (with Org-mode release_8.3beta-677-g0497e3), and was surprised by
 the high number of failures:

 You probably heavily customized Org

 For sure ;-)

 and many tests expect default values for defcustoms to run properly.

 I fixed the most obvious one, but there is more work to do in that
 area.

 IIUC, the top 1 problem for test failures is my customization of
 `org-babel-no-eval-on-ctrl-c-ctrl-c' to `t'.

 For the tests to work with that (common?) customization, should we
 replace, in the tests, all calls to:

   (org-ctrl-c-ctrl-c)

 by:

   (let (org-babel-no-eval-on-ctrl-c-ctrl-c)
 (org-ctrl-c-ctrl-c))

 ?

In fact, what would make more sense is to have
a `org-ctrl-c-ctrl-v-ctrl-e' function, no?

Or even more sense: calling `org-babel-execute-maybe' instead?

Best regards,
  Seb

-- 
Sebastien Vauban




Re: [O] 63 failures for org-test-run-all-tests in an Emacs GUI

2014-12-24 Thread Nicolas Goaziou


Sebastien Vauban sva-news-D0wtAvR13HarG/idocf...@public.gmane.org
writes:

 Or even more sense: calling `org-babel-execute-maybe' instead?

I think it would be better, yes. There is no point in testing
`org-ctrl-c-ctrl-c' in test-ob.el.


Regards,




[O] 63 failures for org-test-run-all-tests in an Emacs GUI

2014-12-22 Thread Sebastien Vauban
Hello,

I just ran `org-test-run-all-tests' in my active WinNT Emacs session
(with Org-mode release_8.3beta-677-g0497e3), and was surprised by the
high number of failures:

--8---cut here---start-8---
Selector: \\(org\\|ob\\)
Passed:  332
Failed:  63 (53 unexpected)
Skipped: 0
Total:   395/395

Started at:   2014-12-22 16:34:06+0100
Finished.
Finished at:  2014-12-22 16:34:42+0100

FFF.FFF...ff..FF.F.F.FF..FF...F.F.FF...F..F.F...F.F...F..F...FFFFF..F..F...F...

F ob-emacs-lisp/commented-last-block-line
(user-error C-c C-c can do nothing useful at this location)

F ob-emacs-lisp/commented-last-block-line-no-var
(user-error C-c C-c can do nothing useful at this location)

F ob-emacs-lisp/commented-last-block-line-with-var
(user-error C-c C-c can do nothing useful at this location)

F ob-exp/noweb-on-export
Noweb header arguments export correctly.
(ert-test-failed
 ((should
   (equal
'((message \expanded1\) (message \expanded2\) ;; 
noweb-1-yes-start\n  (message \expanded1\)\n  (message \expanded1\) ;; 
noweb-no-start\n  noweb-example1 ;; noweb-2-yes-start\n  (message 
\expanded2\)\n  (message \expanded2\) ;; 
noweb-tangle-start\nnoweb-example1\nnoweb-example2)
(org-test-at-id eb1f6498-5bd9-45e0-9c56-50717053e7b7
  (org-narrow-to-subtree)
  (org-element-map ... ... ...
  :form
  (equal
   ((message \expanded1\) (message \expanded2\) ;; 
noweb-1-yes-start\n  (message \expanded1\)\n  (message \expanded1\) ;; 
noweb-no-start\n  noweb-example1 ;; noweb-2-yes-start\n  (message 
\expanded2\)\n  (message \expanded2\) ;; 
noweb-tangle-start\nnoweb-example1\nnoweb-example2)
   ((message \expanded1\) (message \expanded2\) ;; 
noweb-1-yes-start\n(message \expanded1\)\n(message \expanded1\) 
;; noweb-no-start\n  noweb-example1 ;; noweb-2-yes-start\n(message 
\expanded2\)\n(message \expanded2\) ;; noweb-tangle-start\n  
noweb-example1\n  noweb-example2))
  :value nil :explanation
  (list-elt 2
(arrays-of-different-length 68 72 ;; noweb-1-yes-start\n  
(message \expanded1\)\n  (message \expanded1\) ;; noweb-1-yes-start\n
(message \expanded1\)\n(message \expanded1\) first-mismatch-at 23

F ob-exp/noweb-on-export-with-exports-results
Noweb header arguments export correctly using :exports results.
(error noweb-examplecould not be resolved (see 
`org-babel-noweb-error-langs'))

F ob-tangle/continued-code-blocks-w-noweb-ref
Test that the :noweb-ref header argument is used correctly.
(ert-test-failed
 ((should
   (re-search-forward
(regexp-quote tangled)
nil t))
  :form
  (re-search-forward df|sed '1d'|awk '{print \\$5 \ \ \\$6}'|sort -n 
|tail -1|awk '{print \\$2}' nil t)
  :value nil))

F test-ob-exp/org-babel-exp-src-blocks/w-no-headers2
Testing export without any headlines in the org-mode file.
(user-error Abort)

F test-ob-python/colnames-no-header-argument-again
(ert-test-failed
 ((should
   (equal
'(... ... ...)
(org-babel-execute-src-block)))
  :form
  (equal
   ((a*)
(b*)
(c*))
   )
  :value nil :explanation
  (different-types
   ((a*)
(b*)
(c*))
   )))

F test-ob-python/colnames-yes-header-argument-again
(ert-test-failed
 ((should
   (equal
'(... hline ... ...)
(org-babel-execute-src-block)))
  :form
  (equal
   ((a)
hline
(b*)
(c*))
   )
  :value nil :explanation
  (different-types
   ((a)
hline
(b*)
(c*))
   )))

F test-ob/blocks-with-spaces
Test expansion of blocks followed by blank lines.
(ert-test-failed
 ((should
   (equal #+BEGIN_SRC emacs-lisp\n(+ 1 2)\n#+END_SRC\n\n#+RESULTS:\n: 
3\n\n\n
  (org-test-with-temp-text #+BEGIN_SRC emacs-lisp\n(+ 1 
2)\n#+END_SRC\n\n\n
(org-babel-execute-src-block)
(buffer-string
  :form
  (equal #+BEGIN_SRC emacs-lisp\n(+ 1 2)\n#+END_SRC\n\n#+RESULTS:\n: 
3\n\n\n #+BEGIN_SRC emacs-lisp\n(+ 1 2)\n#+END_SRC\n\n#+results:\n: 3\n\n\n)
  :value nil :explanation
  (array-elt 44
 (different-atoms
  (82 #x52 ?R)
  (114 #x72 ?r)

F test-ob/commented-last-block-line-no-var
(user-error C-c C-c can do nothing useful at this location)

F test-ob/commented-last-block-line-with-var
(user-error C-c C-c can do nothing useful at this location)

F test-ob/noweb-expansion-1
(ert-test-failed
 ((should
   (string=