Re: [O] Bug: Broken orgmode.org links in doc/misc/org.texi and lisp/org

[Bastien Guerry]

Hi Tim,

Tim Landscheidt  writes:

>> - https://orgmode.org/org-remember.pdf
>> - https://orgmode.org/worg/code/org-info-js/
>> - https://orgmode.org/worg/org-contrib/babel/languages.html
>> - https://orgmode.org/worg/org-contrib/babel/languages/ob-doc-lilypond.html
>> - https://orgmode.org/worg/org-contrib/babel/languages/ob-doc-stan.html
>
> The last four work now (merci Bastien!), the first still
> not.

This is now fixed, thanks a lot!

-- 
 Bastien

Re: [O] Bug: Broken orgmode.org links in doc/misc/org.texi and lisp/org

[Tim Landscheidt]

I wrote:

> […]

> The following links in Emacs master's doc/misc/org.texi and
> lisp/org are broken (404):

> - https://orgmode.org/org-remember.pdf
> - https://orgmode.org/worg/code/org-info-js/
> - https://orgmode.org/worg/org-contrib/babel/languages.html
> - https://orgmode.org/worg/org-contrib/babel/languages/ob-doc-lilypond.html
> - https://orgmode.org/worg/org-contrib/babel/languages/ob-doc-stan.html

The last four work now (merci Bastien!), the first still
not.  It is referenced in etc/ORG-NEWS, documenting the
changes in version 7.8.11:

| […]

| ** Important new features

| […]

| *** org-capture.el is now the default capture system

| This replaces the earlier system org-remember.  The manual only
| describes org-capture, but for people who prefer to continue to
| use org-remember, we keep a static copy of the former manual
| section [[https://orgmode.org/org-remember.pdf][chapter about remember]].

| […]

The Internet Archive's Wayback Machine has archived a copy
(https://web.archive.org/web/20171027214006/https://orgmode.org/org-remember.pdf).
Would it work if it is committed as /org-remember.pdf to
https://code.orgmode.org/bzg/orgweb?

Tim

Re: [O] Bug: Broken orgmode.org links in doc/misc/org.texi and lisp/org

[Nicolas Goaziou]

Hello,

Tim Landscheidt  writes:

> I may be biased here because I did not find that :-), but
> that page is referenced in the org-mode repository only in
> README_maintainer with the context:

[...]

> Especially, it is not linked to from README_contribute :-).

Would you want to provide a patch to README_contribute?

Thank you.

Regards,

-- 
Nicolas Goaziou

Re: [O] Bug: Broken orgmode.org links in doc/misc/org.texi and lisp/org

[Nicolas Goaziou]

Hello,

Tim Landscheidt  writes:

> I think you missed patch #2;

Indeed. Now applied. Thank you.

> I have attached it again re- based on current maint (I removed
> TINYCHANGE because I have signed papers for Emacs since then).

Good news! Welcome aboard.

Regards,

-- 
Nicolas Goaziou0x80A93738

Re: [O] Bug: Broken orgmode.org links in doc/misc/org.texi and lisp/org

[Tim Landscheidt]

Nicolas Goaziou  wrote:

>> Could you then please document TINYCHANGE in
>> README_contribute?  Merci!

> This is already covered at
> 

I may be biased here because I did not find that :-), but
that page is referenced in the org-mode repository only in
README_maintainer with the context:

| […]

| The list of all contributors from who we have the papers is kept on
| Worg at https://orgmode.org/worg/org-contribute.html, so that
| committers can check if a patch can go into the core.

| […]

and in etc/ORG-NEWS with the context:

| […]

| * Version 9.1

| […]

| ** Miscellaneous

| *** The Library of Babel now on Worg

| The library-of-babel.org used to be accessible from the =doc/=
| directory, distributed with Org’s core.  It is now accessible
| from the Worg community-driven documentation 
[[https://orgmode.org/worg/library-of-babel.html][here]].

| If you want to contribute to it, please see 
[[https://orgmode.org/worg/org-contribute.html][how to contribute]].

| […]

Especially, it is not linked to from README_contribute :-).

Tim

Re: [O] Bug: Broken orgmode.org links in doc/misc/org.texi and lisp/org

[Tim Landscheidt]

Nicolas Goaziou  wrote:

>> […]

>> Patch #2 makes some links to the manual and external URLs in
>> docstrings clickable.

>> […]

> Applied. Thank you.

> […]

I think you missed patch #2; I have attached it again re-
based on current maint (I removed TINYCHANGE because I have
signed papers for Emacs since then).

Tim
>From 14fa16af86dfc21e77698a36c76a4e6ac017cd49 Mon Sep 17 00:00:00 2001
From: Tim Landscheidt 
Date: Tue, 16 Jan 2018 16:46:46 +
Subject: [PATCH] Make manual and URL links in docstrings clickable

---
 lisp/org-table.el  | 2 +-
 lisp/ox-latex.el   | 5 ++---
 testing/lisp/test-org-table.el | 2 +-
 3 files changed, 4 insertions(+), 5 deletions(-)

diff --git a/lisp/org-table.el b/lisp/org-table.el
index 159a4fb5c..11d42d3cb 100644
--- a/lisp/org-table.el
+++ b/lisp/org-table.el
@@ -135,7 +135,7 @@ the fixed string \"#+ORGTBL: SEND\", followed by instruction on how to
 convert the table into a data structure useful in the
 language of the buffer.  Check the manual for the section on
 \"Translator functions\", and more generally check out
-https://orgmode.org/manual/Tables-in-arbitrary-syntax.html#Tables-in-arbitrary-syntax
+the Info node `(org)Tables in arbitrary syntax'.
 
 All occurrences of %n in a template will be replaced with the name of the
 table, obtained by prompting the user."
diff --git a/lisp/ox-latex.el b/lisp/ox-latex.el
index b3fbf8e95..e612b32ca 100644
--- a/lisp/ox-latex.el
+++ b/lisp/ox-latex.el
@@ -920,15 +920,14 @@ using customize, or with
   (add-to-list \\='org-latex-packages-alist \\='(\"newfloat\" \"minted\"))
 
 In addition, it is necessary to install pygments
-\(http://pygments.org), and to configure the variable
+\(URL `http://pygments.org>'), and to configure the variable
 `org-latex-pdf-process' so that the -shell-escape option is
 passed to pdflatex.
 
 The minted choice has possible repercussions on the preview of
 latex fragments (see `org-preview-latex-fragment').  If you run
 into previewing problems, please consult
-
-  https://orgmode.org/worg/org-tutorials/org-latex-preview.html;
+URL `https://orgmode.org/worg/org-tutorials/org-latex-preview.html'."
   :group 'org-export-latex
   :type '(choice
 	  (const :tag "Use listings" t)
diff --git a/testing/lisp/test-org-table.el b/testing/lisp/test-org-table.el
index ea72ae53f..31f10f6f2 100644
--- a/testing/lisp/test-org-table.el
+++ b/testing/lisp/test-org-table.el
@@ -710,7 +710,7 @@ formatter \"%.1f\"."
 
 (ert-deftest test-org-table/org-lookup-all ()
   "Use `org-lookup-all' for several GROUP BY as in SQL and for ranking.
-See also http://orgmode.org/worg/org-tutorials/org-lookups.html ."
+See also URL `https://orgmode.org/worg/org-tutorials/org-lookups.html'."
   (let ((data "
 #+NAME: data
 | Purchase | Product | Shop | Rating |
-- 
2.13.6

Re: [O] Bug: Broken orgmode.org links in doc/misc/org.texi and lisp/org

[Nicolas Goaziou]

Hello,

Tim Landscheidt  writes:

> Nicolas Goaziou  wrote:
>
>> […]
>
>> Thank you! However, these patches do not seem to apply cleanly on maint
>> tip. Could you rebase them against maint HEAD and send them again?
>
>> […]
>
> I have attached the patches rebased on maint, with
> TINYCHANGE.  (I've switched patches #4 and #5 as #4 is
> easier to review than #5.)
>
> Patch #1 updates only URLs from http to https that I consid-
> er "uncontroversial".
>
> Patch #2 makes some links to the manual and external URLs in
> docstrings clickable.
>
> Patch #3 updates URLs from http to https in old entries of
> etc/ORG-NEWS.  There is an argument for keeping them as is,
> and I have no strong opinion on that.
>
> Patch #4 just adds a trailing slash to two links to
> https://orgmode.org/worg/org-contrib/babel.
>
> Patch #5 updates URLs from http to https in source code and
> test cases.  These need to be reviewed more carefully, espe-
> cially as there probably should remain some test cases for
> http URLs.  (I get a test failure for
> test-org/timestamp-from-time, but AFAICT this is unrelated.)

Applied. Thank you.

I don't think the distinction between http and https matters in Org
tests.

Regards,

-- 
Nicolas Goaziou

Re: [O] Bug: Broken orgmode.org links in doc/misc/org.texi and lisp/org

[Nicolas Goaziou]

Hello,

Tim Landscheidt  writes:

> Could you then please document TINYCHANGE in
> README_contribute?  Merci!

This is already covered at


Regards,

-- 
Nicolas Goaziou

Re: [O] Bug: Broken orgmode.org links in doc/misc/org.texi and lisp/org

[Tim Landscheidt]

Nicolas Goaziou  wrote:

> […]

> Thank you! However, these patches do not seem to apply cleanly on maint
> tip. Could you rebase them against maint HEAD and send them again?

> […]

I have attached the patches rebased on maint, with
TINYCHANGE.  (I've switched patches #4 and #5 as #4 is
easier to review than #5.)

Patch #1 updates only URLs from http to https that I consid-
er "uncontroversial".

Patch #2 makes some links to the manual and external URLs in
docstrings clickable.

Patch #3 updates URLs from http to https in old entries of
etc/ORG-NEWS.  There is an argument for keeping them as is,
and I have no strong opinion on that.

Patch #4 just adds a trailing slash to two links to
https://orgmode.org/worg/org-contrib/babel.

Patch #5 updates URLs from http to https in source code and
test cases.  These need to be reviewed more carefully, espe-
cially as there probably should remain some test cases for
http URLs.  (I get a test failure for
test-org/timestamp-from-time, but AFAICT this is unrelated.)

Tim
>From defa7770f7b136d6ec122f91ee84a471d6a83462 Mon Sep 17 00:00:00 2001
From: Tim Landscheidt 
Date: Tue, 16 Jan 2018 16:22:00 +
Subject: [PATCH 1/5] Use https for links to orgmode.org

TINYCHANGE
---
 Makefile |  2 +-
 README_ELPA  |  4 +-
 README_git   |  4 +-
 README_maintainer|  2 +-
 contrib/lisp/ob-csharp.el|  2 +-
 contrib/lisp/ob-eukleides.el |  2 +-
 contrib/lisp/ob-fomus.el |  2 +-
 contrib/lisp/ob-mathomatic.el|  2 +-
 contrib/lisp/ob-oz.el|  2 +-
 contrib/lisp/ob-tcl.el   |  2 +-
 contrib/lisp/ob-vbnet.el |  2 +-
 contrib/lisp/org-bibtex-extras.el|  2 +-
 contrib/lisp/org-collector.el|  2 +-
 contrib/lisp/org-contribdir.el   |  2 +-
 contrib/lisp/org-depend.el   |  2 +-
 contrib/lisp/org-effectiveness.el|  2 +-
 contrib/lisp/org-eval-light.el   |  2 +-
 contrib/lisp/org-eval.el |  2 +-
 contrib/lisp/org-index.el|  2 +-
 contrib/lisp/org-learn.el|  2 +-
 contrib/lisp/org-license.el  |  2 +-
 contrib/lisp/org-link-edit.el| 16 
 contrib/lisp/org-mairix.el   |  2 +-
 contrib/lisp/org-man.el  |  2 +-
 contrib/lisp/org-mew.el  |  2 +-
 contrib/lisp/org-notmuch.el  |  2 +-
 contrib/lisp/org-passwords.el|  2 +-
 contrib/lisp/org-screenshot.el   |  2 +-
 contrib/lisp/org-sudoku.el   |  2 +-
 contrib/lisp/org-track.el|  6 +--
 contrib/lisp/org-vm.el   |  2 +-
 contrib/lisp/org-wikinodes.el|  2 +-
 contrib/lisp/org-wl.el   |  2 +-
 contrib/lisp/ox-rss.el   |  2 +-
 contrib/orgmanual.org| 52 
 contrib/scripts/org-docco.org|  6 +--
 contrib/scripts/staticmathjax/README.org |  2 +-
 doc/orgguide.texi| 70 
 etc/ORG-NEWS |  4 +-
 etc/styles/README|  2 +-
 lisp/ob-C.el |  2 +-
 lisp/ob-J.el |  2 +-
 lisp/ob-R.el |  2 +-
 lisp/ob-asymptote.el |  2 +-
 lisp/ob-awk.el   |  2 +-
 lisp/ob-calc.el  |  2 +-
 lisp/ob-clojure.el   |  2 +-
 lisp/ob-comint.el|  2 +-
 lisp/ob-coq.el   |  2 +-
 lisp/ob-core.el  |  2 +-
 lisp/ob-css.el   |  2 +-
 lisp/ob-ditaa.el |  2 +-
 lisp/ob-dot.el   |  2 +-
 lisp/ob-ebnf.el  |  2 +-
 lisp/ob-emacs-lisp.el|  2 +-
 lisp/ob-eval.el  |  2 +-
 lisp/ob-exp.el   |  2 +-
 lisp/ob-forth.el |  2 +-
 lisp/ob-fortran.el   |  2 +-
 lisp/ob-gnuplot.el   |  2 +-
 lisp/ob-groovy.el|  2 +-
 lisp/ob-haskell.el   |  2 +-
 lisp/ob-hledger.el   |  2 +-
 lisp/ob-io.el|  2 +-
 lisp/ob-java.el  |  2 +-
 lisp/ob-js.el|  2 +-
 lisp/ob-keys.el  |  2 +-
 lisp/ob-latex.el |  2 +-
 lisp/ob-ledger.el|  2 +-
 lisp/ob-lilypond.el  |  4 +-
 lisp/ob-lisp.el  |  2 +-
 lisp/ob-lob.el   |  2 +-
 lisp/ob-lua.el   |  2 +-
 

Re: [O] Bug: Broken orgmode.org links in doc/misc/org.texi and lisp/org

[Tim Landscheidt]

Nicolas Goaziou  wrote:

>> According to Emacs's CONTRIBUTE (referenced by
>> README_contribute), that should be
>> "Copyright-paperwork-exempt: yes"?  

> Our commits do not appear in Emacs' history, so we are not required to
> follow their conventions for commit messages.

Could you then please document TINYCHANGE in
README_contribute?  Merci!

Tim

Re: [O] Bug: Broken orgmode.org links in doc/misc/org.texi and lisp/org

[Nicolas Goaziou]

Tim Landscheidt  writes:

> According to Emacs's CONTRIBUTE (referenced by
> README_contribute), that should be
> "Copyright-paperwork-exempt: yes"?  

Our commits do not appear in Emacs' history, so we are not required to
follow their conventions for commit messages.

> (Is mk/make_emacs_changelog still used for anything?)

I don't think so.

Regards,

Re: [O] Bug: Broken orgmode.org links in doc/misc/org.texi and lisp/org

[Tim Landscheidt]

Nicolas Goaziou  wrote:

> […]

> Thank you! However, these patches do not seem to apply cleanly on maint
> tip. Could you rebase them against maint HEAD and send them again?

Sure.

> Also, if you haven't signed FSF papers, you need to add TINYCHANGE at
> the end of each commit message.

According to Emacs's CONTRIBUTE (referenced by
README_contribute), that should be
"Copyright-paperwork-exempt: yes"?  (Is
mk/make_emacs_changelog still used for anything?)

Tim

Re: [O] Bug: Broken orgmode.org links in doc/misc/org.texi and lisp/org

[Nicolas Goaziou]

Hello,

Tim Landscheidt  writes:

> attached are five patches mostly related to the http to
> https update part of my post.
>
> Patch #1 updates only URLs from http to https that I consid-
> er "uncontroversial".
>
> Patch #2 makes some links to the manual and external URLs in
> docstrings clickable.
>
> Patch #3 updates URLs from http to https in old entries of
> etc/ORG-NEWS.  There is an argument for keeping them as is,
> and I have no strong opinion on that.
>
> Patch #4 updates URLs from http to https in source code and
> test cases.  These need to be reviewed more carefully, espe-
> cially as there probably should remain some test cases for
> http URLs.  (I get a test failure for
> test-org/timestamp-from-time, but AFAICT this is unrelated.)
>
> Patch #5 just adds a trailing slash to two links to
> https://orgmode.org/worg/org-contrib/babel.

Thank you! However, these patches do not seem to apply cleanly on maint
tip. Could you rebase them against maint HEAD and send them again?

Also, if you haven't signed FSF papers, you need to add TINYCHANGE at
the end of each commit message.

Regards,

-- 
Nicolas Goaziou

Re: [O] Bug: Broken orgmode.org links in doc/misc/org.texi and lisp/org

[Tim Landscheidt]

Hi,

attached are five patches mostly related to the http to
https update part of my post.

Patch #1 updates only URLs from http to https that I consid-
er "uncontroversial".

Patch #2 makes some links to the manual and external URLs in
docstrings clickable.

Patch #3 updates URLs from http to https in old entries of
etc/ORG-NEWS.  There is an argument for keeping them as is,
and I have no strong opinion on that.

Patch #4 updates URLs from http to https in source code and
test cases.  These need to be reviewed more carefully, espe-
cially as there probably should remain some test cases for
http URLs.  (I get a test failure for
test-org/timestamp-from-time, but AFAICT this is unrelated.)

Patch #5 just adds a trailing slash to two links to
https://orgmode.org/worg/org-contrib/babel.

Tim
>From eb2208842b3568122ecc9f9936dc255d73b76577 Mon Sep 17 00:00:00 2001
From: Tim Landscheidt 
Date: Tue, 16 Jan 2018 16:22:00 +
Subject: [PATCH 1/5] Use https for links to orgmode.org

---
 Makefile |  2 +-
 README_ELPA  |  4 +-
 README_git   |  4 +-
 README_maintainer|  2 +-
 contrib/lisp/ob-csharp.el|  2 +-
 contrib/lisp/ob-eukleides.el |  2 +-
 contrib/lisp/ob-fomus.el |  2 +-
 contrib/lisp/ob-mathomatic.el|  2 +-
 contrib/lisp/ob-oz.el|  2 +-
 contrib/lisp/ob-tcl.el   |  2 +-
 contrib/lisp/ob-vbnet.el |  2 +-
 contrib/lisp/org-bibtex-extras.el|  2 +-
 contrib/lisp/org-collector.el|  2 +-
 contrib/lisp/org-contribdir.el   |  2 +-
 contrib/lisp/org-depend.el   |  2 +-
 contrib/lisp/org-effectiveness.el|  2 +-
 contrib/lisp/org-eval-light.el   |  2 +-
 contrib/lisp/org-eval.el |  2 +-
 contrib/lisp/org-index.el|  2 +-
 contrib/lisp/org-learn.el|  2 +-
 contrib/lisp/org-license.el  |  2 +-
 contrib/lisp/org-link-edit.el| 16 
 contrib/lisp/org-mairix.el   |  2 +-
 contrib/lisp/org-man.el  |  2 +-
 contrib/lisp/org-mew.el  |  2 +-
 contrib/lisp/org-notmuch.el  |  2 +-
 contrib/lisp/org-passwords.el|  2 +-
 contrib/lisp/org-screenshot.el   |  2 +-
 contrib/lisp/org-sudoku.el   |  2 +-
 contrib/lisp/org-track.el|  6 +--
 contrib/lisp/org-vm.el   |  2 +-
 contrib/lisp/org-wikinodes.el|  2 +-
 contrib/lisp/org-wl.el   |  2 +-
 contrib/lisp/ox-rss.el   |  2 +-
 contrib/scripts/org-docco.org|  6 +--
 contrib/scripts/staticmathjax/README.org |  2 +-
 doc/orgguide.texi| 70 
 etc/ORG-NEWS |  4 +-
 etc/styles/README|  2 +-
 lisp/ob-C.el |  2 +-
 lisp/ob-J.el |  2 +-
 lisp/ob-R.el |  2 +-
 lisp/ob-asymptote.el |  2 +-
 lisp/ob-awk.el   |  2 +-
 lisp/ob-calc.el  |  2 +-
 lisp/ob-clojure.el   |  2 +-
 lisp/ob-comint.el|  2 +-
 lisp/ob-coq.el   |  2 +-
 lisp/ob-core.el  |  2 +-
 lisp/ob-css.el   |  2 +-
 lisp/ob-ditaa.el |  2 +-
 lisp/ob-dot.el   |  2 +-
 lisp/ob-ebnf.el  |  2 +-
 lisp/ob-emacs-lisp.el|  2 +-
 lisp/ob-eval.el  |  2 +-
 lisp/ob-exp.el   |  2 +-
 lisp/ob-forth.el |  2 +-
 lisp/ob-fortran.el   |  2 +-
 lisp/ob-gnuplot.el   |  2 +-
 lisp/ob-groovy.el|  2 +-
 lisp/ob-haskell.el   |  2 +-
 lisp/ob-hledger.el   |  2 +-
 lisp/ob-io.el|  2 +-
 lisp/ob-java.el  |  2 +-
 lisp/ob-js.el|  2 +-
 lisp/ob-keys.el  |  2 +-
 lisp/ob-latex.el |  2 +-
 lisp/ob-ledger.el|  2 +-
 lisp/ob-lilypond.el  |  4 +-
 lisp/ob-lisp.el  |  2 +-
 lisp/ob-lob.el   |  2 +-
 lisp/ob-lua.el   |  2 +-
 lisp/ob-makefile.el  |  2 +-
 lisp/ob-matlab.el|  2 +-
 lisp/ob-maxima.el|  2 +-
 lisp/ob-mscgen.el|  2 +-
 lisp/ob-ocaml.el |  2 +-
 lisp/ob-octave.el|  2 +-
 lisp/ob-org.el   

Re: [O] Bug: Broken orgmode.org links in doc/misc/org.texi and lisp/org

[Kaushal Modi]

On Sun, Jan 7, 2018, 8:46 AM Tim Landscheidt  wrote:

> (All links to http://orgmode.org/ should be updated to
> https://orgmode.org/ and a slash should be added to
> https://orgmode.org/worg/org-contrib/babel to avoid a
> redirect.)
>
> The following links in Emacs master's doc/misc/org.texi and
> lisp/org are broken (404):
>
> - https://orgmode.org/org-remember.pdf
> - https://orgmode.org/worg/code/org-info-js/
> - https://orgmode.org/worg/org-contrib/babel/languages.html
> -
> https://orgmode.org/worg/org-contrib/babel/languages/ob-doc-lilypond.html
> - https://orgmode.org/worg/org-contrib/babel/languages/ob-doc-stan.html


Interesting the code/, org-contrib/babel/languages/ and sources/ links work
fine if I build Worg locally.

@Bastien: Can you please check what's preventing generation? Or  just
copying of those sub directories on the Worg server?

And there are many more broken links (250+) on Worg (most of those are now
external links to blogs, etc that people posted a long time back). I'll
slowly work through fixing the broken links. Help from others too in this
would be great. Simply run an online broken link or dead link tester, and
you'll see the full list. I used this: http://www.brokenlinkcheck.com/, and
it seems pretty good even with the 3000 page scanning limit in the free
version. The W3C broken link detector isn't very good. Does someone have a
better way to find *all* broken links?
-- 

Kaushal Modi

[O] Bug: Broken orgmode.org links in doc/misc/org.texi and lisp/org

[Tim Landscheidt]

(All links to http://orgmode.org/ should be updated to
https://orgmode.org/ and a slash should be added to
https://orgmode.org/worg/org-contrib/babel to avoid a
redirect.)

The following links in Emacs master's doc/misc/org.texi and
lisp/org are broken (404):

- https://orgmode.org/org-remember.pdf
- https://orgmode.org/worg/code/org-info-js/
- https://orgmode.org/worg/org-contrib/babel/languages.html
- https://orgmode.org/worg/org-contrib/babel/languages/ob-doc-lilypond.html
- https://orgmode.org/worg/org-contrib/babel/languages/ob-doc-stan.html