Re: [O] Bug: Org Emphasis Issues (Trunk)

[Ian Dunn]

Nicolas Goaziou  writes:

> Hello,
>
> Matt Lundin  writes:
>
>> Ian Dunn  writes:
>>
>>> I encountered these issues this morning when I updated Org from
>>> trunk (and reloaded it with C-c C-x !). I believe it's following
>>> commit "Split `org-emph-re' and `org-verbatim-re'". I've got 2
>>> issues:
>>
>>> 1. Nothing longer than one character has emphasis. I find changing
>>> the 4th element of org-emphasis-regexp-components ("body-regexp")
>>> to ".*?" fixes this.
>>
>> I cannot replicate this particular issue. Could you provide a minimal
>> recipe for replicating?
>
> I cannot either.
>

Set the last element of org-emphasis-regexp-components ("newline") to zero, 
reload org, then try:

emacs -Q
;; load trunk org mode
M-: (setf (seq-elt org-emphasis-regexp-components 4) 0)
C-c C-x !

*abcd*

On mine, that string isn't bold.

It looks like there's some regex magic that goes on in org-set-emph-re that 
doesn't happen if the last component is zero.  Part of that magic is adding 
that *?.

-- 
Ian Dunn

Re: [O] Bug: Org Emphasis Issues (Trunk)

[Nicolas Goaziou]

Hello,

Matt Lundin  writes:

> Ian Dunn  writes:
>
>> I encountered these issues this morning when I updated Org from
>> trunk (and reloaded it with C-c C-x !). I believe it's following
>> commit "Split `org-emph-re' and `org-verbatim-re'". I've got 2
>> issues:
>
>> 1. Nothing longer than one character has emphasis. I find changing
>> the 4th element of org-emphasis-regexp-components ("body-regexp")
>> to ".*?" fixes this.
>
> I cannot replicate this particular issue. Could you provide a minimal
> recipe for replicating?

I cannot either.

>> 2. Headings of level >= 3 are fontified as if they were
>>emphasized. I'm guessing org-do-emphasis-face is considering "***" as
>>an acceptable emphasis string.
>
> I can confirm the problems with headlines, though I can only replicate
> it with level 2 headings. (Are you perhaps using org-indent-mode?)
>
> With emacs -Q and the latest org from git, if I open the following file,
> "Subheading 1" appears in bold. If I delete "Subheading 2," the emphasis
> disappears.
>
> * First headline
> ** Subheading 1
> ** Subheading 2

Fixed. Thank you.

Regards,

-- 
Nicolas Goaziou

Re: [O] Bug: Org Emphasis Issues (Trunk)

[Matt Lundin]

Ian Dunn  writes:

> I encountered these issues this morning when I updated Org from
> trunk (and reloaded it with C-c C-x !). I believe it's following
> commit "Split `org-emph-re' and `org-verbatim-re'". I've got 2
> issues:

> 1. Nothing longer than one character has emphasis. I find changing
> the 4th element of org-emphasis-regexp-components ("body-regexp")
> to ".*?" fixes this.

I cannot replicate this particular issue. Could you provide a minimal
recipe for replicating?

> 2. Headings of level >= 3 are fontified as if they were
>emphasized. I'm guessing org-do-emphasis-face is considering "***" as
>an acceptable emphasis string.

I can confirm the problems with headlines, though I can only replicate
it with level 2 headings. (Are you perhaps using org-indent-mode?)

With emacs -Q and the latest org from git, if I open the following file,
"Subheading 1" appears in bold. If I delete "Subheading 2," the emphasis
disappears.

* First headline
** Subheading 1
** Subheading 2

Matt

[O] Bug: Org Emphasis Issues (Trunk)

[Ian Dunn]

I encountered these issues this morning when I updated Org from trunk (and 
reloaded it with C-c C-x !).  I believe it's following commit "Split 
`org-emph-re' and `org-verbatim-re'".  I've got 2 issues:

1. Nothing longer than one character has emphasis.  I find changing the 4th 
element of org-emphasis-regexp-components ("body-regexp") to ".*?" fixes this.

2. Headings of level >= 3 are fontified as if they were emphasized.  I'm 
guessing org-do-emphasis-face is considering "***" as an acceptable emphasis 
string.

If it helps, this is my setting for org-emphasis-regexp-components:

(defconst org-emphasis-regexp-components
  '(" \t('\"{<“‘–"
"- \t.,:!?;'\")}\\[>”’–…"
" \t\r\n"
".*?"
0))

--
Ian Dunn