Re: [O] C-o now mapped to org-ctrl-o surprise
Hi Sean, Sean O'Halpin sean.ohal...@gmail.com writes: I was quite surprised after pulling down master to find that C-o has been bound to org-ctrl-o (commit 45d6d8f8 2013-04-05 11:14:20 +0200). I personally don't use open-line much myself so remap this key for my own use. Wouldn't it be better to do something like: (define-key org-mode-map [remap open-line] 'org-ctrl-o) and let the user choose which key does open-line rather than create a new keybinding which might override a user definition? Also, perhaps the function should be called org-open-line rather than org-ctrl-o. Indeed. I renamed the command and used remap as you suggest. -- Bastien
Re: [O] C-o now mapped to org-ctrl-o surprise
Gosh, that was quick! Thanks, Sean On Sun, Apr 14, 2013 at 9:31 AM, Bastien b...@gnu.org wrote: Hi Sean, Sean O'Halpin sean.ohal...@gmail.com writes: I was quite surprised after pulling down master to find that C-o has been bound to org-ctrl-o (commit 45d6d8f8 2013-04-05 11:14:20 +0200). I personally don't use open-line much myself so remap this key for my own use. Wouldn't it be better to do something like: (define-key org-mode-map [remap open-line] 'org-ctrl-o) and let the user choose which key does open-line rather than create a new keybinding which might override a user definition? Also, perhaps the function should be called org-open-line rather than org-ctrl-o. Indeed. I renamed the command and used remap as you suggest. -- Bastien
Re: [O] C-o now mapped to org-ctrl-o surprise
On Sat, Apr 13, 2013 at 10:28:30PM +0100, Sean O'Halpin wrote: Hi, I was quite surprised after pulling down master to find that C-o has been bound to org-ctrl-o (commit 45d6d8f8 2013-04-05 11:14:20 +0200). I personally don't use open-line much myself so remap this key for my own use. Wouldn't it be better to do something like: (define-key org-mode-map [remap open-line] 'org-ctrl-o) and let the user choose which key does open-line rather than create a new keybinding which might override a user definition? Also, perhaps the function should be called org-open-line rather than org-ctrl-o. I would agree too. I think there are few other instances of this kind of remappings; can't recall which though. -- Suvayu Open source is the future. It sets us free.
[O] C-o now mapped to org-ctrl-o surprise
Hi, I was quite surprised after pulling down master to find that C-o has been bound to org-ctrl-o (commit 45d6d8f8 2013-04-05 11:14:20 +0200). I personally don't use open-line much myself so remap this key for my own use. Wouldn't it be better to do something like: (define-key org-mode-map [remap open-line] 'org-ctrl-o) and let the user choose which key does open-line rather than create a new keybinding which might override a user definition? Also, perhaps the function should be called org-open-line rather than org-ctrl-o. Regards, Sean
