Re: [O] Some links not working anymore for me

2014-03-10 Thread Daimrod
François Pinard  writes:

> Hi, Org people.

Hello,

> For a little while, I've not been able to follow links to Org files,
> when the link contains a search to some header, and the searched header
> itself contains white space or non-ASCII characters.  I just made this
> patch that apparently helps me out of this new little misery :-).  The
> patch is only indicative: I'm not sure it is the proper way to solve the
> difficulty, as I do not really understand all the code surrounding it!

See this commit 8 days ago:
567ec87 * | Unescape links before opening them

> diff --git a/lisp/org.el b/lisp/org.el
> index a0ed137..5c41b52 100644
> --- a/lisp/org.el
> +++ b/lisp/org.el
> @@ -10555,7 +10555,8 @@ is used internally by `org-open-link-from-string'."
>(cond ((not option) nil)
>  ((org-string-match-p "\\`[0-9]+\\'" option)
>   (list (string-to-number option)))
> -(t (list nil option
> +(t (list nil
> + (org-link-unescape option)
>  ((assoc type org-link-protocols)
>   (funcall (nth 1 (assoc type org-link-protocols)) path))
>  ((equal type "help")
>
> François
>

-- 
Daimrod/Greg



[O] Some links not working anymore for me

2014-03-10 Thread François Pinard
Hi, Org people.

For a little while, I've not been able to follow links to Org files,
when the link contains a search to some header, and the searched header
itself contains white space or non-ASCII characters.  I just made this
patch that apparently helps me out of this new little misery :-).  The
patch is only indicative: I'm not sure it is the proper way to solve the
difficulty, as I do not really understand all the code surrounding it!

diff --git a/lisp/org.el b/lisp/org.el
index a0ed137..5c41b52 100644
--- a/lisp/org.el
+++ b/lisp/org.el
@@ -10555,7 +10555,8 @@ is used internally by `org-open-link-from-string'."
 (cond ((not option) nil)
   ((org-string-match-p "\\`[0-9]+\\'" option)
(list (string-to-number option)))
-  (t (list nil option
+  (t (list nil
+   (org-link-unescape option)
   ((assoc type org-link-protocols)
(funcall (nth 1 (assoc type org-link-protocols)) path))
   ((equal type "help")

François