[O] bug#10745: 24.0.93; Regression: org-meta-return does not honor vertical spacing in lists

2012-02-14 Thread Chong Yidong
Glenn Morris r...@gnu.org writes:

this:

 org-footnote.el:(defvar org-blank-before-new-entry nil) ; silence 
 byte-compiler

 is bogus (the relevant syntax is (defvar foo)).

 Probably so are these:

 org-footnote.el:(defvar org-export-footnotes-seen nil) ; silence byte-compiler
 org-footnote.el:(defvar org-export-footnotes-data nil) ; silence byte-compiler

I removed the bogus values.

Bastien, could you merge the fix to Org upstream?  Thanks.





[O] bug#10745: 24.0.93; Regression: org-meta-return does not honor vertical spacing in lists

2012-02-06 Thread Glenn Morris
Steve Revilak wrote:

 Perhaps the value of org-blank-before-new-entry is getting clobbered?

For a start, this:

org-footnote.el:(defvar org-blank-before-new-entry nil) ; silence byte-compiler

is bogus (the relevant syntax is (defvar foo)).

Probably so are these:

org-footnote.el:(defvar org-export-footnotes-seen nil) ; silence byte-compiler
org-footnote.el:(defvar org-export-footnotes-data nil) ; silence byte-compiler





[O] bug#10745: 24.0.93; Regression: org-meta-return does not honor vertical spacing in lists

2012-02-06 Thread Steve Revilak

Perhaps the value of org-blank-before-new-entry is getting clobbered?


For a start, this:

org-footnote.el:(defvar org-blank-before-new-entry nil) ; silence byte-compiler

is bogus (the relevant syntax is (defvar foo)).


Glenn,

I believe you found it.

Applying the change in org-footnote.el.patch (attached) corrects the
vertical spacing issue I noticed.

Steve
--- org-footnote.el.ORIG	2012-02-06 21:53:00.068908112 -0500
+++ org-footnote.el	2012-02-06 21:54:01.472540988 -0500
@@ -475,7 +475,7 @@
   (org-footnote-create-definition label)
   (org-footnote-auto-adjust-maybe)
 
-(defvar org-blank-before-new-entry nil) ; silence byte-compiler
+(defvar org-blank-before-new-entry) ; silence byte-compiler
 (defun org-footnote-create-definition (label)
   Start the definition of a footnote with label LABEL.
   (interactive sLabel: )


pgpTtOeIPCQCv.pgp
Description: PGP signature