[O] bug#17416: bug#17416: insecure temp files in ob-screen.el

2014-05-08 Thread Glenn Morris
Eric Schulte wrote:

 org-babel-screen-session-write-temp-file and org-babel-screen-test seem
 to use predictable temp-file names, which is a security issue. Using
 `make-temp-file', or if the file names really need to be predictable,
 something equivalent to `doc-view-make-safe-dir' (there should really be
 a general utility function for this IMO) to first create a /tmp
 subdirectory would avoid this.

 I just pushed up a fix for this issue.  Thanks,

If you mean

http://orgmode.org/cgit.cgi/org-mode.git/commit/?id=fea672d30ef4701721c0d4aa70462760a6b21be7

then's there still org-babel-screen-test.

(These are definitely fixes that need merging into the emacs-24 branch.
IIUC this means they need to be in your maint branch?)





[O] bug#17416: bug#17416: insecure temp files in ob-screen.el

2014-05-08 Thread Eric Schulte
Glenn Morris r...@gnu.org writes:

 Eric Schulte wrote:

 org-babel-screen-session-write-temp-file and org-babel-screen-test seem
 to use predictable temp-file names, which is a security issue. Using
 `make-temp-file', or if the file names really need to be predictable,
 something equivalent to `doc-view-make-safe-dir' (there should really be
 a general utility function for this IMO) to first create a /tmp
 subdirectory would avoid this.

 I just pushed up a fix for this issue.  Thanks,

 If you mean

 http://orgmode.org/cgit.cgi/org-mode.git/commit/?id=fea672d30ef4701721c0d4aa70462760a6b21be7

 then's there still org-babel-screen-test.


Fixed.


 (These are definitely fixes that need merging into the emacs-24 branch.
 IIUC this means they need to be in your maint branch?)

Cherrypicked into maint.

Thanks,

-- 
Eric Schulte
https://cs.unm.edu/~eschulte
PGP: 0x614CA05D





[O] bug#17416: bug#17416: insecure temp files in ob-screen.el

2014-05-07 Thread Eric Schulte
Glenn Morris r...@gnu.org writes:

 Package: emacs,org-mode
 Version: 24.3.90
 Severity: important
 Tags: security

 org-babel-screen-session-write-temp-file and org-babel-screen-test seem
 to use predictable temp-file names, which is a security issue. Using
 `make-temp-file', or if the file names really need to be predictable,
 something equivalent to `doc-view-make-safe-dir' (there should really be
 a general utility function for this IMO) to first create a /tmp
 subdirectory would avoid this.


I just pushed up a fix for this issue.  Thanks,

-- 
Eric Schulte
https://cs.unm.edu/~eschulte
PGP: 0x614CA05D