Re: [O] org-table debugging formula - error

2018-10-12 Thread Joe Corneli
Hi, I couldn't reproduce it with emacs -Q and a freshly built version of
org source code.At some point (make-string (car ev) ?\-) on line 2956
of org-table.el was being called with an argument that was a
non-integer-formatted value, namely 570.0.

But since I can't reproduce it at all now this is presumably an entirely
transient issue!

On Thu, Oct 11, 2018 at 6:07 PM Nicolas Goaziou 
wrote:

> Hello,
>
> Joe Corneli  writes:
>
> > Hello,
> >
> > I got an error when debugging the behaviour of a formula.
> >
> > You'll need:
> >
> > (setq org-table-formula-debug t)
> >
> > Then with any luck this should allow you to reproduce the error: C-c C-c
> to run formula.
> >
> > | Task  | Estimated Effort |
> > |---+--|
> > | INTRODUCTION  | 9:30 |
> > |---+--|
> > | BACKGROUND|  |
> > |---+--|
> > | FOO WORKFLOW  |  |
> > |---+--|
> > | BAR WORKFLOW  |  |
> > |---+--|
> > | BAZ WORKFLOW  |  |
> > |---+--|
> > | ADDITIONAL WORKFLOWS  | 1d 4h 0min   |
> > |---+--|
> > | FINDINGS  |  |
> > |---+--|
> > | ADDITIONAL ANALYSIS   | 24:00|
> > |---+--|
> > | DISCUSSION|  |
> > |---+--|
> > | BIBLIOGRAPHY  |  |
> > |---+--|
> > | Appendix: Status  |  |
> > | TOTAL WORKDAYS NEEDED | 5d 5h 30min  |
> >
> > #+TBLFM: @>$2='(org-duration-from-minutes (apply '+ (map 'list
> 'org-duration-to-minutes (list @I+1$2 @II+1$2 @III+1$2 @+1$2 @I+1$2
> @II+1$2 @III+1$2 @+1$2
> >
> > I've attached a patch that fixes the problem for me.
>
> I cannot reproduce the problem. Could you explain why you do need this
> patch?
>
> Regards,
>
> --
> Nicolas Goaziou
>


Re: [O] org-table debugging formula - error

2018-10-11 Thread Nicolas Goaziou
Hello,

Joe Corneli  writes:

> Hello,
>
> I got an error when debugging the behaviour of a formula.
>
> You'll need:
>
> (setq org-table-formula-debug t)
>
> Then with any luck this should allow you to reproduce the error: C-c C-c to 
> run formula.
>
> | Task  | Estimated Effort |
> |---+--|
> | INTRODUCTION  | 9:30 |
> |---+--|
> | BACKGROUND|  |
> |---+--|
> | FOO WORKFLOW  |  |
> |---+--|
> | BAR WORKFLOW  |  |
> |---+--|
> | BAZ WORKFLOW  |  |
> |---+--|
> | ADDITIONAL WORKFLOWS  | 1d 4h 0min   |
> |---+--|
> | FINDINGS  |  |
> |---+--|
> | ADDITIONAL ANALYSIS   | 24:00|
> |---+--|
> | DISCUSSION|  |
> |---+--|
> | BIBLIOGRAPHY  |  |
> |---+--|
> | Appendix: Status  |  |
> | TOTAL WORKDAYS NEEDED | 5d 5h 30min  |
>
> #+TBLFM: @>$2='(org-duration-from-minutes (apply '+ (map 'list 
> 'org-duration-to-minutes (list @I+1$2 @II+1$2 @III+1$2 @+1$2 @I+1$2 
> @II+1$2 @III+1$2 @+1$2
>
> I've attached a patch that fixes the problem for me.

I cannot reproduce the problem. Could you explain why you do need this patch?

Regards,

-- 
Nicolas Goaziou



[O] org-table debugging formula - error

2018-10-11 Thread Joe Corneli
Hello,

I got an error when debugging the behaviour of a formula.

You'll need:

(setq org-table-formula-debug t)

Then with any luck this should allow you to reproduce the error: C-c C-c to run 
formula.

| Task  | Estimated Effort |
|---+--|
| INTRODUCTION  | 9:30 |
|---+--|
| BACKGROUND|  |
|---+--|
| FOO WORKFLOW  |  |
|---+--|
| BAR WORKFLOW  |  |
|---+--|
| BAZ WORKFLOW  |  |
|---+--|
| ADDITIONAL WORKFLOWS  | 1d 4h 0min   |
|---+--|
| FINDINGS  |  |
|---+--|
| ADDITIONAL ANALYSIS   | 24:00|
|---+--|
| DISCUSSION|  |
|---+--|
| BIBLIOGRAPHY  |  |
|---+--|
| Appendix: Status  |  |
| TOTAL WORKDAYS NEEDED | 5d 5h 30min  |
#+TBLFM: @>$2='(org-duration-from-minutes (apply '+ (map 'list 
'org-duration-to-minutes (list @I+1$2 @II+1$2 @III+1$2 @+1$2 @I+1$2 
@II+1$2 @III+1$2 @+1$2

I've attached a patch that fixes the problem for me.

I'm on Org mode version 9.1.14 (release_9.1.14-974-ga85ba9 @ 
/Users/joe/org-mode/lisp/)

Joe

diff --git a/lisp/org-table.el b/lisp/org-table.el
index 8eb38ef68..80de97d21 100644
--- a/lisp/org-table.el
+++ b/lisp/org-table.el
@@ -2953,7 +2953,7 @@ $xyz->  %s
 $1->%s\n" orig formula form0 form))
 	(if (consp ev)
 		(princ (format "%s^\nError:  %s"
-			   (make-string (car ev) ?\-) (nth 1 ev)))
+			   (make-string (floor (car ev)) ?\-) (nth 1 ev)))
 	  (princ (format "Result: %s\nFormat: %s\nFinal:  %s"
 			 ev (or fmt "NONE")
 			 (if fmt (format fmt (string-to-number ev)) ev)